From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ackerley Tng <ackerleytng@google.com>,
Michael Roth <michael.roth@amd.com>,
Sean Christopherson <seanjc@google.com>
Subject: [PATCH v4 0/3] KVM: guest_memfd: Fix signed offset+size goof
Date: Tue, 2 Jun 2026 10:09:18 -0700 [thread overview]
Message-ID: <20260602170921.1304394-1-seanjc@google.com> (raw)
Fix a bug where KVM fails to reject a comically large offset into guest_memfd
if offset+size results in a signed, negative value. Add a testcase to prove
the bug, and to serve as a regression test.
Note, v1 and v2 was part of larger series.
v4:
- Collect tags. [Mike, Ackerley]
- Use "INT64_MAX - page_size" instead of hardcoded literal. [Sashiko, Ackerley]
v3:
- Use uoff_t, not u64. [the combined might of Sean and Ackerley]
- Explaining exactly what is broken. [Ackerley]
- Add a regression test.
v2: https://lore.kernel.org/all/20260522-fix-sev-gmem-post-populate-v2-0-3f196bfad5a1@google.com
v1: https://lore.kernel.org/r/20260522-fix-sev-gmem-post-populate-v1-0-9fc8d6437b65@google.com
Sean Christopherson (3):
KVM: guest_memfd: Treat memslot binding offset+size as unsigned values
KVM: selftests: Expand the guest_memfd test macros to allow passing
the VM
KVM: selftests: Add guest_memfd regression test signed offset+size bug
.../testing/selftests/kvm/guest_memfd_test.c | 24 +++++++++++++++++--
virt/kvm/guest_memfd.c | 8 +++----
virt/kvm/kvm_mm.h | 7 ++++--
3 files changed, 31 insertions(+), 8 deletions(-)
base-commit: d1568b1332b6b3b36b222c2868fc102727c12a34
--
2.54.0.929.g9b7fa37559-goog
next reply other threads:[~2026-06-02 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 17:09 Sean Christopherson [this message]
2026-06-02 17:09 ` [PATCH v4 1/3] KVM: guest_memfd: Treat memslot binding offset+size as unsigned values Sean Christopherson
2026-06-02 17:09 ` [PATCH v4 2/3] KVM: selftests: Expand the guest_memfd test macros to allow passing the VM Sean Christopherson
2026-06-02 17:09 ` [PATCH v4 3/3] KVM: selftests: Add guest_memfd regression test signed offset+size bug Sean Christopherson
2026-06-05 18:31 ` [PATCH v4 0/3] KVM: guest_memfd: Fix signed offset+size goof Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602170921.1304394-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®