From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AA43CFF66 for ; Tue, 2 Jun 2026 23:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780444746; cv=none; b=E3o9RxQ/yB7iBCkJFUaDo4PzQYf0YyI6bOAhOfou1ceOmQTtKL8Z2UrgpmJx/rPBBKxMHEQTau8FPehgzcgbfzEEc/we7lLak+vwrzTuc7C9qKQVBT9C1hAU84QrIG6UqEriG78LokR1393a97CJqNYETrpiHHZLYTm7W4ncl3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780444746; c=relaxed/simple; bh=Z8zc+t9FysG/A3238K7QuL+tz/0ZsCr4c3rTv316V70=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Z+8ZJR2+wLS4dtcbh11ClUPd1wml6uYUZ1ydpxozONq4k2arupj0ci98mc9Ng8mEAH7Wt6Q25pyWgog/RcDcADi40Hlx3IVJye92fnosWjGA+4ByYCdXA1SW/vnoGXnkqpU8/iHhxNx+UY+Locjk1sf9MsWO9VdW2ZSubRGkGQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=husRwNDD; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="husRwNDD" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c8514f8ed5dso9092478a12.3 for ; Tue, 02 Jun 2026 16:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780444743; x=1781049543; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0hfnKBitry7RLyqz55UndF/vQw9Tta7wZyRyA2fbEyo=; b=husRwNDDwL6ig0MoCxA7CRrosjjFEPir7xzRBrhYaNTxtTwPASLKGr2FmdejP9TcRi fbdQvz1NzhMgVcYi0Nx4Gy2/aRYFM24qTObdN1OMmROqzSeZCEOKczMiy7oWZu1hCEjD WF9xn8sRjI0OO5c+lh39IOdhgzIND/a6lWtswLgThc4JuyAEx/axz1AkspVTVWjHnXiI BJtx0dmOxAbC69hztd+Zpl9MJ5oM7K4ZPvWhcEXV7swJumRaflX0SY2i3knpXo54G2ti KEm30bpWZUNE2ZsUmzWU1JyrX35Z23X4He7KnYm6idIDBddASwbG+CJIxQX4BJ6keMlu ofWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780444743; x=1781049543; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0hfnKBitry7RLyqz55UndF/vQw9Tta7wZyRyA2fbEyo=; b=DCfewODdTz++hu9LYJ1l3+3rs1X79znx5CCwStqZQLJzWMW0TDY1EnNWt6RaghW/f3 B+Fga0XaQcb3qno3VRRk3l7ZLrg6CgprBBkWn6jiNPxKDdTeCil0DhQONSlhZDyHP3+W Dr3stoAp5LaDsgGaVg9DWlAROYRpU0ZkkxeTVAeQ0wUtYSqerx3RoosBiSPiVBFRPuhj zcqb7jJbV9A+mZgKCHSOLDQghc6yt3eiioKK1AKDAfjCFZmyI56dxtxSyxLHZuoamQe2 9zA9/e4mB18I4QWwtuJKO2mO5CWE5JKKkFZBcdSWErMBbxA74es1q9C4RkN2H+YhRYp8 mMbg== X-Forwarded-Encrypted: i=1; AFNElJ9sHjYhQA5LWQ1aMD4qd7RblLURSqu9YQnwVVFClk/8rd2m17b1oPWDQ3FAsRjRsV2aAK+vqq7W4xmI1+c=@vger.kernel.org X-Gm-Message-State: AOJu0YwZaUSt0tix5Prfbgz/Q/u9Y7xuw5sLShqYWiXn5e/hY+vu2ES1 2Q2GodbLgoAo5Ce4zglyTOHiZ3yXQEnsj3OhdOgZrsjdJ364X5qYGpw9THF7TIHyAhQAWY9crdS dvGNERE4yfaDqLshY0rxyr1zKWQ== X-Received: from pgcl27.prod.google.com ([2002:a63:701b:0:b0:c85:104d:a751]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:c786:b0:3b4:7c33:296b with SMTP id adf61e73a8af0-3b497869594mr938429637.32.1780444742913; Tue, 02 Jun 2026 16:59:02 -0700 (PDT) Date: Tue, 2 Jun 2026 23:58:45 +0000 In-Reply-To: <20260602235900.3050782-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260602235900.3050782-1-hramamurthy@google.com> X-Mailer: git-send-email 2.54.0.1013.g208068f2d8-goog Message-ID: <20260602235900.3050782-2-hramamurthy@google.com> Subject: [PATCH net-next v2 01/15] gve: don't pass in unused parameter to gve_adminq_free From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, willemb@google.com, jordanrhee@google.com, jfraker@google.com, nktgrg@google.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Clean up gve_adminq_free to not take in an unused parameter. Reviewed-by: Willem de Bruijn Reviewed-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- drivers/net/ethernet/google/gve/gve_adminq.c | 2 +- drivers/net/ethernet/google/gve/gve_adminq.h | 2 +- drivers/net/ethernet/google/gve/gve_main.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c index 08587bf40ed4..70ffed8b52c3 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.c +++ b/drivers/net/ethernet/google/gve/gve_adminq.c @@ -385,7 +385,7 @@ void gve_adminq_release(struct gve_priv *priv) gve_clear_admin_queue_ok(priv); } -void gve_adminq_free(struct device *dev, struct gve_priv *priv) +void gve_adminq_free(struct gve_priv *priv) { if (!gve_get_admin_queue_ok(priv)) return; diff --git a/drivers/net/ethernet/google/gve/gve_adminq.h b/drivers/net/ethernet/google/gve/gve_adminq.h index 22a74b6aa17e..8e80f36116ec 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.h +++ b/drivers/net/ethernet/google/gve/gve_adminq.h @@ -620,7 +620,7 @@ union gve_adminq_command { static_assert(sizeof(union gve_adminq_command) == 64); int gve_adminq_alloc(struct device *dev, struct gve_priv *priv); -void gve_adminq_free(struct device *dev, struct gve_priv *priv); +void gve_adminq_free(struct gve_priv *priv); void gve_adminq_release(struct gve_priv *priv); int gve_adminq_describe_device(struct gve_priv *priv); int gve_adminq_configure_device_resources(struct gve_priv *priv, diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index e4d78ae52daf..30bf6df4ebc5 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -2506,14 +2506,14 @@ static int gve_init_priv(struct gve_priv *priv, bool skip_describe_device) bitmap_free(priv->xsk_pools); priv->xsk_pools = NULL; err: - gve_adminq_free(&priv->pdev->dev, priv); + gve_adminq_free(priv); return err; } static void gve_teardown_priv_resources(struct gve_priv *priv) { gve_teardown_device_resources(priv); - gve_adminq_free(&priv->pdev->dev, priv); + gve_adminq_free(priv); bitmap_free(priv->xsk_pools); priv->xsk_pools = NULL; } -- 2.54.0.1013.g208068f2d8-goog