From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1065244E043 for ; Wed, 3 Jun 2026 17:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506777; cv=none; b=f4n8zz6qv5hZf1Kgp4M9GNJeNyOBSWA+ZqULo8nCiNtaXGlfnCDILZm7OPFV8Kd8UCoDNmNHet2+Kk8xRCq48d1mNRuvS9EZJS1MY5JTPP6TMzYJHPTr4oqYCdCxfF/ueDBli5AeE2VZv4sRFEfBx/qcSjBdOBoUp9d5tLun88E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506777; c=relaxed/simple; bh=E0+3xmqg4gTrbzUNQCJnc3jZRl6JO244O2IVnTrT284=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=HQbJZ62BhEBK3po6hLsrqSDywCMWz3SVnL0US/g/dfsjTIYpKzFuw0H7FETIpQQuzxpBt5vZYhSgDW1H/gjUuI/j56CWF6TloPtfjsrCEZEJCXmGfwtP9rQSaOplRZ9Z3u/6+jCHPDi8ybns0goAp+fgFA4LhuqI3hDpOrcUKR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ROQYx9rX; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ROQYx9rX" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-45ef189aa1cso4901832f8f.0 for ; Wed, 03 Jun 2026 10:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780506774; x=1781111574; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=fW6aLewYMKpXWcXrWP/jX7GmtM/ps4JaTexETYQJg+s=; b=ROQYx9rX2z9ycx4vXKY3s4OuNPJpTskh+SEmkJLvzOyYDPpZWh4SLT6AK17HWDVxSE ++hbK17MOVDl93CzBfHZlGeghNANVJ1wGIYhxBJL/IZcaHVk2utOWygGEJPiqzJdegjS /j0MvlWpApT7CsfH64CgP8At1KEAxItzDZDLe1Ip5iTrcypY7kPwI+selT8+HJH8phrH pJs/htD5pva5wOF8JahkGt4fZZp0As+KIi9YTqHJx2jRi/0TGKr3LreaeycOe+mO0kmS XCd0DFWLt2n8eH+dwhh8r3zqzoXQZMsW2PomNVuMR38nSLt8GuqLfnLzWQUBgcbVjO6U FrYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780506774; x=1781111574; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fW6aLewYMKpXWcXrWP/jX7GmtM/ps4JaTexETYQJg+s=; b=NikqFlzW4u2bUXr5dADIKxXvzZ4lriONDnqGpr8ek5I+ZxgA3IFOzp7bBlNJsEkFBP j/89OmpY1CPjaxe/+hCvagXP0cnhc+c9YZInZ+OpRh66EEbD1swpgzzOQBJoemPFN5fJ G8rkC8CIWkFGY2NhQSVeEy1o+i+LC2si4lvUqhLP6brseVD62Gel23tv0Pao6C6nN9EU iTSQ9aLiqjVwQWy3YfkQCiSD5GstfK5y1aSKag9qXzHdksncqFNbZp59TucH20dxqKzh M7kAvEaYXxdv9D+dZftTWs386u3BR9VPQ++SW2hGGrbDzcep1fSXT39WLLXWOSVxiD9C 5EOQ== X-Forwarded-Encrypted: i=1; AFNElJ+QCasp1W/08PEjgazPT+Oi9DDDXcWcHDw/pTbd3mTFCEK8CKbz/EDCRZWCctFHPTAMVUefSO7nGehSRxw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+5Kq/0VwiYWB3CjB8rGKWfKVbn0BQkaZkjldGUcwbJWjS+BXM A3uKZs3aFiALI3OLzJgFYWxp9l61v+NTb0w7C6aKOMiJ98EYZNKe/lUx X-Gm-Gg: Acq92OFXFEX6+IQ/1FME2HIEaymlWThoPpvrU2hTdC0RWQz6MRqYNXuWhTx3NEktzXP XerT02m0SJ74BL+xbrDx45eXmhvltd8gaVe2CTw7DDIoqaRm0YUKNpB1OQbpadjpYx5/COTSOEK 1ep07fJEHGg4hePTVin7AjuEkc7vN3O/6nZVsLBKts6ytd7vqIB/qFrS36dg5Z3q/KHFSbc8Z0S QQN/StmDKPq8pa8OgesfVEvYXvtNZG+A7cxNkJ/xFMw0H6KkV/YXRh43m6c2UTRzRc01OlK5w/A L+Pw9Z/7N5P4HhWoYImTq2xt1c28ls2STSrTNnc8WL8zGCTClKUcyxMnhToc2geCKg91wK0nBCT c3H4IU9m4BVekxhby4L9YtAA7CFjiDCheWaArdJTZUA9l/YAGfA+KdNPUL/zfcFtLFNWs2DLgzo kAgj7tmMqWedXz1/w+iohugQMqXFKLsyvXMshecLSaY6bQzeUC8KHZhMYw3mu4upkVxpKTHlGMK 8lniVEuZ5UG3TPInsK2Jrix0ZfezqFZp1TLIXSZNk1OYxgxzK6l9n/IW96CFfnDbptMzHxJ0MVv 8eFSPBx331T4UxaBnA+OPRHdt7femxJMU+gnvPXy9rK0Ol0DPsA= X-Received: by 2002:a05:6000:4029:b0:45d:77f4:1ac2 with SMTP id ffacd0b85a97d-460215f27cfmr7642331f8f.0.1780506774419; Wed, 03 Jun 2026 10:12:54 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0:c287:187e:fb7a:66a4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f345209sm8797506f8f.17.2026.06.03.10.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 10:12:54 -0700 (PDT) From: Joshua Crofts Subject: [PATCH v5 0/8] iio: light: opt3001: driver cleanup Date: Wed, 03 Jun 2026 19:12:51 +0200 Message-Id: <20260603-opt3001-cleanup-v5-0-3ef7b926d555@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyTHUUlJIzE vPSU3UzU4B8JSMDIzMDMwNj3fyCEmMDA0Pd5JzUxLzSAl1DE8ukVAPTNDNLyyQloK6CotS0zAq widGxtbUAjFwKeWEAAAA= X-Change-ID: 20260603-opt3001-cleanup-149be05f699b To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko , Maxwell Doose , Andy Shevchenko X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780506773; l=3027; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=E0+3xmqg4gTrbzUNQCJnc3jZRl6JO244O2IVnTrT284=; b=KTNfEVb6/E9U7e+mZm5xnkvreXcxiizZCUVa4/wmunH6gIcQgCHmTLIJqcnQxr/cbB5ZpgDfI yumddw4+cToDh86X00V1XUke3PT+BCXEVuJ8bVabJmWIWXhVdVdEbjq X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= This series deals with cleaning up the TI OPT3001 sensor driver, moving it to more modern kernel practices and improving the code style. While reviewing, Jonathan Cameron (and eventually Sashiko) found a race condition where userspace could start interacting with the device before the hardware IRQ was set up. Changes include: - moving the driver to use devm_* functions - IWYU cleanups - removal of unnecessary macros and comments - using dev_err_probe() in probe and probe path functions - checkpatch.pl warning cleanups - fixing a race condition found in opt3001_probe() function --- Changes in v5: - PATCH 7: remove dead code oneliner - Pull new review trailers - Link to v4: https://lore.kernel.org/r/20260525-opt3001-cleanup-v4-0-65b36a174f78@gmail.com/ Changes in v4: - Fix bad merge - Edit commit messages - PATCH 1: add free_irq on iio_device_register error - PATCH 8: change comments - Link to v3: https://lore.kernel.org/r/20260521-opt3001-cleanup-v3-0-820169dec8c3@gmail.com Changes in v3: - PATCH 1: fix build error - PATCH 2: remove struct device member from struct opt3001 - PATCH 6: edit return statements - Pull additional trailers from previous version's reviews - Edit commit messages - Link to v2: https://lore.kernel.org/r/20260512-opt3001-cleanup-v2-0-8018cf3a8a0a@gmail.com Changes in v2: - PATCH 1: added patch that fixes race condition - PATCH 3: remove wrong usage of GENMASK() - PATCH 4: add patch that moves driver to use local structs - PATCH 5: add patch that ensures correct parenthesis alignment - PATCH 6: change int to unsigned int - PATCH 7: moved opt3001_read_id() function to use dev_err_probe() - PATCH 9: removed unnecessary dev_err_probe() calls, reordering - PATCH 10: added patch that adds a comment to mutex declaration - Link to v1: https://lore.kernel.org/r/20260511-opt3001-cleanup-v1-0-f7879dc3455c@gmail.com --- To: Jonathan Cameron To: David Lechner To: Nuno Sá To: Andy Shevchenko Cc: linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Joshua Crofts --- Joshua Crofts (8): iio: light: opt3001: move device registration to end of probe() iio: light: opt3001: use local struct device and i2c_client variables iio: light: opt3001: ensure correct parenthesis alignment iio: light: opt3001: localize for loop iterator iio: light: opt3001: prefer dev_err_probe() iio: light: opt3001: move driver to guard(mutex)() use iio: light: opt3001: switch driver to managed resources iio: light: opt3001: add comment to mutex drivers/iio/light/opt3001.c | 383 +++++++++++++++++++++----------------------- 1 file changed, 183 insertions(+), 200 deletions(-) --- base-commit: ae8360f3715aa61714864fc81f39790cbb883d40 change-id: 20260603-opt3001-cleanup-149be05f699b Best regards, -- Joshua Crofts