From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A1E742EEAD for ; Wed, 3 Jun 2026 17:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506777; cv=none; b=i7fto8siMt7NYOXnye+k+SpztvgkeRLzhzdhhhaQVdZaChCt1QHPW8tAX2bwGVf8ErcLUxC0XK+kZk8DAbWL22lYcJRnT1KwGwDYg/2bX0UpfwdH8C2BJSvoToE1ywlbya2q1kAuRgnVa/0asL/U/ZaN7a6ioDa5M36vpChXZTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506777; c=relaxed/simple; bh=VPE1N0CcVBqslo2XPjxC64Yibn0ybQG+k6RsuywdWac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=szVVTI6FMov1KpnlBsiz884m/zg7hHiBNSV1OZyLepavPUN1THWZV9iJDeL/iTyXulOj/W78o4Q+u7OFKOwfIQoHFpKQ/dXg2CheTaydVckuDxdymzvbldA2GYlHMBCE1ItZGoDeqgUphseHFwA9mtTz6cMJjLker5WDrf18FrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAVXDmMB; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAVXDmMB" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45efb698ef2so2526386f8f.3 for ; Wed, 03 Jun 2026 10:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780506775; x=1781111575; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E4j0TI1un02xuJRUmwkXAF6i5ZkGtnqZivF2Rw6pdJ8=; b=iAVXDmMBIxqv41HbOAZS9twc3EWDm7qYqXwvovCAhSKSDIVTuRW89+T5/dR0gJaNV3 8ZPWJhBONAFZ8ybQKSsOXSl0g/RUS/QBNFnMJctF4ETv3sy5GjoWb5CBnwoK4cV8LWD9 ZATGmD+e/qqrd/i4/lKNJ76tqPrOQ6CcqtS73MAAWTOUCo/ESJoqmo/xlxtaVQZjUTEA 88+wejKcv7Sg8JFxtpWaYMHiLe7HIZDKj0b7LQW8Be7RFhC5yG6LrWd4QZYXpigr4wK7 j3RMDIhVEg2F13qYzY5J8Iwp7vEZslC5nEXrdR8BD2adCUkdot5E7RY2+f1mMfqmI2Ee 0TgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780506775; x=1781111575; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=E4j0TI1un02xuJRUmwkXAF6i5ZkGtnqZivF2Rw6pdJ8=; b=snEMv8vxzfeDxuDNIDxoJ/Rzm6OVJ6BZafhF75/MDYfcXTndXPJyGvZSP40GdLzkLh Fa3xyZBTsro2kOBirlmv7OMGxYB7W6wM0V9GBoPgevn+clfvPQW3TVrAw7Paw4PUspJy gTccp+bkMLZ0aOGtT43KTPHxZTS5qylhvzlMnZkp4+PBnYu/ZGSmiYeZ+hh38QX2QpaN DFiHzHOLHFG3p+zlx7WrdzSt5SWULIVOCiIWrkITb3xkNVtTDesZW42Eh0QdBfphGmUc 0kHlwkvHYe0CTlDg4IQxZVKr9Fqw3g7H+QLez3L58IKMLszJWGX2R0MepF4EZlkGEg7v 9G/g== X-Forwarded-Encrypted: i=1; AFNElJ9/2lPgWmuiCti/MQtk3rmSEzKGsQEj2WoBzoLLcIpRge0XWhEsF0EFQV8C0T/lLdnYwMU5Q8JEBZpLmhc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7Qk6jfCW4mDio3vsQmmB1mHOzTzD9PbrzqByjP4pnrFOItTt4 zk0FRYJWWJFyGwrAA/QRyUdeAeBOnXwtoytDJhzwQOofbEhooi/LEZzI X-Gm-Gg: Acq92OEzAlg1VFYImXMNRPJ6M72ZbqkS01HLRdGfywf1+mVtcnquTAzc7lgbJ+GmYAv 6hWaYFHpuquQ44moGWwx4hoRYA+C8AvEuaTgsmhXRIOokpSAc4yEA5uJKalzQauWz36lUsJ+4UH uZj0glDTmhWTc/EoBiVyQaS2p5I6zn03t152agS6ymk8/KCnx+PNZ4Bx3Q/Wd7UYS9Fi51fRryS 8Z7pbRJApNriHGPQhITAXRVTyVlpgNG7Rfc6zuLXzT/nNhvJMavbpC42W8bcYVc8kwtwyQmIyOy 2ACPUIu1Su0NdAzUK+VZaB1odd5D9dZTyrh75NxYAmVOSRmuQuK4RWx8r7k0TlIvM9zauKoZDz4 0ImuMJWSoCmhFvOjMXfzu5tCnCGt6gFD7m2dKzT2J8R/Gi+yGK78ftdGBrOk4lFWt4cU0Ejk58E kcxAAxT+Ff5/quMHshSXyvDfnNONojVf0Uf2P/cqR/sIcW+44GCD/qRkvt6rc7F4qYBWv9DTpgq eKjhLmPD7pDi1CBvJbN7Elw8zE0DPuFCbB/+c2DAGMXktRh9WoqtKhvqa+1PP6vl3LV3flthJDO bnlIP5JBIV2foC2m/PT7C55pCGThxCBms0Hker3H239bUbjimyk= X-Received: by 2002:a05:600c:4ecc:b0:490:b724:dbd6 with SMTP id 5b1f17b1804b1-490b724dd8emr67557545e9.6.1780506775009; Wed, 03 Jun 2026 10:12:55 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0:c287:187e:fb7a:66a4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f345209sm8797506f8f.17.2026.06.03.10.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 10:12:54 -0700 (PDT) From: Joshua Crofts Date: Wed, 03 Jun 2026 19:12:52 +0200 Subject: [PATCH v5 1/8] iio: light: opt3001: move device registration to end of probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260603-opt3001-cleanup-v5-1-3ef7b926d555@gmail.com> References: <20260603-opt3001-cleanup-v5-0-3ef7b926d555@gmail.com> In-Reply-To: <20260603-opt3001-cleanup-v5-0-3ef7b926d555@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780506773; l=1802; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=VPE1N0CcVBqslo2XPjxC64Yibn0ybQG+k6RsuywdWac=; b=z2HRwVihwymPCuEoRhCW0B/RoRNvFBQWK9OoJnIJ/qWm1XgLj3j/eB/t+Y5BF+rPYAzt7AE7I sXMuMXo5ZBnBFJFa/9FUl8MgIXiGWN8fwz9wEH6yUWLZhqOvf1j4KQO X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= Move IIO device registration to the end of the probe() function to follow standard driver teardown/setup ordering and improve driver logic. Additionally, switch devm_iio_device_register() to its unmanaged counterpart as current driver implementation mixes managed and unmanaged resources, causing potential resource leaks. Also, add iio_device_unregister() to remove() function to correctly handle teardown. Suggested-by: Jonathan Cameron Signed-off-by: Joshua Crofts --- drivers/iio/light/opt3001.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c index 03c7a87b4a8e..6a39f116f931 100644 --- a/drivers/iio/light/opt3001.c +++ b/drivers/iio/light/opt3001.c @@ -874,12 +874,6 @@ static int opt3001_probe(struct i2c_client *client) iio->modes = INDIO_DIRECT_MODE; iio->info = &opt3001_info; - ret = devm_iio_device_register(dev, iio); - if (ret) { - dev_err(dev, "failed to register IIO device\n"); - return ret; - } - /* Make use of INT pin only if valid IRQ no. is given */ if (irq > 0) { ret = request_threaded_irq(irq, NULL, opt3001_irq, @@ -894,7 +888,17 @@ static int opt3001_probe(struct i2c_client *client) dev_dbg(opt->dev, "enabling interrupt-less operation\n"); } + ret = iio_device_register(iio); + if (ret) + goto free_irq; + return 0; + +free_irq: + if (irq > 0) + free_irq(irq, iio); + + return ret; } static void opt3001_remove(struct i2c_client *client) @@ -904,6 +908,8 @@ static void opt3001_remove(struct i2c_client *client) int ret; u16 reg; + iio_device_unregister(iio); + if (opt->use_irq) free_irq(client->irq, iio); -- 2.54.0