From: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chunkai Deng <chunkai.deng@oss.qualcomm.com>
Subject: [PATCH 0/3] rpmsg: glink: smem: robustness and debuggability fixes
Date: Wed, 03 Jun 2026 18:14:27 +0800 [thread overview]
Message-ID: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> (raw)
This series makes three small improvements to the SMEM GLINK transport:
1. Use modulo instead of subtraction for FIFO tail wrap-around in
rx_advance, so the index is always normalised back into [0, length)
regardless of the advance count.
2. Add WARN_ON_ONCE checks in the FIFO read/write helpers to catch and
report broken index invariants early, rather than proceeding with an
out-of-bounds offset into the FIFO.
3. Pass dev_name(&smem->dev) as the IRQ name instead of the static string
"glink-smem". On platforms with multiple remoteprocs each SMEM GLINK
instance registers its own IRQ, and the unique device name makes each
entry in /proc/interrupts identifiable without adding a new struct field.
Signed-off-by: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
---
Chunkai Deng (3):
rpmsg: glink: smem: Use device name as IRQ name
rpmsg: glink: smem: Add WARN_ON_ONCE for FIFO index invariants
rpmsg: glink: smem: Use modulo for FIFO tail wrap-around in rx_advance
drivers/rpmsg/qcom_glink_smem.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
---
base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
change-id: 20260601-rpmsg-improvements-643a6e133f66
Best regards,
--
Chunkai Deng <chunkai.deng@oss.qualcomm.com>
next reply other threads:[~2026-06-03 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 10:14 Chunkai Deng [this message]
2026-06-03 10:14 ` [PATCH 1/3] rpmsg: glink: smem: Use device name as IRQ name Chunkai Deng
2026-06-03 11:59 ` Dmitry Baryshkov
2026-06-03 10:14 ` [PATCH 2/3] rpmsg: glink: smem: Add WARN_ON_ONCE for FIFO index invariants Chunkai Deng
2026-06-03 12:00 ` Dmitry Baryshkov
2026-06-03 10:14 ` [PATCH 3/3] rpmsg: glink: smem: Use modulo for FIFO tail wrap-around in rx_advance Chunkai Deng
2026-06-03 12:01 ` Dmitry Baryshkov
2026-06-17 10:28 ` Chunkai Deng
2026-06-14 22:54 ` Bjorn Andersson
2026-06-17 10:20 ` Chunkai Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com \
--to=chunkai.deng@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®