From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD47D2D061D for ; Wed, 3 Jun 2026 01:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780448873; cv=none; b=U0HtpThJ1R0dVJBixmCuTbV+7XnbNv+04tQYRqSR8nPPX19KHFEFJAF9rN7gVpPDtRpHdTJOnKPCJFZEGRytN4QmCFTOChVVxzYfJ+sT/kmvF2JlUUH69ol9DsxAV8c7/WakldsJkycdmpXdM5Hnvv+8b2c3/K6Cx6XVWE93BHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780448873; c=relaxed/simple; bh=jDrNY7qqpefAynj+fbrrtFDytYZBB9Nln9W+goFTlQ8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VpWYtccnw20L/NdhHuqcOVO3/Irn9qpP2ioxPuku9/vvxhbgltMcFmtU4R/BMDynQekLAvGF+HJuxsHIYSMFpD1IckcX4ctjO2xTS5XVsi75NxmrCUYpu0h6MoXIFeP1gcbkm4Q4Gbml/MqFHSvlui1y36SS0T5oqvtiZHg0NeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ECm/tfwu; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ECm/tfwu" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-517583cb07aso26073931cf.2 for ; Tue, 02 Jun 2026 18:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780448870; x=1781053670; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PMCZ3kwt54+wBckEugkgYH3+Oq9j8RKzLnXGdNOFnIY=; b=ECm/tfwuS+00T0YZRg8/sX4rA1kY9pTodpawKKNgDbLG+TSAgFGp5ot8yhEK6A0XuM kXbZD9yLumJQn8P2dHTgRKhYXOuImC8j9dmPPnNzOFnp9T4/9ukfs1eY1rZ9r/KpHV2t q7PyFUw5t+NrjdvQFWVfsjGpJZNv4CXuDHSdIcni1u3drD385FceIku7RjejWQPDZsTp tvmFGOl11Awkad/qmEIp0wS+yyPZi1aA/upQQEKvpP3FkhGySD7F4HRCadCJRfprU2f9 wg3Vi5gy9Q4CFVcIDUL5vAS6zLEjfyy9ah2vuW9t4LGbQrwzx1z6peSLxJrkr9JwWrHo INOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780448870; x=1781053670; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PMCZ3kwt54+wBckEugkgYH3+Oq9j8RKzLnXGdNOFnIY=; b=AhOmnNzM0JzT12ODfppOVuoWJBhUDJIvQrEM/FH6wJjEXqCTwGMd6Do0pnIU+cqj9C fsJDcm4L+ZDLP15wwHI70TpnWs6NHCUxaRysceUoXHSKSWRA3HfS0LaKpAalEhbk6+qz gjg/cpV/f2mn6Uo5UQtuAQ3KwI0aARmzmW9stPKjdZDawUOdhqat3A4wtzWSzuwzb/1A wbdWjnQ/+tdexZJpsYEA+W152bKYlDZdI4Fg3ysnI6P0hiRhzx8KKq5p5VqG3jR+CFUO KHkwfK2cRS8B9k3FU7DojcF2AcskB5Qp7nUpUgXv9R0Of4vWfIPu/SL/epQpisEltCid YXYg== X-Forwarded-Encrypted: i=1; AFNElJ+OcGlVGvXL4S4x1vQ6g+ljDEfyKuGHToyQGjOApVrxjGUIu/dGKSPt1pWm/zie9XujuwSK9oqd6zUZ1qk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1HZ8g8Ke5mDCSa6ILX3lkmjaLSLJgDrn8aL04QLt3ZbUMepRF 769AzPzbLNNvQcfKT/DHLWl49Kt96gjb44v6VtUNpewkoU3a5eqPs7/9 X-Gm-Gg: Acq92OGTPMcr1WkYzdncM0vCOJ6HW17pa9VkoUHjfTwptHXLqlTzItu9MPhLD5oujyC dHw9sYsunPCdhY42HEREBUYSNosV3C8kDnKQ6haSJNNSQLJ1s8DL2LyhYGi+/pxSMHUG8J2MOXl IqLvdaRjBRQHdCwB8WVC/CyySTXtIUnD9Uz8kGNYaMfjNegPIXiRAWm35yuI3QSp83ryZUZCVYU a1ofQuqqfHpiBxhOmkk3alyXTl0oyryUYr8/t9FCn0+7khIN5rebU0aMGeiZZCcvAQLfic2dLMj pj5QQA8+W2dk9o48xAXgzf6djrHbdNC0koeXkEvV279zzjGbhP2dpkzJy9rx04BvbQeW2NeiwNQ 0uz6/s84t2ESpEf9j3hdGbGwtVBHOQbPtNtaJZV0l4obSCZfqsu2DigqJbkCKjZaIWYK7RgBkfa xOXJlZ7gKyLoKWrGHn8JxfpHse9r1B6CZZoofanYERlu5Y1DQWEvq/OmD5gfW+pzS+RJMPInz4g 5WY9jFF3IE0Y5x/0qYTOkf5mhXnAqI6kGJVK2zklb1pLxb/WxtAfDFX X-Received: by 2002:ac8:5dd0:0:b0:517:6665:2a9a with SMTP id d75a77b69052e-517787bf3d1mr23491841cf.50.1780448869820; Tue, 02 Jun 2026 18:07:49 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd26b9d5sm7037416d6.44.2026.06.02.18.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 18:07:49 -0700 (PDT) From: Rosen Penev To: linux-watchdog@vger.kernel.org Cc: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Wim Van Sebroeck , Guenter Roeck , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Microchip (AT91) SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] watchdog/sama5d4: set platform driver data before requesting IRQ Date: Tue, 2 Jun 2026 18:07:31 -0700 Message-ID: <20260603010731.230581-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sama5d4_wdt_probe() requests a shared IRQ before calling platform_set_drvdata(). Because the IRQ is shared, the handler (sama5d4_wdt_irq_handler) can fire immediately, at which point platform_get_drvdata() returns NULL and the subsequent dereference of wdt->sam9x60_support causes a NULL pointer crash. Move platform_set_drvdata() to the beginning of probe, right after watchdog_set_drvdata(), so the handler always sees valid driver data. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/watchdog/sama5d4_wdt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index e82b91513fa8..024300299b57 100644 --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -267,6 +267,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) : AT91_WDT_WDDIS; watchdog_set_drvdata(wdd, wdt); + platform_set_drvdata(pdev, wdt); regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(regs)) @@ -315,8 +316,6 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) if (ret) return ret; - platform_set_drvdata(pdev, wdt); - dev_info(dev, "initialized (timeout = %d sec, nowayout = %d)\n", wdd->timeout, nowayout); -- 2.54.0