From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129C33074A1 for ; Wed, 3 Jun 2026 01:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780449214; cv=none; b=tZV9nDJKh9xFMh5RYwgiZGRNzB80KnrzA6N4Z3FAbJX4e5qSxhqYsjcn63vppLaKR4WqaaLbZGLdcR86cQyTD/abgup52/xxuQNFy+0n9UbKGULd5sztraUVaa7cdr1cm0qr8FrKwjLLgtaHs111IE9PnpWQr0H/4fh46L+xhEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780449214; c=relaxed/simple; bh=fDpc5Rrx+kA7LyjzAvSZaX9/CYeYwurvx1OcubUNZ0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p9WfMWvG5Cm77/IVJdbxIWsBoAFK1SS+TNkP/WWwI5IpBQU8opEtrCQ3Q9/ZoAzVGii6G0pF1J8oUsd/0rGdzfDziDTZncKkVx30Tau6tE6ckEvuDSQr0CPqRDQpogsE5UoxjLBVzoBAuCXwwZoer1fDfIllB/THGVcKdml3F34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=jAdvurlx; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jAdvurlx" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-5176465a4a4so21547891cf.2 for ; Tue, 02 Jun 2026 18:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780449212; x=1781054012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2cdnAPJ/txGMdC+542Rqoyln86KAovKwsF9QsCq4AEY=; b=jAdvurlxdGkdnRc4tOHKimJlgXi45EIpqUQfn6c9klp04/kxN2LO3Ap82X7otroE1S ntL9uIH3b7HF85Ux8nidq0XlTIFmjBPx6Kse/F6tSUN8dFZJ4QvIdS+D5UclDOUqlY5D XQiZ089pZFXSLKnvbQwdKE+b4PYaVd/a1iNLLhlG7zUtdcqNuh2/zpeYpv7A9CAvjcE1 wM1Dg5RHpTZsvHDr3cYoo2GB1MXwmYxP0heeyFRcta5OsnXCP8xGrwhRpYmmKjfWmGMP 1KisWityTcwSMJTGG39FjAo0kVFI/OqyWkirYLnAUNPK2HNkkULP8PzBiP/dckcSuZAb Egxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780449212; x=1781054012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2cdnAPJ/txGMdC+542Rqoyln86KAovKwsF9QsCq4AEY=; b=YucFaXo3KI1WE9ud9ZuY9+3FbdDhH5+ycDH+FEwB4jP75NQu+LKy0t8sdIeHTeG/6m RIiRYcwdJ1FXdiKTAP9xb94xFbDulNaeP152RSZEy6DuLdeR56eIc6ZQh18gb+ys/aRo DREk1FY+goUM90j76bXN+/gfaH7UyDU2PCAxFCYknh0Wdk4rsKr/1z2V/n28VyJXurVR fjWiG4md4fH7OJORQQ/uvoW8P7srEMyrjJYScXRpTrX2lHF3zgz8G7zJadikfPJE9Um4 tUOxkYiDw3mQqZrxvWa5VHiS15Jw+nQwymKGoHIQYZ8AUFlRlpIFBh9jZ+MORm/ZGs56 rsBA== X-Forwarded-Encrypted: i=1; AFNElJ9fxzvEytoza/B+xZKGpStIjjD9HaPWBoERlBmj5jwxUlitVBwd8iCF0hBYhmHMCruYjAZocj91pidZx/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwVf+yg/iXkb3ryIQ5nlUjTqZkCHlJDIUSi54QsHQ+5DFAdN2fs FteSpy/fWmdXxkH02WQ/OVvQoIs0NqBke5qu5K/+0tW1W7nUW3+h0ndStuQpLlkc47E= X-Gm-Gg: Acq92OEJ3khs1Te0w4Ltl5zpJATm2aeZJK/lxiKl1JjqQAxiufZGE97JIFFaaEoQJ+x G6x8nCk3g0EoJ9cQa1+SVtDkOBm2AYar6rthQaKaFFLirlkzUDfiq00exb1c8xjDC19ovKPTi8I xXGX5v0lXcvbnrSbG1IrEHXUlago0IjbO1274M8JK7TObBGcoas2ekZPmVux2LmtDdKmFehz28i QiBzLqGj6hCDbHgiE/uD0lxwPyEugB4jUwZazs5ZMflTBi5N/FPzL4QqJhenwXSY/tPOlHMToYD 1EpPP6RkJ16I82GMIdkkDny8RbCSDSw84WkWIl9J7kFiBvVIvJzut2B6t2+Srfie17Ce8XckdV0 xGFY5ekmZ/TjcjiG6juTjSgdXYbL2yjbVDPIkPbjQHJooGEwFGoN9UdmNgU96jYZbpxnl0TRDwm wgnIhviT0xKaJWCw7xl/FiomuCPwKKGgJy9f7JxKXL8xwZybGhlj1h6iwCGaTprAAOyzK3cyZqi dNTSZZ53CBmp8hj X-Received: by 2002:a05:622a:5b90:b0:517:7590:228e with SMTP id d75a77b69052e-517784827b9mr21839501cf.0.1780449212162; Tue, 02 Jun 2026 18:13:32 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c54177sm13497781cf.12.2026.06.02.18.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 18:13:31 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wUaAk-00000004yZP-2Ic0; Tue, 02 Jun 2026 22:13:30 -0300 Date: Tue, 2 Jun 2026 22:13:30 -0300 From: Jason Gunthorpe To: Guanghui Feng Cc: adrian.larumbe@collabora.com, airlied@gmail.com, alex@shazbot.org, baolu.lu@linux.intel.com, boris.brezillon@collabora.com, dri-devel@lists.freedesktop.org, dwmw2@infradead.org, iommu@lists.linux.dev, joro@8bytes.org, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, oliver.yang@linux.alibaba.com, robh@kernel.org, robin.murphy@arm.com, shiyu.zsq@linux.alibaba.com, steven.price@arm.com, suravee.suthikulpanit@amd.com, tzimmermann@suse.de, wei.guo.simon@linux.alibaba.com, will@kernel.org, xlpang@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v2 10/30] iommu/ipmmu-vmsa: implement iova_to_phys_length Message-ID: <20260603011330.GS2487554@ziepe.ca> References: <20260531093637.3893199-1-guanghuifeng@linux.alibaba.com> <20260602104637.1219810-1-guanghuifeng@linux.alibaba.com> <20260602104637.1219810-11-guanghuifeng@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602104637.1219810-11-guanghuifeng@linux.alibaba.com> On Tue, Jun 02, 2026 at 06:46:17PM +0800, Guanghui Feng wrote: > Migrate IPMMU-VMSA to implement iova_to_phys_length, passing through > mapped_length from io-pgtable. > > Signed-off-by: Guanghui Feng > --- > drivers/iommu/ipmmu-vmsa.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > index 9386b752dea2..a1b659ddbdb5 100644 > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -699,14 +699,18 @@ static void ipmmu_iotlb_sync(struct iommu_domain *io_domain, > ipmmu_flush_iotlb_all(io_domain); > } > > -static phys_addr_t ipmmu_iova_to_phys(struct iommu_domain *io_domain, > - dma_addr_t iova) > +static phys_addr_t ipmmu_iova_to_phys_length(struct iommu_domain *io_domain, > + dma_addr_t iova, size_t *mapped_length) > { > struct ipmmu_vmsa_domain *domain = to_vmsa_domain(io_domain); > > + if (mapped_length) > + *mapped_length = 0; Why? Jason