From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7833128AB for ; Wed, 3 Jun 2026 01:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780449427; cv=none; b=Q3ljl+YAymHmvxf0RmhVLrRMPLljI5Luw82s7xiVUb3tQ+zvfhN1aMw0j0coDBgKbjP/CaXqmxjaFT0+itYuKPGZhjHyYfatDWmJEjUX9jcpyd0aXvNmrTO3kSmEITzdLLcM0gF6JQRofpKqaTT383T80PB3+FMfRaKAXcDLg2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780449427; c=relaxed/simple; bh=AfeOHXoP4IMONW5uOULUF2nWpillreIFP9OwYK/o6Mg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6DlSj1D1ZXbn5XdarsShfuWMmwX18qQ4A5XTZHs839MSitjXs19uHaPl4yYFa0HCWgIJ7klds3a8lkiHt5zIKv4vzRo8kGMhVP/Df7DXO4hMHw2TItuWU47Q7OYM3JcRQD1oymLMOBdQS7ojLCQ7CjPcTKzyqTmuLDJ2WyzLOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=K5fQAgl5; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="K5fQAgl5" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-915660e5b8eso331234285a.3 for ; Tue, 02 Jun 2026 18:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780449425; x=1781054225; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+0q9jHEvyutbUqJNds5rNSupxxEZQmy/I4DCyfn2tFo=; b=K5fQAgl5cBbKmPdQ6W4dsu1eUVIWDx2iw/+dSAcaYUlXAjCDlWSwRhlOqZkTPTMvyG 2ppyTINfnxBvqLqwiOLYCdd7Z70gGsvHhykeg2bA4YrTkqlwTd15iyWb1FavzYJvzV8e uJfMt/vIZAdIwgPfrp758RqHaLrQVEJX2m9k1EfLHGy+gYKIUUm30JQx5TGEobSgDtlz QCjPGkgCrnRIanxrdmjBNYDw5kkmlSkT4tjzU4Be7P96fjTtXnowQZz+Qw0xqu2jNPHY QU082H+GyIe15HeJCWa6zhBub0Yvr0PlRl/3/oIxDHR+qsXxB8VZkFZIzQJt7Z0PhmQt 6OXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780449425; x=1781054225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+0q9jHEvyutbUqJNds5rNSupxxEZQmy/I4DCyfn2tFo=; b=iEKycxyGBCM4zpdDNlmLYeawNg0PPtEMB3pPWL10VtIVXlgXfPU+sKHaeutz8o2hji lKz43kZE9cxuJiHLc/TWV1+Opyjltf/s+Kyk6gVLvRBQFDQF2flWvMgqZxR6kAVJvW2z DwkcnufE1RfPXpbgfShE0MOhKNXAuC5LU7IMevNiBJUXvjfhZQZxHaNrbznT/ozpYnjK USUVrmE2ehbcxGxfD+zLNpjwBq0D23rhgJRj/B797ZRYDb3O1YGXUDJljJSO8LN6HEM9 mDJyLc+6T26G6HtDkdEWav93ip1zW9z1pPSlKgkbXYLGrtLwtuxSvsPRMMwliGM0Aygm Lkbg== X-Forwarded-Encrypted: i=1; AFNElJ99XiPdOr0onwTYUc8ktuqmypOCqaBlWd3z9aKf0dOyHhgvYNraC42npufilkOPAFefInoVpNv/MuwsouU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/A2HcICZyZOpvNKw8mnaLYPQ3nDE2H0sVubhEP9+r8OwxQHxh vnliOO+WvKGeq5x2t+8a8pQrRl7mHSJUiBplHs5f/EnE4iiTxz/ZMhk0O4gUf3uHuIg= X-Gm-Gg: Acq92OESh8e0y/BL8EKk/4OU/ybCbKSN2pKn9MiBMf/1E19pQuuHCnwKsHVIHgpSv8+ q6NR8uu4I3/nhjBH7MQEK+/spZMgOA5mwfFS4ABWVTS34L+M7je7OBGcSI7ASIExyZAhCIykk63 Q35Bj1zvmZmueZ+yYHHojbMqYPuJiZuSlJ3CvmbSRXaWGi1QXYm1T9bQfrAt0e//dh8NNw5q617 xKdhBcwELR8dhrtV3uHx5t5I7WOmOnXykFypVhsWSCFkoEuThFfvO8rkSK22Rzry/mnRMpbR5Ip mwNL9L6q8tfB1gnUGvZeMFb9ST0yB4xqXYjacWnD7Cuva/bqQU+KGi/bCl7XyryUVGejTY9HSD7 WxYpZBk2gU6dVU9OvWutmmcXq9W5WMpIGztOelnw8THbG3x5aP1T5vKADYeNwKkoVHCJ8sdsI+w aTt+z1Qi50BYj4iCDzugT94UjqD19azVMMXk7K+3AeeNU4igxNlcSTWciIXYgzqlq0u9/ibIhJA U98WWUhQeqIoEMu X-Received: by 2002:a05:620a:4455:b0:914:c788:761a with SMTP id af79cd13be357-9158a84f289mr254481885a.58.1780449425306; Tue, 02 Jun 2026 18:17:05 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a009fe7sm102378285a.8.2026.06.02.18.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 18:17:04 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wUaEC-00000004yu4-0q6Q; Tue, 02 Jun 2026 22:17:04 -0300 Date: Tue, 2 Jun 2026 22:17:04 -0300 From: Jason Gunthorpe To: Guanghui Feng Cc: adrian.larumbe@collabora.com, airlied@gmail.com, alex@shazbot.org, baolu.lu@linux.intel.com, boris.brezillon@collabora.com, dri-devel@lists.freedesktop.org, dwmw2@infradead.org, iommu@lists.linux.dev, joro@8bytes.org, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, oliver.yang@linux.alibaba.com, robh@kernel.org, robin.murphy@arm.com, shiyu.zsq@linux.alibaba.com, steven.price@arm.com, suravee.suthikulpanit@amd.com, tzimmermann@suse.de, wei.guo.simon@linux.alibaba.com, will@kernel.org, xlpang@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v2 11/30] iommu/mtk_iommu: implement iova_to_phys_length Message-ID: <20260603011704.GT2487554@ziepe.ca> References: <20260531093637.3893199-1-guanghuifeng@linux.alibaba.com> <20260602104637.1219810-1-guanghuifeng@linux.alibaba.com> <20260602104637.1219810-12-guanghuifeng@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602104637.1219810-12-guanghuifeng@linux.alibaba.com> On Tue, Jun 02, 2026 at 06:46:18PM +0800, Guanghui Feng wrote: > - pa = dom->iop->iova_to_phys(dom->iop, iova); > + if (mapped_length) > + *mapped_length = 0; > + > + pa = dom->iop->iova_to_phys_length(dom->iop, iova, mapped_length); > + if (pa == PHYS_ADDR_MAX) > + return PHYS_ADDR_MAX; ??? I guess lots of AI made this right? Please review the AI output for the little slop things left over.. I saw enough unnecessary hunks, and goofy things like putting the mapped_len zero in every driver instead of in the core caller. That said it looks pretty close overall.. Jason