From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5FF409DEA for ; Wed, 3 Jun 2026 07:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780471807; cv=none; b=Xm6dJoB0v9E6jgC7v2oSDMJadl0FOln71IGQgenj6QfashaDsyH0kNz4uhnx4w7DPSnmNuK1UAko2qIO3gCE2UqRGtV/0rbJl59mN4sHmsUqXp3zkBEXVgv3kj7b9fYITsPhGV5zLcdSYwaZs+ibwvLu8RNbxgR5vwcdqsKAnG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780471807; c=relaxed/simple; bh=zrmvg0xl0ahWyx8U34nWAZMsa1U8QvmdbZvc6silBEw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HjlG4FPJ9q4oz+2OsrDLUqlivqN7Y2pwCghD46+e+PxCwgWFOpfXFAwR7EbeKG+3d3frIenq3pqD5E1He8Yd354Hj4hYQSOxLdItzfXm58isOr972B9u300Gfbh9t+ZKMQZqn2F24++WZhqOZOJofxeu+RtMVhzAKc+5shaK9lE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NRQap0O8; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NRQap0O8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780471804; x=1812007804; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zrmvg0xl0ahWyx8U34nWAZMsa1U8QvmdbZvc6silBEw=; b=NRQap0O8bSMrKGVvsPgrrlhYam1AyxegO0PWlRUBL5GP0d0tJsmjHN/s DNCOMbMMw2+qMqPbXbDP9am+Pc+jdKln26k4D12x86M7bQkUVPfN5sef7 ZGIlwBj2xUAirrXDoCF2nl4QLhpZqskmkvoJDFkx55UTPi/L71EHzPVQO yhrfkauZy5hIs6UOLFq6UXcu+/BXv2WaqjNkE20kMhY58oFLCoVC6kyEX T0NV9YG49marMd3zPjl7xO2I2F3Hu7rXzLtYiMFEIRUw3q2FPKxF4Tb0D 9A8V1UKowB8GFjqTg93bJRWQ563pPtvi2VcDRSOxg8dgi+iAT0PvsGrhp g==; X-CSE-ConnectionGUID: hZvlp90wTi+6UsMWDmvImQ== X-CSE-MsgGUID: 4M2Pfu7IRB6jdIO8HbHItw== X-IronPort-AV: E=McAfee;i="6800,10657,11805"; a="92753832" X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="92753832" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 00:30:02 -0700 X-CSE-ConnectionGUID: XQxMBrbgTpOOP34y20aS9w== X-CSE-MsgGUID: ntrASwMFTC6tTNQ45jv1qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="245960521" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa004.fm.intel.com with ESMTP; 03 Jun 2026 00:30:00 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 8BE0A95; Wed, 03 Jun 2026 09:29:59 +0200 (CEST) From: Andy Shevchenko To: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , Andy Shevchenko Subject: [PATCH v1 1/1] um: vector: Use %pM format specifier for MAC addresses Date: Wed, 3 Jun 2026 09:29:58 +0200 Message-ID: <20260603072958.107215-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert to %pM instead of using custom code. Signed-off-by: Andy Shevchenko --- arch/um/drivers/vector_kern.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index 2cc90055499a..e09c9db4f4a7 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -1557,13 +1557,16 @@ static void vector_setup_etheraddr(struct net_device *dev, char *str) "Attempt to assign an invalid ethernet address to a device disallowed\n"); goto random; } + + eth_hw_addr_set(dev, addr); + if (!is_local_ether_addr(addr)) { + addr[0] |= 0x02; netdev_warn(dev, "Warning: Assigning a globally valid ethernet address to a device\n"); netdev_warn(dev, "You should set the 2nd rightmost bit in the first byte of the MAC,\n"); - netdev_warn(dev, "i.e. %02x:%02x:%02x:%02x:%02x:%02x\n", - addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4], addr[5]); + netdev_warn(dev, "i.e. %pM\n", addr); } - eth_hw_addr_set(dev, addr); + return; random: -- 2.50.1