From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D6D241B365 for ; Wed, 3 Jun 2026 08:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780474965; cv=none; b=gqLq25FjgcZ+k7C9KgZJrcKOwIg2z7een0P4re8Js0vDSffuo5gALCfwOGTK9pTR+85S52UbHPI+QyswLYIRMNzsmn/6pMvo+1R5z94Ay1wqnoZwf7X9inUgmUTtI/nHoo/Ml1vrxpraZnr4dWig1KLDg0TMt7ryGmB9RnmNZm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780474965; c=relaxed/simple; bh=6y+4w1hS1Md1YI8VWUS9a643QejDOTeqoIFzL2c0NCc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D1r00iUJ+cyjdhpjQa7+GusiriWXfdV11lWzyHKaneO1KXI8xcnE4dO0G8jI7uBdhs2TvXd/OARobZAfy9Wfym1eMCMbMff8dxq5iyAJm2P9UjtXF+X1dbXJ4ijq3cw4gfjUKi2ORIbhsBsyMVEmBPuzyLnVanOxxjquZm34PoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ouusLqRm; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ouusLqRm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=laeadaWwLRnJgPDd/cCtPExgX5cW5By/Q8q2Qa4Z35I=; b=ouusLqRmomz1rwdJxcBtqn8P6x jBYMuVWAF4gKKyPimhNup0sdZVVBEesxYMk8HheJdBpYTJWL4bf/vBi0UTM6D6x9ssAc557JfQb1w GoLjNfpAblgv7dfEXjHrZgq4GMssnJaaCmE5eHG/L3QThp0nZlt1yE5xVR78YEivq3fDVjFWm6Fe1 mliIK759FV8OvZdrXnJhkehhcgsVQb+E7G9NFVhEBJJVrWpUVpZ599BWKWYZlnMgoh/xIXxoqXLYj tfmLajwC7EOIy11nfCVlSVuZ2A94mmgO2DEqKpuo+WHSPlZCGZ/CEfQPGk2cCJf8C2s+zDeNzIO0M KPOUuphw==; Received: from 2001-1c00-8d85-4b00-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:4b00:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUgrm-00000003VaN-3Uqa; Wed, 03 Jun 2026 08:22:23 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id E10E1300642; Wed, 03 Jun 2026 10:22:20 +0200 (CEST) Date: Wed, 3 Jun 2026 10:22:20 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: LKML , Mathieu Desnoyers , =?iso-8859-1?Q?Andr=E9?= Almeida , Sebastian Andrzej Siewior , Carlos O'Donell , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" , Uros Bizjak , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Mark Brown , Richard Weinberger Subject: Re: [patch V5 09/16] futex: Add support for unlocking robust futexes Message-ID: <20260603082220.GR3102624@noisy.programming.kicks-ass.net> References: <20260602084648.462672743@kernel.org> <20260602090535.670514505@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602090535.670514505@kernel.org> On Tue, Jun 02, 2026 at 11:09:55AM +0200, Thomas Gleixner wrote: > --- a/kernel/futex/futex.h > +++ b/kernel/futex/futex.h > @@ -40,6 +40,8 @@ > #define FLAGS_NUMA 0x0080 > #define FLAGS_STRICT 0x0100 > #define FLAGS_MPOL 0x0200 > +#define FLAGS_UNLOCK_ROBUST 0x0400 > +#define FLAGS_ROBUST_LIST32 0x0800 > > /* FUTEX_ to FLAGS_ */ > static inline unsigned int futex_to_flags(unsigned int op) > @@ -52,6 +54,12 @@ static inline unsigned int futex_to_flag > if (op & FUTEX_CLOCK_REALTIME) > flags |= FLAGS_CLOCKRT; > > + if (op & FUTEX_UNLOCK_ROBUST) > + flags |= FLAGS_UNLOCK_ROBUST; > + > + if (op & FUTEX_ROBUST_LIST32) > + flags |= FLAGS_ROBUST_LIST32; > + > return flags; > } > Would you mind terribly if I did: 's/UNLOCK_ROBUST/ROBUST_UNLOCK/g' on the whole series? Then we get: FUTEX_ROBUST_UNLOCK FUTEX_ROBUST_LIST32 FLAGS_ROBUST_UNLOCK FLAGS_ROBUST_LIST32 which to me looks just a tad better. Anyway, let me continue staring at things.