From: wangdich9700@163.com
To: tiwai@suse.com, perex@perex.cz, wangdicheng@kylinos.cn,
wangdich9700@163.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] ALSA: usb-audio: qcom: Use PAGE_ALIGN macro for buffer size calculation
Date: Wed, 3 Jun 2026 17:11:02 +0800 [thread overview]
Message-ID: <20260603091102.231370-4-wangdich9700@163.com> (raw)
In-Reply-To: <20260603091102.231370-1-wangdich9700@163.com>
From: wangdicheng <wangdicheng@kylinos.cn>
Use the kernel's PAGE_ALIGN() macro instead of open-coding the page
alignment calculation. This improves code readability and follows
kernel coding style.
The manual calculation:
mult = len / PAGE_SIZE;
remainder = len % PAGE_SIZE;
len = mult * PAGE_SIZE;
len += remainder ? PAGE_SIZE : 0;
is equivalent to:
len = PAGE_ALIGN(len);
Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
---
sound/usb/qcom/qc_audio_offload.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index fa7ee61d6934..32982318fbed 100644
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c
@@ -1052,10 +1052,7 @@ static int uaudio_transfer_buffer_setup(struct snd_usb_substream *subs,
if (!len)
len = PAGE_SIZE;
- mult = len / PAGE_SIZE;
- remainder = len % PAGE_SIZE;
- len = mult * PAGE_SIZE;
- len += remainder ? PAGE_SIZE : 0;
+ len = PAGE_ALIGN(len);
if (len > MAX_XFER_BUFF_LEN) {
dev_err(uaudio_qdev->data->dev,
--
2.25.1
next prev parent reply other threads:[~2026-06-03 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 9:10 [PATCH 1/4] ALSA: usb-audio: qcom: Improve error logging in USB offload wangdich9700
2026-06-03 9:11 ` [PATCH 2/4] ALSA: usb-audio: qcom: Use snprintf for mixer control name formatting wangdich9700
2026-06-03 9:11 ` [PATCH 3/4] ALSA: usb-audio: qcom: Fix return value in qc_usb_audio_offload_fill_avail_pcms wangdich9700
2026-06-03 9:11 ` wangdich9700 [this message]
2026-06-04 8:16 ` [PATCH 1/4] ALSA: usb-audio: qcom: Improve error logging in USB offload Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603091102.231370-4-wangdich9700@163.com \
--to=wangdich9700@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®