mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jordan Walters <jaggyaur@gmail.com>
To: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] RDMA/rxe: Fix use-after-free of netdev in smc_ib_port_event_work
Date: Wed,  3 Jun 2026 06:09:19 -0400	[thread overview]
Message-ID: <20260603100919.268055-1-jaggyaur@gmail.com> (raw)

rxe_net_del() drops its reference to the underlying net_device
via dev_put() but does not clear the netdev pointer from the
ib_device. This leaves a dangling pointer that the async
smc_ib_port_event_work worker can dereference after the
net_device has been freed, causing a use-after-free in
__ethtool_get_link_ksettings().

An unprivileged user can trigger this via user namespaces
by creating a dummy interface, binding it to rdma_rxe, and
immediately destroying the namespace before the worker fires.

Clear the netdev pointer via ib_device_set_netdev() before
releasing the reference. Downstream callers such as
ib_get_eth_speed() already handle a NULL netdev safely.

Note: this is a distinct issue from the socket TOCTOU race
fixed by Zhu Yanjun in [1]. That patch addresses a race on
the pernet socket pointers (rxe_sk4/sk6) leading to a NULL
deref in kernel_sock_shutdown(). This patch fixes a dangling
netdev pointer leading to a UAF in
__ethtool_get_link_ksettings via smc_ib_port_event_work.

Link: https://lore.kernel.org/all/20260519023541.8594-1-yanjun.zhu@linux.dev/ [1]

Signed-off-by: Jordan Walters <jaggyaur@gmail.com>
---
 drivers/infiniband/sw/rxe/rxe_net.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index 50a2cb5405e2..a8f91d6e3b17 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -663,6 +663,7 @@ void rxe_net_del(struct ib_device *dev)
 	if (sk)
 		rxe_sock_put(sk, rxe_ns_pernet_set_sk6, net);
 
+	ib_device_set_netdev(dev, NULL, 1);
 	dev_put(ndev);
 }
 
-- 
2.49.0

             reply	other threads:[~2026-06-03 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 10:09 Jordan Walters [this message]
2026-06-04  1:42 ` Zhu Yanjun
2026-06-05 17:47 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603100919.268055-1-jaggyaur@gmail.com \
    --to=jaggyaur@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®