From: Taha Narimani <tahanarimani3443@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
gregkh@linuxfoundation.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Taha Narimani <tahanarimani3443@gmail.com>
Subject: [PATCH v2] staging: iio: adc: ad7816: Use devm_gpiod_get_optional() for busy GPIO
Date: Wed, 3 Jun 2026 12:33:33 +0000 [thread overview]
Message-ID: <20260603123333.5608-1-tahanarimani3443@gmail.com> (raw)
The driver currently utilizes devm_gpiod_get() for the 'busy' line,
which makes the GPIO mandatory. However, the busy pin is hardware-optional
depending on the specific board configuration.
Switch to devm_gpiod_get_optional() to allow boards that do not have
this pin wired up to still probe the driver successfully, and remove
the redundant conditional chip-ID check since the optional API handles
missing descriptors gracefully.
Signed-off-by: Taha Narimani <tahanarimani3443@gmail.com>
---
Changes in v2:
- Fixed trailing whitespace and missing newline at the end of the file.
- Converted the file format to Unix (LF) to remove carriage returns.
- Removed the explicit chip-ID check around the busy pin logic.
- Improved the commit message to provide clear architectural justification.
drivers/staging/iio/adc/ad7816.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 0eac484..039b34d 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -84,7 +84,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data)
gpiod_set_value(chip->convert_pin, 1);
}
- if (chip->id == ID_AD7817) {
+ if (chip->busy_pin) {
while (gpiod_get_value(chip->busy_pin))
cpu_relax();
}
@@ -380,15 +380,14 @@ static int ad7816_probe(struct spi_device *spi_dev)
ret);
return ret;
}
- if (chip->id == ID_AD7817) {
- chip->busy_pin = devm_gpiod_get(&spi_dev->dev, "busy",
- GPIOD_IN);
- if (IS_ERR(chip->busy_pin)) {
- ret = PTR_ERR(chip->busy_pin);
- dev_err(&spi_dev->dev, "Failed to request busy GPIO: %d\n",
- ret);
- return ret;
- }
+
+ chip->busy_pin = devm_gpiod_get_optional(&spi_dev->dev, "busy",
+ GPIOD_IN);
+ if (IS_ERR(chip->busy_pin)) {
+ ret = PTR_ERR(chip->busy_pin);
+ dev_err(&spi_dev->dev, "Failed to request busy GPIO: %d\n",
+ ret);
+ return ret;
}
indio_dev->name = spi_get_device_id(spi_dev)->name;
--
2.53.0
next reply other threads:[~2026-06-03 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 12:33 Taha Narimani [this message]
2026-06-03 9:13 ` Joshua Crofts
2026-06-03 9:27 ` Andy Shevchenko
2026-06-03 9:26 ` Andy Shevchenko
2026-06-03 10:20 ` Dan Carpenter
2026-06-03 10:37 ` Andy Shevchenko
2026-06-03 10:54 ` Dan Carpenter
2026-06-03 10:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603123333.5608-1-tahanarimani3443@gmail.com \
--to=tahanarimani3443@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®