mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: todo: fix typo and refine resource management items
Date: Wed, 3 Jun 2026 14:53:07 +0100	[thread overview]
Message-ID: <20260603145307.13b7d923@jic23-huawei> (raw)
In-Reply-To: <20260601190836.2766703-1-sanjayembedded@gmail.com>

On Tue,  2 Jun 2026 00:38:36 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> 
> Fix a typo in the staging documentation path and adjust formatting of
> existing entries for readability.
> 
> Add TODO items to track conversion of selected drivers to device managed
> resource APIs and evaluate usage of cleanup.h helpers for simplifying
> resource management.
> 
> These updates aim to better reflect ongoing cleanup efforts within the
> IIO subsystem.
> 
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>

Hmm. Sometimes I regret having this TODO when too many patches are coming in.
I guess it's still a useful document as otherwise we would just get the question
a lot.

> ---
>  drivers/iio/TODO | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/TODO b/drivers/iio/TODO
> index 2ace27d1ac62..17093cc6c61b 100644
> --- a/drivers/iio/TODO
> +++ b/drivers/iio/TODO
> @@ -5,12 +5,16 @@ Documentation
>  tree
>    - Yaml conversions for abandoned drivers
>    - ABI Documentation
> -  - Audit driviers/iio/staging/Documentation
> +  - Audit drivers/staging/iio/Documentation
>  
> -- Converting drivers from device tree centric to more generic
> -property handlers.
> +- Converting drivers from device tree centric to more generic property handlers.
Drop the 'more' 
>  
>  - Refactor old platform_data constructs from drivers and convert it
>  to state struct and using property handlers and readers.
>  
> +- Convert selected IIO drivers to use fully device managed resource APIs.

Mostly I'm fine with this one, but I hope adding it to the todo list doesn't
get lots of new folk taking this on. It is something that requires a non
trivial understanding of the driver in some cases!

> +
> +- Evaluate and adopt cleanup.h helpers (guard, __free) in drivers where
> +  manual resource management is still used.
Can we rephrase,

 - Evaluate and possibly adopt cleanup.h helpers (guard, __free) in drivers
   where manual resource management is still used and there is a significant
   improvement to the code flow and complexity to be had.

> +
>  Mailing list: linux-iio@vger.kernel.org


      parent reply	other threads:[~2026-06-03 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 19:08 Sanjay Chitroda
2026-06-02  8:49 ` Andy Shevchenko
2026-06-03 13:53 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603145307.13b7d923@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sanjayembeddedse@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®