From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A2A47D92C for ; Wed, 3 Jun 2026 18:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780512600; cv=none; b=V5I19EkvLFyanshhUt+LQYwaRK1mBcOMgD7zub2dIxpxZhVKHK/UWEIbAnIM1Hh89+HkbHB231QgzW8UJahxA2Br3ZYfr6lPYK8l8q9Fq/bEGkUnXZM6U2iAKI8EDdk/yGT2zEDW+foYBiir4KqQM08Uwm5LAfeopiPQdBFkNIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780512600; c=relaxed/simple; bh=8sTc3ePfTO1HkNzwXZekmT2AeOdDHgPOdpy0VtjDF3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QhUayETMDOCiZdHVErlnDIPQT8x+iGsLakY/2Va1RLL2rDGoNfeH+L5ZcI3eabR/j3D0mdj0T/H/FcXlnIrNVlxsq/2lCsU3Sat4jD/kWi9UAo7heTOqXEUtd5jv3fTAQDn0rdsz7jnusVLqKWSL5jTw2Mx7Y+DBr+tAZ1FrSAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UMWK9FZG; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UMWK9FZG" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bf2e8ccca1so35458755ad.0 for ; Wed, 03 Jun 2026 11:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780512598; x=1781117398; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTBVI1ML053TliZ0TwngU1Pm81C+cTmh1wKJVMjMXjs=; b=UMWK9FZGyn5aqZNwbAriEO048QBwpmTtpVSEIcQK/YtIKZZF25FfJusNJSweiQMBlC d9KjJfHlSewLHTMjNC5+KTtZT1wtzXCSauqu1anBXBqtmz/nqli1QwexzikRP89TEnEe 84RYhjEu7eAKa6AGupUCPSDPaEBK6jOBDmbre5fRjsIJevQfecbfEJ1NuglswXEm8tgb Ca/mZubmlAL4DGTQaaGkrEUeTQG0dRyhDTmjJhHpIRJpeFZUegUJf2/MjGBphEKaPtsn xytxdjmm+87Jldjd7L23YpDpR6UWJTfgLVtwq3WV4nuhLM4lpbJwD3TmX2ca9fMsRjiM eVow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780512598; x=1781117398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RTBVI1ML053TliZ0TwngU1Pm81C+cTmh1wKJVMjMXjs=; b=l8zapeE+NvlKIhq1YwJxQOeOtCGd9t+0G8HoPlIjfS4dnIaaTLrZ9a0Px2C6C/kiqJ ACzwaR3Tzzami+g3r4EQu1r/FTys66EkeUNEEkctGThjQmTOk9HJ0nrsSq4ba/OHTt86 2mWKE6NqjuW8//AfrGbNjxRM6tTGB82a6A3Jj9D0BvmETNdyZMy+sgOxixrEGqhXsy6H 3+w4P6vyG5QIolUxqhQv4RGJ73FGh7wMLv0sGBWye8ToqngPnxPS2kB3/JqGQpC4xuQB ijtAOwYIE8IDe8vRgC2rwnN8l3Y8p2+Ow8kW0bceMaH9SVZNfodsK2B1vtWrqwYrPNrf Vhbw== X-Forwarded-Encrypted: i=1; AFNElJ9E3rIOxw5fVXx8Ik6bgoQvFQK1PkumZENldoA7jXXzSY/TJYpp5Y45MjQrs8AjyOX9ZbCEuysgRmosPsc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5vfVeSAvgsKZiS76NARynhAYTQeWPGOYT6cdo/TtaWQnp2/Iz 0K4H7fM+UcilG0B05yabYWXfqR0aoy9g1eYmts4/QiekzdgxY3g57YLz X-Gm-Gg: Acq92OHJHUwiwW0MzoGhcqgwIwOEcarUMeVQuvwKuSLGZ/uhp8rpG6agA9sg9HQt4qh gjDpPsGQxjtf/hm7VICeP89MRLnIV2Mx9PqhD1P75lqDwJErVMr3hx4IsvlJCaJ2x+R5Z4ori5v wMpTYYBZkRDn6+C7iRiR7ciRcOzX//rjNaNZypyrcMhhiTRLl3ZuIhw7wGRRqIGVauMoXGum7oJ IscvX1WcnGB3Je8a/caFMIDDdsgmnuP4OTClloJFgz4Kb7Lqd9IiSqiKyCte9sk/QhdfWVjkso2 MXZHlEFV31mrBpRLki/egz6vDagIyyH8q55uGR8AjaLkYUjeIz46F1dDctf7EIvOj6N2hWje2Hn Dv1WFzqp54QrXNMylFWcxC4+oEEH0URnlL/4pw9e/s48wE/HrMXv/R6kn/fUfsZPTfFOcCPgMSy xFhb3ei53Oa0LmLRnt0kGeBSXTykopieeQcqpwaB+Kd1EBOpRU14IEfKBOnfD6oYqld5RiJFq0H 7N4xPpt9FNrR6FGUflnB0wevWhu7V16W1W2YyquLzRvrBsY/H/AKA== X-Received: by 2002:a17:903:4b50:b0:2c0:a373:89b9 with SMTP id d9443c01a7336-2c163a24bf2mr49596335ad.6.1780512597506; Wed, 03 Jun 2026 11:49:57 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.. ([2409:40c1:4015:6e6f:ee79:7998:9a6f:65e3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d59csm32139675ad.4.2026.06.03.11.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 11:49:57 -0700 (PDT) From: Piyush Patle To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, ak@it-klinger.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com Subject: [PATCH v11 09/11] iio: adc: hx711: localize loop iterators in hx711_read Date: Thu, 4 Jun 2026 00:18:57 +0530 Message-ID: <20260603184859.89693-10-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603184859.89693-1-piyushpatle228@gmail.com> References: <20260603184859.89693-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Tighten the scope of the loop variables in hx711_read() now that trailing-pulse selection is already handled by the callers. Also replace the 24-bit loop bound with a named constant while touching the same code. Suggested-by: Andy Shevchenko Signed-off-by: Piyush Patle Reviewed-by: Andy Shevchenko --- drivers/iio/adc/hx711.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 4ccb0bf2d71f..e5d842853b71 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -23,6 +23,8 @@ #include #include +#define HX711_DATA_BITS 24 + /* gain to pulse and scale conversion */ #define HX711_GAIN_MAX 3 #define HX711_RESET_GAIN 128 @@ -157,16 +159,16 @@ static int hx711_cycle(struct hx711_data *hx711_data) static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) { - int i, ret; int value = 0; int val; + int ret; /* we double check if it's really down */ val = gpiod_get_value(hx711_data->gpiod_dout); if (val) return -EIO; - for (i = 0; i < 24; i++) { + for (int i = 0; i < HX711_DATA_BITS; i++) { value <<= 1; ret = hx711_cycle(hx711_data); if (ret) @@ -175,7 +177,7 @@ static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) value ^= 0x800000; - for (i = 0; i < trailing_pulses; i++) + for (int i = 0; i < trailing_pulses; i++) hx711_cycle(hx711_data); return value; -- 2.43.0