From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 594F72727EB for ; Wed, 3 Jun 2026 19:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514411; cv=none; b=UuUwGlMkFBb3Q5fJnu+0xpaEyt61sBNLjEYQCPw+tijKivnuVev6kktZE7a6+YV3KqDorUXfVHFStgwDl1+U+WeuaHNir9gyJe0Y0M6hvq0vlYLkzGKq709ZrRLEXQ9NLXmpneZZB5Le9Y2Hy77/svPkwFWOChlmMwp9Lw1H86I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514411; c=relaxed/simple; bh=k5ucc/S3MeMvDpFXoS0Zsm72BMUcrkaqC2imEC9YibU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=s7CYH9LBnbTOmi5JgSc/uB3N2G6eNglkw/OckL0aR4HIAeOUadQh8szLy6AGOR+Gqlf7IeOfd3iY3QY3dKNWtOZJpPMEf6bgQjIB89oSToP24UCF5jgPZpacjCUhBdrDBuxZER3jgqcWH0tYk4XvFGw/qtcqwv8SKfLRNdX11Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nowuHSFP; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nowuHSFP" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c857d04cc99so463296a12.0 for ; Wed, 03 Jun 2026 12:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780514410; x=1781119210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KwYMAaLF5mHYedGImt+0WHoMwy3yyjRd6iX6DU10JXs=; b=nowuHSFP9eFLB53iWLPqicgylgbsJrLT3qtooKEgpXFE+4WMjTPtCIv7FlwppKfNyx Hj/7GMZO5SFjZKJO9+f0e3v4sCmhm17FQ3pA5vy36IJWzsTY3ilVVDnyMEJcnGMPZevy uLBV1PQTDf1Hs/coVn+tuHT4J6Q8KKfFVXnQfZcm+d+JL8rIVpRIwGzaTJCeGmd1KXDH x8orOWt/q2qIujnbULB+7NbCRVgy1Ttr4r8OVdh7O2UXKmVRbhFoNbsYpIHVGXMjrImk 8ysEkoBv8GOvlgq36Xt0dx66sOSaXPBKpD6CVQOVcI5gv8PjKZ2Z5fw7G8k2NLGdVSu0 +isQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780514410; x=1781119210; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KwYMAaLF5mHYedGImt+0WHoMwy3yyjRd6iX6DU10JXs=; b=qEKj4HhjGRKMIYF/ZBE+ZeOI/cegHvZSrUNylybJodT3vc9VUl5vfVvXWq6geoaZNB KsDorbGXXszX7h/4VX/Bk0qzngIsUBtEkSHQu2PhgyNpu+7cp4mQ0onz3gOActkscgjl aS1Dedv+V918N1Afpyr08TOg+9EKMHRLO5gpvL40SqDjo0HIv3nA3pQ9yuBQ0ty987jV E7FyNiTVsIJtHeqU6+SyrVFo3G9lmUt8ZzQU3affjutyI4Nou0SLYiDp98VdgvsQWQus NReh+lb4e6Qn20pZ9kY139Z1sjitrnMxyq+Unli/NvfiC2MUPUjeINYMcSXz0Z5E9urI 5ERg== X-Forwarded-Encrypted: i=1; AFNElJ92PenTw/OEdFCrsOQnzqX47PV+C7KarbEEN5ttCAJuuUbDDVUOH4mnJXY94SEfFPsa7gzei1Yx2+4d7zM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2fLNpvBsQD0uPCVMeI/hduXVLkNsZtVga/kXr60Yt4a7+pem/ 7naaPPrdbLrRk8/noPWSwiOq+PZA4pY+Um+obXkDssL2FLRi78idpzIE X-Gm-Gg: Acq92OGSXMzcPDcI8D7RRBuSxIQ2JxZOjFHPgadyQKJ9NZWMnOyomp3kNAB+TtxpDYl LilVCmR41a2JgCno0WhWP1dzfkhj1Rmvuboc5qtBMP3NbwSskMOalz0NbFqL32ESNWQJSWSord1 Gp1udUot6TaP8KxCkgFCBDMpR8SultGaCgnfa1g7GQOs7SP/jIOqAkfxB9Txf/48skG5ejlLZFr IkVt4CxN3n9gXzzJHBt2RZvL/HU+boN8SYd/qlu80OW2a9lLrMdsoABesfaTj0xta+m1sGOP1sK rTb18WX7NbbZOvfoAg3IPF2x0iUdMVvJgQgA1GQchd5P57SuNajAwQn3jbrMrqcLbCMjIRJQUnJ XVGUTvxDiARRWcNTGTgIER5L/KQJ6gCiR25sbtn/FQD+SfWDSMsdhbGicZU6Zlg6fRbq4y+yiVW NOmGw1yQlE/sEQI5JrhpXrlCDr6A1EGUHQvnlzE0dU+FCRb16x3S97mPczTXTaX79YjH8DxXOyD gP0IucQhfLVQE5fcGbBRrn586LKpIW5zVjJx1c1nzYy6g== X-Received: by 2002:a05:6a21:3995:b0:3b4:6af4:bdd5 with SMTP id adf61e73a8af0-3b4b1e4f9c7mr509069637.15.1780514409663; Wed, 03 Jun 2026 12:20:09 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04a0e9sm2548934a12.13.2026.06.03.12.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 12:20:08 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Zhang Wei , Vinod Koul , Frank Li , linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] dma: fsldma: convert to platform_get_irq_optional() Date: Wed, 3 Jun 2026 12:19:51 -0700 Message-ID: <20260603191951.5729-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace the per-controller irq_of_parse_and_map() call with platform_get_irq_optional(). The controller IRQ is optional — when absent (-ENXIO) the driver falls back to per-channel IRQs. Any other error is treated as fatal. The corresponding irq_dispose_mapping() calls in the probe error path and remove function are removed. The per-channel IRQ mapping in fsl_dma_chan_probe() uses a child device_node rather than the platform device's of_node, so it is not converted here. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 98d02809ade5..08a8090178f8 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1239,7 +1239,16 @@ static int fsldma_of_probe(struct platform_device *op) } /* map the channel IRQ if it exists, but don't hookup the handler yet */ - fdev->irq = irq_of_parse_and_map(op->dev.of_node, 0); + fdev->irq = platform_get_irq_optional(op, 0); + if (fdev->irq < 0) { + if (fdev->irq != -ENXIO) { + err = fdev->irq; + iounmap(fdev->regs); + kfree(fdev); + return err; + } + fdev->irq = 0; + } dma_cap_set(DMA_MEMCPY, fdev->common.cap_mask); dma_cap_set(DMA_SLAVE, fdev->common.cap_mask); @@ -1301,7 +1310,6 @@ static int fsldma_of_probe(struct platform_device *op) if (fdev->chan[i]) fsl_dma_chan_remove(fdev->chan[i]); } - irq_dispose_mapping(fdev->irq); iounmap(fdev->regs); out_free: kfree(fdev); @@ -1323,7 +1331,6 @@ static void fsldma_of_remove(struct platform_device *op) if (fdev->chan[i]) fsl_dma_chan_remove(fdev->chan[i]); } - irq_dispose_mapping(fdev->irq); iounmap(fdev->regs); kfree(fdev); -- 2.54.0