From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7035F383C84 for ; Wed, 3 Jun 2026 19:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514875; cv=none; b=L4RzFeHqrmfRFKE5G6oebkkjhaYMB6VzxAMm+JW98YB6E2U6cXJ/Ikbw+F5Wr7vi30GMhkYB9H0+gCHjNXGBrtAdIY2yFhW8/g4BYp2JcrXXpDZe/GiWnZEpZRwkwdUp8XjtOIWmAdKGSFc2dpjRooV+PPpfPM7tPpjy+ioKGSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514875; c=relaxed/simple; bh=9q6DUpING7t7Xrmg5p0Sx2PWzYhZ78AwiWV6omFLEIE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MJtddFaXpvjwB28zcc0aXfZdHp+viG8AzN2Mh57nLVOn3IOs/vDxJIXx4OKT3JRNlqcbwItnmp8eXF3n5KKBylgMPZaw4T5FY37OhnZCEcWkFrP99xb7C/ls/cTSapIkU8A8Z036eWc94d4x16Ui3wKe3/9+IxbYT4HLxf5oz0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZNBV4wI/; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZNBV4wI/" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780514859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LCd2JZE6WNougagJTMnn2kq3grK0eduAPPd4c0q8mnM=; b=ZNBV4wI/e5TtPidtua9p5pkIHm9dbpT5EAzjHPDw/cDFHNao5DM/cdCHTkydtcLmoJBhlH lJT1Vc/bcgxnOuVJyT4YD3Fx0RdINiuzcpK19ieudZi+qGcixAMiC7Q/W23hPUtnybRGu1 QSYRD6pCM1T6mKDJlGSGYOQMJT2PPM4= From: Thorsten Blum To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: Thorsten Blum , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] crypto: atmel-i2c - improve comment in atmel_i2c_init_ecdh_cmd Date: Wed, 3 Jun 2026 21:27:10 +0200 Message-ID: <20260603192708.1237715-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=882; i=thorsten.blum@linux.dev; h=from:subject; bh=9q6DUpING7t7Xrmg5p0Sx2PWzYhZ78AwiWV6omFLEIE=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFkKDTwqn85/MRHMvPMxe6Hh79kB1yU3HhMNfehYtU1Pb dOJmHPXO0pZGMS4GGTFFFkezPoxw7e0pnKTScROmDmsTCBDGLg4BWAi7GEM/6xnf5Xxz88V9JNq uSGr/GJr1ZqjPx+IXnsgfsh40upZblmMDP1zeu/uyLLcl8n0Pfdg6l3V2wI8Ti0WuwzNDhzz99l izg8A X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Clarify that a P-256 public key is encoded as two 32-byte coordinates. Signed-off-by: Thorsten Blum --- drivers/crypto/atmel-i2c.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c index ff19857894d0..24bded47a32b 100644 --- a/drivers/crypto/atmel-i2c.c +++ b/drivers/crypto/atmel-i2c.c @@ -138,9 +138,8 @@ int atmel_i2c_init_ecdh_cmd(struct atmel_i2c_cmd *cmd, cmd->param2 = cpu_to_le16(DATA_SLOT_2); /* - * The device only supports NIST P256 ECC keys. The public key size will - * always be the same. Use a macro for the key size to avoid unnecessary - * computations. + * The device only supports P-256. Its public key is encoded as + * two 32-byte coordinates. */ copied = sg_copy_to_buffer(pubkey, sg_nents_for_len(pubkey,