From: Borislav Petkov <bp@alien8.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-edac@vger.kernel.org,
Johannes Thumshirn <morbidrsa@gmail.com>,
Tony Luck <tony.luck@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt
Date: Wed, 3 Jun 2026 18:54:28 -0700 [thread overview]
Message-ID: <20260604015428.GFaiDa1EV5la6L5ATr@fat_crate.local> (raw)
In-Reply-To: <20260603191908.5618-1-rosenp@gmail.com>
On Wed, Jun 03, 2026 at 12:19:08PM -0700, Rosen Penev wrote:
> Use platform_get_irq() to retrieve the interrupt resource instead of
> directly parsing and mapping the OF node via irq_of_parse_and_map().
> This is the standard pattern for platform devices.
>
> In addition, platform_get_irq() returns a negative error code on
> failure, which is now checked. Since we are no longer using
> irq_of_parse_and_map(), we do not need to call irq_dispose_mapping()
> on error or driver removal, so remove those calls.
>
> Assisted-by: Antigravity:Gemini-3.5-Flash
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/edac/mpc85xx_edac.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
I'd let Johannes comment here. AFAIR, he doesn't have the HW anymore and
I don't know who can test this for us so...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-06-04 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 19:19 Rosen Penev
2026-06-04 1:54 ` Borislav Petkov [this message]
2026-06-09 5:59 ` Johannes Thumshirn
2026-06-10 17:33 ` Borislav Petkov
2026-06-10 19:37 ` Rosen Penev
2026-06-11 5:55 ` Johannes Thumshirn
2026-06-12 15:38 ` Borislav Petkov
2026-06-12 17:05 ` Johannes Thumshirn
2026-06-28 23:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604015428.GFaiDa1EV5la6L5ATr@fat_crate.local \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@gmail.com \
--cc=rosenp@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®