From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0F73CAE6C for ; Thu, 4 Jun 2026 05:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552061; cv=none; b=XI/WCYr2XXujkBg5wbmo38feQPizuB2ehLVUY7+v8nnHMEd3K9j/NUdzWCDriPtelrsGpmO/X93jAhao2SDwFpFd2KJnJpRqTAhR/05N+8he/EbAiT3O9liNYlGmIPTYeWYnJ2rghd6tfm6f2eCeBrirrNJ+NWUHy6WnW0iq+sU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552061; c=relaxed/simple; bh=tk4ZTLSpuBV0vLnGQm6/ub+TQu7Nzn9oYDC4nt7dZQk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=niRtS4i0QQA10SzE88ShCb5SQimNAdDYOM0tQDrGfQ69O1Br1A89UmH5uuO+cBQzld8mIfk9PjopkKaz3CrXS9dGjCqmLlt+jSgRQAFbCuhXkzhHegEGplQfz8NDcyp3GJyGoztjFKM79d6U2uEamziR9B26+frADzXucrX1z9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oEBePjpB; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oEBePjpB" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-304d7f31215so229903eec.1 for ; Wed, 03 Jun 2026 22:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780552057; x=1781156857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IDh+0mmq2ElVGPP6otq5g/wG5tXqB5OPCZKxXb0oguQ=; b=oEBePjpBofeiZ/bVIHOgXUzMV0eaD1P52ppCE+JAzC079K382LTBAUcXjn2mzb4zZU 4CMtPbo6VOP7IIw1itbuxh4j/wC+KzmF4GhwZRnBwKn5yfYlXmmmBtfm6LdQxlfzRH+r l/Z4MktgoXf5ytvxX2DCRNVlspJtQ5KE1vdY/ubnX4+vYB6hdp1BO237dRw1L3/Ss8KZ XtlmlHBw0dt26X6ZposJohTVCoMs8SiOfZU2Zc0yZVhHuxyYysyC4/V0hG3egWLtVgHO cD5Vcbi6b6MWp0HMfMF5B5+URnnMklRGLgnz6N6lT7z4szdOYqZBKg9cjDfcdDocYGf8 QMvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780552057; x=1781156857; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IDh+0mmq2ElVGPP6otq5g/wG5tXqB5OPCZKxXb0oguQ=; b=QxbMpoqcUSA1VDth8qK7mdFa2uzaTvhg2C7vRoqJLDAg6ZUeL1SBtDlbSqz8+IQg6R iFrtOL6U91U64l7cFBDZEvdSW2Z4Mrshsm3W2pxrCAgrY3aN4/pH/ZQvIo1sW97G/DV+ mpt5IgpjSJ3Lem9hQN0aqE35YeS8o6lylshL3mwky7X3wQMzRFLpV+PHsKSpEMXPlMc4 m4Yvzs+8BCagse1ivrzYqHRZe6KbD9dTcc8kNkbIm6GlhdSvrm9PP41XshZn+DPWR1aI 0hhshnMkHj+UJ8hn4b1BzMpsRDsv5fCVKRvnDUC+qEoDyWM8BfTq/V0wBjDNcZZat7c2 Pe0g== X-Forwarded-Encrypted: i=1; AFNElJ81OlrY9SfZzqDyAnO6c4Tgikn4Ld64mstaVqS3WGgBmzNC9Wi0vuAcGYWyZpjwRKj1vwl86b7ngRmOVEQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyQh7x+R5HQJY0NI+7fp66X0AWTBC9BOH3bRhuYXgtdCb3lvV/L 3n9/T9hp6/63zD+oYVSF1le/M55bQreS8BUytGQl/qla+26cw8AUPOpv X-Gm-Gg: Acq92OH+6zddy8aJbnIocFwABc6kUMpgxR67bIs9DDS9VZR+M9REjgfjfJ3xW0neBHg zDGtjuRA27Te9GWhzUXVakQmf8SECMyLwm6MkiEmmWCHderfWS7+/YVwQk7WdkqRrSL2dA4QDCy CGGegcks5RC80L20cfWlzahL2PV0FHRM0Kkr8Z2tpqPB6nSwBJI4z7LPYWFzKqLYAuTldCBmlIh bYSTSm5hIU+pKRAJVDXpt44VVw2SP8QicTTbSMuploldPMUOjWCk3fbaNvhzp+M0j9ukPv+tq4C GC2bNSicKSkhTdJlbPS5+6OUVYxUvqJY6F6I/+xSXwUJa6G7tTwRYNIGhvED5tgsqIbKVq9RkW8 WoVFYId3VsFhBZeUITMAdGikioJnnyMGheZME5ZKz8DV5j3RRK6pOqttehZTMUVVV4Z+O+vwDfz BQ3gBfkP/te+48hPwlFzq40dvJWqovAmAiC6fmY3m4TEPOKXmgQXjoSx7dTDDJg6LfbjI9a1yXy pre X-Received: by 2002:a05:7300:a897:b0:304:819f:5029 with SMTP id 5a478bee46e88-3074fa65ae8mr3324341eec.2.1780552056888; Wed, 03 Jun 2026 22:47:36 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074db55f60sm5565455eec.6.2026.06.03.22.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 22:47:36 -0700 (PDT) From: Hungyu Lin To: vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org Cc: abhinav.kumar@linux.dev, stefan.schmidt@linaro.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] media: qcom: iris: cancel sys error work on driver removal Date: Thu, 4 Jun 2026 05:47:08 +0000 Message-Id: <20260604054708.42426-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cancel sys_error_handler before tearing down the driver. The delayed work may still be pending when iris_remove() runs. Since iris_core is allocated with devm_kzalloc(), allowing the work to execute after driver removal could result in accessing freed memory. Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks") Signed-off-by: Hungyu Lin --- drivers/media/platform/qcom/iris/iris_probe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c index ddaacda523ec..1a740542bc81 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -192,6 +192,8 @@ static void iris_remove(struct platform_device *pdev) if (!core) return; + cancel_delayed_work_sync(&core->sys_error_handler); + iris_core_deinit(core); video_unregister_device(core->vdev_dec); -- 2.34.1