From: Wandun Chen <chenwandun1@gmail.com>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: robh@kernel.org, saravanak@kernel.org
Subject: [PATCH 1/2] of: reserved_mem: avoid stack buffer overflow in fdt_scan_reserved_mem()
Date: Thu, 4 Jun 2026 15:36:10 +0800 [thread overview]
Message-ID: <20260604073611.3954433-2-chenwandun1@gmail.com> (raw)
In-Reply-To: <20260604073611.3954433-1-chenwandun1@gmail.com>
From: Wandun Chen <chenwandun@lixiang.com>
Sashiko found a potential stack buffer overflow in fdt_scan_reserved_mem()
due to missing bounds checking on dynamic_nodes_cnt [1].
Fix this by adding bounds check.
Link: https://sashiko.dev/#/patchset/20260604015332.3669384-1-chenwandun1%40gmail.com?part=1 [1]
Signed-off-by: Wandun Chen <chenwandun@lixiang.com>
---
drivers/of/of_reserved_mem.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index ce1d5530ec0f..27dc98aa9bf9 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -346,6 +346,12 @@ int __init fdt_scan_reserved_mem(void)
err = __reserved_mem_reserve_reg(child, uname);
if (!err)
count++;
+
+ if (dynamic_nodes_cnt >= MAX_RESERVED_REGIONS) {
+ pr_err_once("Reserved memory: reached MAX_RESERVED_REGIONS(%d)\n",
+ MAX_RESERVED_REGIONS);
+ continue;
+ }
/*
* Save the nodes for the dynamically-placed regions
* into an array which will be used for allocation right
--
2.43.0
next prev parent reply other threads:[~2026-06-04 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 7:36 [PATCH 0/2] of: reserved_mem: fix stack overflow and make dynamic reserved region configurable Wandun Chen
2026-06-04 7:36 ` Wandun Chen [this message]
2026-06-04 7:36 ` [PATCH 2/2] of: reserved_mem: add config to extend dynamic reserved memory regions Wandun Chen
2026-06-04 19:33 ` Rob Herring
2026-06-05 2:21 ` Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604073611.3954433-2-chenwandun1@gmail.com \
--to=chenwandun1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®