From: Hungyu Lin <dennylin0707@gmail.com>
To: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev,
bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org,
stefan.schmidt@linaro.org, Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH v3 2/2] media: qcom: iris: rollback OPP vote on PM resume failure
Date: Thu, 4 Jun 2026 09:00:59 +0000 [thread overview]
Message-ID: <20260604090059.46355-3-dennylin0707@gmail.com> (raw)
In-Reply-To: <20260604090059.46355-1-dennylin0707@gmail.com>
Rollback the maximum OPP vote when
pm_runtime_resume_and_get() fails in
iris_enable_power_domains().
This ensures the performance state vote is released when
power domain enablement does not complete successfully.
Fixes: bb8a95aa038e ("media: iris: implement power management")
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/media/platform/qcom/iris/iris_resources.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
index f5e3341e1430..a7d25f7a201a 100644
--- a/drivers/media/platform/qcom/iris/iris_resources.c
+++ b/drivers/media/platform/qcom/iris/iris_resources.c
@@ -79,8 +79,10 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev)
return ret;
ret = pm_runtime_resume_and_get(pd_dev);
- if (ret)
+ if (ret) {
+ iris_opp_set_rate(core->dev, 0);
return ret;
+ }
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2026-06-04 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 9:00 [PATCH v3 0/2] media: qcom: iris: fix runtime PM reference handling Hungyu Lin
2026-06-04 9:00 ` [PATCH v3 1/2] media: qcom: iris: fix runtime PM reference leaks Hungyu Lin
2026-06-07 20:09 ` Dmitry Baryshkov
2026-06-04 9:00 ` Hungyu Lin [this message]
2026-06-07 20:08 ` [PATCH v3 2/2] media: qcom: iris: rollback OPP vote on PM resume failure Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604090059.46355-3-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome