From: Bryam Vargas <hexlabsecurity@proton.me>
To: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
DaeMyung Kang <charsyam@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntfs: validate $FILE_NAME length before converting the name
Date: Thu, 04 Jun 2026 10:17:37 +0000 [thread overview]
Message-ID: <20260604101733.132709-1-hexlabsecurity@proton.me> (raw)
In-Reply-To: <CANFS6bYtjMEtu_pn=XzrRd1Vyof00T75G3UEB9vLSy9Wqz2v2w@mail.gmail.com>
Hi Hyunchul,
> There is already a patch that validates this in ntfs_attr_lookup().
> https://lore.kernel.org/all/20260530143514.3083601-2-charsyam@gmail.com
Right -- DaeMyung Kang's "[PATCH v4 1/6] ntfs: validate attribute values on
lookup" already rejects a $FILE_NAME whose file_name_length overruns the
resident value_length (ntfs_file_name_attr_value_is_valid()), and does it in
ntfs_attr_lookup() so every caller is covered, not just
ntfs_is_extended_system_file(). That subsumes this patch -- please drop it.
I'll leave the fs/ntfs attribute-value hardening to that series.
Bryam
prev parent reply other threads:[~2026-06-04 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 5:39 Bryam Vargas
2026-06-04 9:01 ` Hyunchul Lee
2026-06-04 10:17 ` Bryam Vargas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604101733.132709-1-hexlabsecurity@proton.me \
--to=hexlabsecurity@proton.me \
--cc=charsyam@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome