From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A7647ECFE for ; Thu, 4 Jun 2026 13:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780581317; cv=none; b=jUeZ0ss71CmhtkJV5vuz0zN9mLjcYnwrvOLanToEcMGKiDSxHLZjI2Wg0oFPsiBUd6CF26uZc9S+13qC8FSRvzZYcVW8slswMoZOK7z6gnAyF5gasLJGz95g+0Q8IvrVaR6mPnjamX+UKaHr6LgVI8PyLWjLzWeaAgaNvgNqMmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780581317; c=relaxed/simple; bh=iF7WCv4wmE3jhYpLVuN3TOW+xLwQtrOWCAJnqZuqxcY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c6eicQo2taWBgHVHhfAjlXnM8Wq5+RRSJ2ryOCqr6Yetvxa2amTtgKzkETeB98G/BSaFy5vd1l3Huy5kYIBm+DoubSpLhKF150Ti9HpG56Wqh94V9nAkkETjNObVjEkAIuagS7Wl/woYB449s1GQQCtbltWOvPE48FaPpuMKtSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=jf/A2ekO; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jf/A2ekO" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51776b4de37so5933241cf.1 for ; Thu, 04 Jun 2026 06:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780581315; x=1781186115; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n2gwWaDWtdfpLdLmO97cF7KayysA1VPOkDxjxrlqS/U=; b=jf/A2ekO2aTUp3BmaM14X1wDQsLGFMqEQbO80bIXLPyMmkzVKj8aVuEbwJP5V5kp4R 7CqGE8k6PYKrhfhKw6x6gwG0XnddmB7huKvWy34EFbKpu/MsngVju9AxgMiLTkv3v/sH Rn+ibf4LElgp/l8MLRwn8gi6ahGVl/6ipEP5vlaVksDkoK0I1O5AhVki9Tn4nsdUx/Fh 59NLaLve6usTOLP1OSXb/qqLx9h86m0S4fGH4AHTHoqnxKzHQIHt/2SwQZQz6xiKS/V5 /NlQE2OKuvqK0NMTharxZBR+tJGlbUOwKk91blrMczto5yK2oATzUGCPm+YxWKUY7VDj BT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780581315; x=1781186115; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n2gwWaDWtdfpLdLmO97cF7KayysA1VPOkDxjxrlqS/U=; b=beX/hR9qjgM3+IZOkzKUqx/shP5Ek5tOBkfMmmYPgj6sNX1nWk9oXRhxU9lziM5HhY +X/b5gXBY9/nlz76Y8gPudtSP4m8yutO+pmdMcwUlefgTcMgigG5TxhLdBLq9mOo4PIW 6NAX4hwVxQPU2gugTAcyt7enJ4HmJ46w9Wtu+JYbUeSXaM6eDeoQevoTYMoiTGqqe/S0 eV+ZGiYHkTlwMKe8op17F8o3ezCWhr5ZzdaEReZHWWLL8dr93FlWkOkCCv3swBzHIxs9 5x+YRmZcHlPCTx8eG6bgo46tfD3wscImwlCKg6Zg+T27yo/XqlQduFDEML0Z0ib+8pSG 3OiQ== X-Forwarded-Encrypted: i=1; AFNElJ+g9Baah30oT5MNHS5rPRyTfaghPaF1yZO4v5rj/DYMOmHWapQrl2E+q5qFdh8BUvUosLTCwyRf7GF04ho=@vger.kernel.org X-Gm-Message-State: AOJu0YwNCuyd26NSzPfwOLvEPLIgYLR+0c4Ek9znc30BoVDyhYKBm1nu BebuUkbg2TsyJW43Cj3z8n33LDDKxWWagUIw8BXND6QVhrKoS7GiWzNw6VzaxJRa3jI= X-Gm-Gg: Acq92OEmJAYOOcwO2WvuNaQxnO2PquKmCB0I/i7n3YRwy3k67yBpDvbNehqY1ptyC6Z /usOXujdW5X0fbZOv9GyI6T0Po+0s/8CWZtnBBrTv2zn5OkAQz8rbVdS7lDetqG+gt9BpwJunyT GXDLO4uABBntQwu1nig61aQFufoFotsBA0EmpNgehMijSsI8zrSszT4cpaF1k+IyPtX0YrpModC tq5tV6Le2Y70Nx1LvplslLy4BIJv92bsoGNDXYm3HDeA9hOHhu8179y2+Vq5EnR33qLlYXIvlJO iN0Wad3mse42eDfmlOrDnbJke2YKf/oqlPNX9NjHeskc4K2AU7HFPN0dCw3NGzQ+t1WxTNwu6pQ smdKxGpBGNvrYAXjyMsNwn+AxMxPelc2+m9KBgwn/uOHymXZANQd876zIo0W2Uvc55shp8rWt/D yT3YpDJnOdPUTondvszTHO4I6cC2GyhMxKybiRhqRxVa/fSJhfh2oX4Yi5aG36LTWhhAjWMN8N1 P670svTTtAVIE9G X-Received: by 2002:a05:622a:1c19:b0:50e:5ffd:deb9 with SMTP id d75a77b69052e-51778696aeamr109514391cf.31.1780581315064; Thu, 04 Jun 2026 06:55:15 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd263003sm53394316d6.42.2026.06.04.06.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 06:55:14 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wV8XR-00000008FXK-2ZEe; Thu, 04 Jun 2026 10:55:13 -0300 Date: Thu, 4 Jun 2026 10:55:13 -0300 From: Jason Gunthorpe To: Jacob Moroni Cc: Gui-Dong Han , krzysztof.czurylo@intel.com, tatyana.e.nikolova@intel.com, linux-rdma@vger.kernel.org, leon@kernel.org, mustafa.ismail@intel.com, shiraz.saleem@intel.com, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com Subject: Re: [PATCH] RDMA/irdma: Use acquire/release for CQP request completion Message-ID: <20260604135513.GU2487554@ziepe.ca> References: <20260604083440.426033-1-hanguidong02@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 04, 2026 at 09:41:24AM -0400, Jacob Moroni wrote: > Makes sense to me. > > That said, I wonder if we should just get rid of the wait queue + explicit > flag and replace it with a completion? Yeah, then you don't have to worry about this.. IMHO the driver was following a fairly common pattern for wait event that is indeed probably incomplete. Jason