From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F109747ECE6 for ; Thu, 4 Jun 2026 14:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583168; cv=none; b=pMWkrzdbn4bOGWvIlFwCiyUfUPbZhs5RH44GOMS6Aieam2KxDljN904tjzMBEYLaY3HkOhEtxqs68+rkvhB+03v06mZbN1zws6CWwUN8xDyO1ghVYjyEcx8GrKtjytXQ87Myv1YZ3cNijw5f4X0ZgDlxZ++CBwIchoGRm9rZzN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583168; c=relaxed/simple; bh=RpbeXNzXxaadmZyS/Fy/cu0dWgb+zuhOaJLik03FN/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OHRwYv/3HBeeasABmGk1yKAM5ptab4OPM3dn0qtk9hExCajMiBOTY8SFpaYzQuRzKAzcUK80d8yujIXx0EKWD43yrZdCOHKJPmyO0Hq9MtXgivgWRHjTs8sgqMcVCIUApMRFfvk2RDi+Bus2H7H/7uIjJhKaoiQ5kn6tWPJ31+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=G9eJbb9j; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="G9eJbb9j" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5174a3d9598so7008681cf.3 for ; Thu, 04 Jun 2026 07:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780583166; x=1781187966; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=clkIHT02uZl46rCjOXn4DL3sKNX9XCKfChcmoui9JdM=; b=G9eJbb9j/eC1Tgq00ZgL0IBkvqoDh0bchFQu3FJ0++gYRD+SymJpykHRrQR/BXR8y7 CuMWmdggusryjISG7hJ9f01IRflTSQMgkuGYOYtL/AqVmJoQb87du/YatXxnKK+h5rAy VNuC6sbrssE8sAlQWw09nb5qkfF4bTps3y2pHGi74WhGS+JM0W9pU1p319++VCZ5vsxv NoOQcFwYNv6Eoh4m5MUhi+c8PlbLPAmX1v8rA0XntySSeGkQNL2LDgXF/pXtvuzlOkQ2 ysf7dEhmHtwFW4LvxH3XkjQRzTFKHdVbTkF8osh0a5VfuUuqAZ0sSzGPlyPRdSZcLn3h 7s2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780583166; x=1781187966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clkIHT02uZl46rCjOXn4DL3sKNX9XCKfChcmoui9JdM=; b=K6NGLbxUc0eokF54ld0bogXMDONTvEUIgsnynT2LLObEzptWhFpxd3me+dW1qdzMce YLIcuBNC02ZRVE+dBS51Prb391jxw5y6QDRmNl69Cf904dNPL6tPcumKM48LUS9GJG/K Es9j1BpNf/a9FP/oQGAT+Xj5gIsgftlHMj0DD0oEgYzA1a/RoE91+E6S/T6K/vj58MQL DFolhoN59hlWFO1U/x9DZ6/UvsxkpQi+JkUfjObQhaFyWX+/L1wGyjfcrUKJRQem66XB WH+GAatCdU8PYs27E/eotY8HJ8y/WbVzW7jlsBpCKQElI/oxcrxgybR/whR4eGyLfOyb zR8g== X-Forwarded-Encrypted: i=1; AFNElJ85pOGfi7i/nf1GB1ZPpJANx5UVFaARk+kZZnEyXbUBhVGpc4d3P1G90HIavgRplPObk/KsiBUuiStTvkw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5q6orXfGg9qvhr+tcOElc4oQoXmRoRgBCp0Yd1rkL2w/vhkJ6 PG4vtQ7ipr9AuS12OIaA2wZGM9N8EwWUpy+UHESeszsAy/M8w/l7cGt3eOdgQ+3z670= X-Gm-Gg: Acq92OFR+r/mRxUyyc7YHTykin8rkvAKJ+puJP8G3/+uMoRg1WKMU9C7gU9T74ugQWX t+9E9leL6TWdAjAPEVxJKlDthoT7UWyVUazq4exlWXA8Fyx0DfCF81GNqC5Allc18IdHdfKVFHg uG1ttJQ673hYFXAlSeBqOafDWeIBOFImDOu0TqLaUzOjqlwx99pV8LeUfEhNh5t7ZLvy5uZgNw1 pTW5B9IxhMluPg3lMFqxSMAqT02HlnRyzp9gXIdWTP6gG92P9sS4bveGDocvnsU/iuSqXF2Q2SF ACxPvJmb10JL95yjE8eOQ2IdPKF6/PUNRxThxXtZIx07yBpQLI7HY6FuF0BUPCP8IMXL0mSoJWt Rt5i761J2mv22sDy1KKq36cRQ/VDYFzHEbMTDgmYpuirdmDcBFLFFQHE7Ni9LLTEJuktZ9Cw2BG UUHngLMIfCl30L3emDBNLhzU1hXdjLx1XM9V6nxH1DNuGUC2t1mHAxfupITziVHUFb0FGzj2GDc ryaER23HYn8ucP9 X-Received: by 2002:ac8:7dc6:0:b0:50d:7aa1:f405 with SMTP id d75a77b69052e-517785ada2amr113397751cf.9.1780583165966; Thu, 04 Jun 2026 07:26:05 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51790d965e8sm4420111cf.16.2026.06.04.07.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 07:26:05 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wV91J-00000008IF6-09MR; Thu, 04 Jun 2026 11:26:05 -0300 Date: Thu, 4 Jun 2026 11:26:05 -0300 From: Jason Gunthorpe To: Guanghui Feng Cc: adrian.larumbe@collabora.com, airlied@gmail.com, alex@shazbot.org, alikernel-developer@linux.alibaba.com, baolu.lu@linux.intel.com, boris.brezillon@collabora.com, dri-devel@lists.freedesktop.org, dwmw2@infradead.org, iommu@lists.linux.dev, joro@8bytes.org, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, oliver.yang@linux.alibaba.com, robh@kernel.org, robin.murphy@arm.com, shiyu.zsq@linux.alibaba.com, steven.price@arm.com, suravee.suthikulpanit@amd.com, tzimmermann@suse.de, wei.guo.simon@linux.alibaba.com, will@kernel.org, xlpang@linux.alibaba.com Subject: Re: [PATCH v3 24/32] iommufd: use iova_to_phys_length for efficient unmap Message-ID: <20260604142605.GY2487554@ziepe.ca> References: <20260602104637.1219810-1-guanghuifeng@linux.alibaba.com> <20260603151804.1963871-1-guanghuifeng@linux.alibaba.com> <20260603151804.1963871-25-guanghuifeng@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603151804.1963871-25-guanghuifeng@linux.alibaba.com> On Wed, Jun 03, 2026 at 11:17:56PM +0800, Guanghui Feng wrote: > Use iommu_iova_to_phys_length() to get PTE page size in > + for (i = 0; i < npages; i++) { > + if (!batch_add_pfn(batch, PHYS_PFN(phys) + i)) > + return; batch_add_pfn_num() Be mindful that the num is purposfully a u32 so that will need some attention. Jason