From: wangdich9700@163.com
To: tiwai@suse.com, perex@perex.cz, wangdicheng@kylinos.cn,
wangdich9700@163.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] ALSA: usb-audio: qcom: Use PAGE_ALIGN macro for buffer size calculation
Date: Fri, 5 Jun 2026 11:16:11 +0800 [thread overview]
Message-ID: <20260605031611.69550-1-wangdich9700@163.com> (raw)
From: wangdicheng <wangdicheng@kylinos.cn>
Use the kernel's PAGE_ALIGN() macro instead of open-coding the page
alignment calculation. This improves code readability and follows
kernel coding style.
The manual calculation:
mult = len / PAGE_SIZE;
remainder = len % PAGE_SIZE;
len = mult * PAGE_SIZE;
len += remainder ? PAGE_SIZE : 0;
is equivalent to:
len = PAGE_ALIGN(len);
Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
---
v1->v2:
Remove unused variables 'remainder' and 'mult' to fix W=1 build warnings
reported by kernel test robot.
sound/usb/qcom/qc_audio_offload.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index fa7ee61d6934..b2b719238b0b 100644
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c
@@ -1042,8 +1042,6 @@ static int uaudio_transfer_buffer_setup(struct snd_usb_substream *subs,
u32 len = xfer_buf_len;
bool dma_coherent;
dma_addr_t xfer_buf_dma_sysdev;
- u32 remainder;
- u32 mult;
int ret;
dma_coherent = dev_is_dma_coherent(subs->dev->bus->sysdev);
@@ -1052,10 +1050,7 @@ static int uaudio_transfer_buffer_setup(struct snd_usb_substream *subs,
if (!len)
len = PAGE_SIZE;
- mult = len / PAGE_SIZE;
- remainder = len % PAGE_SIZE;
- len = mult * PAGE_SIZE;
- len += remainder ? PAGE_SIZE : 0;
+ len = PAGE_ALIGN(len);
if (len > MAX_XFER_BUFF_LEN) {
dev_err(uaudio_qdev->data->dev,
--
2.25.1
next reply other threads:[~2026-06-05 3:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 3:16 wangdich9700 [this message]
2026-06-05 11:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605031611.69550-1-wangdich9700@163.com \
--to=wangdich9700@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®