From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Vojtěch Krátký" <vo.kratky@seznam.cz>,
linux-iio@vger.kernel.org, "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Lucas Stankus" <lucas.p.stankus@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/11] iio: accel: change from %ld to %pe for PTR_ERR() printing
Date: Fri, 5 Jun 2026 12:57:35 +0100 [thread overview]
Message-ID: <20260605125735.3cc193c1@jic23-huawei> (raw)
In-Reply-To: <CALoEA-zSroEAxiN1L81+JERksLC2Oba=u9ya6j4--gcwpn6m0w@mail.gmail.com>
On Thu, 4 Jun 2026 14:13:56 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Thu, 4 Jun 2026 at 14:11, Vojtěch Krátký <vo.kratky@seznam.cz> wrote:
> >
> > Replace numeric PTR_ERR() logging with the %pe format specifier
> > so that error values are printed in a more readable form.
> >
> > This change was identified using a Coccinelle semantic patch.
> >
> > No functional change intended.
> >
> > Signed-off-by: Vojtěch Krátký <vo.kratky@seznam.cz>
> > ---
>
> Thanks for the change, but in the future, please slow down! Let the current
> version sit for at least 24 hours before sending a new version so that
> everyone has an opportunity to review it.
>
Further to this, when doing a change across a bunch of drivers, send one or two
as a test first to see what feedback you get. You'd have gotten the reply from
Andy to such a patch without wasting as much of your time!
Jonathan
next prev parent reply other threads:[~2026-06-05 11:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260604120201.116925-1-vo.kratky@seznam.cz>
2026-06-04 11:59 ` Vojtěch Krátký
2026-06-04 12:13 ` Joshua Crofts
2026-06-05 11:57 ` Jonathan Cameron [this message]
2026-06-04 11:59 ` [PATCH v2 02/11] iio: adc: " Vojtěch Krátký
2026-06-13 8:06 ` Jernej Škrabec
2026-09-21 16:08 ` Chen-Yu Tsai
2026-09-22 0:23 ` Jonathan Cameron
2026-06-04 11:59 ` [PATCH v2 03/11] iio: chemical: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 04/11] iio: common: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 05/11] iio: dac: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 06/11] iio: gyro: " Vojtěch Krátký
2026-06-04 20:08 ` Andy Shevchenko
2026-06-04 11:59 ` [PATCH v2 07/11] iio: humidity: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 08/11] iio: imu: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 09/11] iio: light: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 10/11] iio: proximity: " Vojtěch Krátký
2026-06-04 11:59 ` [PATCH v2 11/11] iio: resolver: " Vojtěch Krátký
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605125735.3cc193c1@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=nuno.sa@analog.com \
--cc=puranjay@kernel.org \
--cc=vo.kratky@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®