From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D33A3254B8 for ; Fri, 5 Jun 2026 14:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780668658; cv=none; b=sY3g2z7DBlDQ3MdBkUnVBFB0PsszmUz1Ur0Z5r0ylKv/mTo3XKRUwXtUmwkdDqudgGGyWwGUYgO7HSmPamIL7L4a3Ey9ty9Tn0jUugqfwGGkBbssK2F6vcD7URGLPKcSafFr/4UER3dUeadmc53MaBIopyK52G/c3Nt0unh0VbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780668658; c=relaxed/simple; bh=W02qjvHYgDMmbpjNbp+lJoOTYJg9xT1q7z0bTk3ZHys=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IpTfJXJ0Sd5iUQkI0s6EDQKQCIGd36RctiDdyCdol5wxmjonlyp6XIbfiaO5qW3TQddjm+Xhr3PjddYG5/wcsBu8c7IdXwfnfGBtEYFsRs1b8Wj0cG4hbvybdf4tpo3ib4w/Wg62C3EVIhB4yKkiC/oGJMAfrCVycH0RhbGsvT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=WF2wUEBQ; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="WF2wUEBQ" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-5178a42caa3so17599461cf.1 for ; Fri, 05 Jun 2026 07:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1780668656; x=1781273456; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UR0H1P2VS3kaB3iZ1809TswMb1cbtGLR3JmcUIz3mWM=; b=WF2wUEBQzmDvMo+GebN6QYZLgOBnfJqLUDizbEqJ/iI8bPJwM6AZuZ1yrjIVSO+nXo 3Q1DkBi/SJIHRxE2r+tlDRPQlswtm0eu/viMWFDbkim9JBc5U2ttl0acG7qbDXSYxy13 U/nLkLIn1xm32vyM6q1va5lFf9hC90fw6ytpdPICXIpUozBim7IvszKjaNg/FJ/wa/lc auuw3hPDzpLvlqhQDihay5tBUn+ICp+uwWjZg6ow7ywYGeqabks/p6g4pSGt0a01bgFe b8kw5FBfT1Y/wlC3j/Oj9IcIv/KvnILwV+0eLQWP2JwqiTZ/6YUAuW3uoqBvo+DiWQuO 4EBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780668656; x=1781273456; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UR0H1P2VS3kaB3iZ1809TswMb1cbtGLR3JmcUIz3mWM=; b=RB07qUc9NMGbVGVvjXHWZhpc58iBRGN3oMdx71hrz+rAVA+HipdQsVTMwkIy3ck+he 9b2Tm8AUTY5IBD4xGwXVEt58UQYgqFwuZfKh5xCPuwsQR9AYGlK7VPVA7Wd2k9VoJgrL CLUuZI/GeJOXBzOOvb0FKWHO8yufDyHpqNK66l9Z5cmGERd4jOfxbAq2yi0plHW9EEob 51K0ix1tMpZEPF39cSy/a89TrqB8bi18hMaJHNfg6l5bI7GyE0FNZTSU3dohpZymoMeN HtAjViUsFMoR1GDXXVL/Oy8va+bbJD/mZsXZiM3jGFi7ylj/B6gGPCjaIOyMBdtM8QHD J1UQ== X-Forwarded-Encrypted: i=1; AFNElJ+GbiQsW5Ak6OADooW3dUxjw+E3JXpfeQtrx6cF2vTLoTIK3WWq8mE8+SLlSTGKZJvCGelRSC6T9uR+1b0=@vger.kernel.org X-Gm-Message-State: AOJu0YwpKG9IbY7pHWPMpjUQpTIKxeU/+OXJ1EEAwrbBjs22Phi5ZNo/ S0zVwMR1layCaeHFgWFxUeebBznBHd4JuUfSMAzHlgRzHwQ2hXM4drHpjMQmNkLqjrc= X-Gm-Gg: Acq92OFghR1kd4JbaQHCqkhZMT25pR3TNSO3pZb9pN90FY0gKD5+/IEWaxvozYgmp8T sO2a7FUVHvPXC+mrb55qP3equKcml+5vFBiaowEyMhT0Wmygx8sWyw3gQ8ACpwweQQ8YPqLzazF 0gYwpR3XqsVqLYefqm2tmTgiR+9olsD/OKefOQQloies7yfYMbiOn9qgePLVPemdidkpTGdswep Pmo7DSarfchL7C04+j75d+27QWhKRyoECkStMyL4FY+bKhcMydb1okHl+5n57L7/ZLpxvwxKgn9 akcnTPZhPWAjoy0fooLy8c9jrjSW8rhOICCLRdNCYbHm9c6hZhYGXPpaudZpiLxBX9AMIHgcr+L /1MfegCMlpCVjXPKl1k404IcH0fAhHKkZEyzAuBZxf7y7fYQE+Br1IBE3WEuokxXiHYntJAVVHj PbJagTufpW5DdRjKRRcBILCLZpdeCR0a6QsdqJmmI8dS/o6VY+C1DrLsxty4AvsnRAJK671jCqS 2tj3BPBfGQn7CWH X-Received: by 2002:a05:622a:244:b0:517:5f11:b353 with SMTP id d75a77b69052e-5179888c297mr31853621cf.41.1780668655956; Fri, 05 Jun 2026 07:10:55 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775e2e16dsm80797461cf.31.2026.06.05.07.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 07:10:54 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wVVG9-0000000BEgc-3cQ9; Fri, 05 Jun 2026 11:10:53 -0300 Date: Fri, 5 Jun 2026 11:10:53 -0300 From: Jason Gunthorpe To: Ashish Mhetre Cc: Will Deacon , robin.murphy@arm.com, joro@8bytes.org, nicolinc@nvidia.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v3 2/3] iommu/arm-smmu-v3: Detect Tegra264 erratum Message-ID: <20260605141053.GF2487554@ziepe.ca> References: <20260601104845.995005-1-amhetre@nvidia.com> <20260601104845.995005-3-amhetre@nvidia.com> <09a501ff-d1e8-4035-95c1-a6df9f0cb9d0@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09a501ff-d1e8-4035-95c1-a6df9f0cb9d0@nvidia.com> On Fri, Jun 05, 2026 at 07:35:35PM +0530, Ashish Mhetre wrote: > > > +{ > > > + if (!(smmu->options & ARM_SMMU_OPT_TLBI_TWICE)) > > > + return false; > > Maybe we should make this a static key? > > Okay. Shall I add just static key and remove option bit, or > have static key alongside existing option bit such that > static_branch_unlikely will precede the option bit check? You'd have the static key and the options. Keep it simple, enable the static key once if any driver probes to set TWICE. Check the key before options to get the best code gen But IDK if it is really worth it, there are already lots of branches on the performance tlbi flow, and we didn't do this for other tlbi affecting errata.. IDK if we really care about branches we should also be doing things like disabling the range/non-range paths and ATC based on what is actually in use.. Jason