From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7C63A9017 for ; Fri, 5 Jun 2026 18:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780684211; cv=none; b=cCuoeIZ6w/bwJhnn8QhtGRE8Djvysdcq/G7o1qzXVeedJdfLcCHYoAWNFQRizemf/ydUYKCJ82v1uIkuLPe72wK8QEawFlf+w7ZjrpgKr63CeZgFjjz1jRGIndkrxQlL4JAxjGTOlaf0V4zYJikxBZcoFPgulx05jj6GEJUmtEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780684211; c=relaxed/simple; bh=wcy0f2jBXzVCMI2Wm+TBszW9WYGbTiy+Tvaz4GauPjk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V6AInqxfiB6VwjE/LGNhBi2ZIWBd7zgyD3Pcx+bUyAFl8vCnKa3JU5XyqLkJXfkzrtvK1oxUTrm0yfmnHABQAXDYlq4ZAYTIilETEEkGl3TKQoGdGSqJxiKwzPbTNnNY5RjF1QqLaK1aYKChMFNSLo8+VtLl7BBwxaQ9gh3mkPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pVat2Z8/; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pVat2Z8/" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2bf22c18ad3so167125ad.0 for ; Fri, 05 Jun 2026 11:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780684208; x=1781289008; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9KnToTwjIOTIeerw1OtFveTTURV0LHhrMU47MZN/oSk=; b=pVat2Z8/cWqe2QjhIsQ78MNIm64/CNBEteK6EVoKNCKT5NS6EOrQ4mG0gxgJAI4fzc 6tc42nx342W10DrLWeePU0U02k7ttE9vELWNoyGPmVQa0O5JLLFq4WUOLJpVGpRG7rYF 2xijMDgTe/VsWt0s1iISY6Q+8YEaStSifTFRxCav2reiukGT3UUcVkrL0O5tNnObuIVK P6+HrwT0ij1vMgtLGiMRnTF6OcGOtpw6HbVFjdPmwWZSRDvIPjN+2Na/S7HHV8wVJ1sS oXm6MD0qKTNTqgThzY8wNwUcEZ1i5Bk83o9YzdtKniW3+id7XPezidpBF1w++6YAUCCW YC/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780684208; x=1781289008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KnToTwjIOTIeerw1OtFveTTURV0LHhrMU47MZN/oSk=; b=CZkyEyU+pwj+M4PVnrp4LiD5hzHPQ7oGCInYNXt7Aw22eshvnzzXUTJxLgEXeU4CTb l4NBOXPSqhZiqqrFRqiRKCJqQMkb8yoHFbxi7H+3mBsZilM3UG+2/2ZsMYNKJc8ufVAA MsKw+PVctqy/5OYSN3Jbj4sN44KTFFWfw1BA/umbWed+hWiALWEQ3g3jFf6M2pAsNN8L wkOie30hODXkTxSD/sy5LNIhCn9DH52loiowebWq2fDP+DaRUhIy9p+8Ok54n7Knxir8 tNYegyPn4L14chUk7h1yYfOyVC0sGcUM9vpclcIyUZji1T55MZXpouIxRLhRLgRH1InC TarA== X-Forwarded-Encrypted: i=1; AFNElJ9y3t6GWh4XvEwA8iYHcTIp564mGcEmQCvJt5WsCYh+H7+d6f03HzPklWx18NCeDLDThczvuImoz9aXVlc=@vger.kernel.org X-Gm-Message-State: AOJu0YwhpVy35fQqWS+FgLb4v1z5vbvuJIGtOkVvTvUyeAJA7tCwT+Sp suc+BuWcMxMfNbnaFw9K4tvPG6OsIHH2ZQ310fOsKhvfYKc6CuKNq47rRbpX+JJ38g== X-Gm-Gg: Acq92OFAV+VtTNILckLj0ui9oIg2rR9mIjFLATntzn2VFQdnpVJ/kEACUdKKi8bxHPW oiFUZmRxNo5to+pLIm85iUXj77FHH82qMas4PVBYvZeqAqTqafYrNkfwqChKCorMyeuqRBObehP mry0C/dzBiWoZ4wU7XA3MGiHXNx2+ViZrhk/ZAPlmEeQrmbOd3xAzu9US+0Dd5geY/RNPUyse83 tip5FBsZeGOk36GTRotEl9rm/Qm4YckGcFd3G9RhKvcsUNkO9SLWoLAM003OncvPwZj/iYMi2Ny PVJpCPXnkPDxSoZMWdMUxglpOjBAkFqE5SiDo0IqlT+YYJ1ENOcEzogWHyEc+MmN8t2Km5tQDhA A9VP+nfSR5276yIxxvMAEVDzyDepmxh5FMvd8MVcufKXGIQ2EpGXboG2UoSd8pgQwBKtGiEPNid WT5Py9bf7zwiyscesbT6J7nTib29uWuuyZRHrUkAKD9ZZs5bVDRU05FxgOm4pTvfafMPd+kJuJ5 gep0g== X-Received: by 2002:a17:902:da84:b0:2bf:193b:a195 with SMTP id d9443c01a7336-2c1eb1ded7emr2155935ad.11.1780684207442; Fri, 05 Jun 2026 11:30:07 -0700 (PDT) Received: from google.com (171.46.125.34.bc.googleusercontent.com. [34.125.46.171]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf827e6sm9411861a91.1.2026.06.05.11.30.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 11:30:06 -0700 (PDT) Date: Fri, 5 Jun 2026 18:30:02 +0000 From: Sami Tolvanen To: Michal Gorlas Cc: Jonathan Corbet , Shuah Khan , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Aaron Tomlin , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 2/2] module: restrict autoload to CAP_SYS_ADMIN if CONFIG_MODULE_RESTRICT_AUTOLOAD Message-ID: <20260605183002.GB2939956@google.com> References: <20260515-autoload_restrict-v1-0-40b7c03ddd04@9elements.com> <20260515-autoload_restrict-v1-2-40b7c03ddd04@9elements.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515-autoload_restrict-v1-2-40b7c03ddd04@9elements.com> On Fri, May 15, 2026 at 07:20:20PM +0200, Michal Gorlas wrote: > Restrict module auto-loading to CAP_SYS_ADMIN if > CONFIG_MODULE_RESTRICT_AUTOLOAD is enabled, cmdline parameter > modrestrict=true, or kernel.modrestrict=1 is set with sysctl. > > Signed-off-by: Michal Gorlas > --- > kernel/module/internal.h | 1 + > kernel/module/kmod.c | 5 +++++ > kernel/module/main.c | 11 +++++++++++ > 3 files changed, 17 insertions(+) > > diff --git a/kernel/module/internal.h b/kernel/module/internal.h > index 061161cc79d9..496d8703f0c6 100644 > --- a/kernel/module/internal.h > +++ b/kernel/module/internal.h > @@ -46,6 +46,7 @@ struct kernel_symbol { > > extern struct mutex module_mutex; > extern struct list_head modules; > +extern bool module_autoload_restrict; > > extern const struct module_attribute *const modinfo_attrs[]; > extern const size_t modinfo_attrs_count; > diff --git a/kernel/module/kmod.c b/kernel/module/kmod.c > index a25dccdf7aa7..58b28c23f571 100644 > --- a/kernel/module/kmod.c > +++ b/kernel/module/kmod.c > @@ -156,6 +156,11 @@ int __request_module(bool wait, const char *fmt, ...) > if (ret) > return ret; > > + if (module_autoload_restrict && !capable(CAP_SYS_ADMIN)) { > + pr_alert("denied attempt to auto-load module %s\n", module_name); Is pr_alert appropriate here or can this be a warning? Also, use the _ratelimited variant like the pre-existing warning in this function. Sami