From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A90A368D75 for ; Fri, 5 Jun 2026 18:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780684234; cv=none; b=nvJZx7bn00p0tr15BJ90QxE/PYbmeyfNQCrmRwrLZBFmOLaNO0Uq2WwiBb1hZ9cq7VVmAWHS05u6ep1K2wf0/4xTQdDiF2owM8t7E4rtuKitcPW294aFsl6BawGsuvobleVZEGtLDovO1vBrNXpYL1p0AtmcUNEzwmvwRUVjNTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780684234; c=relaxed/simple; bh=YD4uG8JUye2kgh4vy/FaaNSjVounnva2SXj2Lwnj6Pk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JnnYG3vf636k4l1+DSK/+fnEWc1F/p2gK9yomHEI/rsggksDztYEtCGz7TovkyahyDheDoq704usFzQ+1w2FS2pop5IdT38DKe8iFQBEsukVUjuUNRm51fT9ecXe0Vq0cz7D59AjKolH4XFgBBhEoD7AUAduC3bY3MuI0LR1Q5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com; spf=pass smtp.mailfrom=trailofbits.com; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b=NSWXIaoz; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b="NSWXIaoz" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8ccef25789fso14969816d6.3 for ; Fri, 05 Jun 2026 11:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trailofbits.com; s=google; t=1780684232; x=1781289032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9nJ7OqxyNNsnYmi+m/jnozjd/vkKqOFrIYBl0dV1aPw=; b=NSWXIaozEwlejdbHmNLdrCwf4xQlG493edr9S4wPeWbVUcs1gL0gep2fnfWPeJ7Gg4 N5vQAUpbfpIvdwabGIj2okLKcQhEKw5/OX2zwvZwYXgtOCe2ysAkthC+0LnA3Mm3nyRC 5mOUy0V0ehaawQIpCcDUbbAO67TZI+EPCOlPiFQJ7582P75csP0PlxXOsOeBkG6K7qWd zjDbkKp5bDQz4SpxO8MK3sXafwolWw133IDmA5dzhlnqFT0jkVL/cQb00RD0/NtaBt59 nY4kyDYoI7f8YTV1jWSXGJ7VvmUqU0BZ1/LXzBuv8LHlL1tFZWcJFAn00LhTrOAD2zdC urTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780684232; x=1781289032; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9nJ7OqxyNNsnYmi+m/jnozjd/vkKqOFrIYBl0dV1aPw=; b=Bnyu/f7U+Hx9QsfnNaDnTV8ab8SZt92Gbir46RWPCTXWVZ4kc3Igpp1LVf056a0m+a 0yCaOhk0ui6+nujLHssH1gjyruH9g0oOsXusLM6bIN6ikcHkhfoYxr9X5pSJuDZOZK8L 77RRXvEQjMNLsHs98RM0aKS+YsErZ3ppsKJS37TyFfRXFZp7u67MB+xV+zO4EyKvLKfh 9a8JFn5dRsxnRXafSPQ3OZkG/Cc8NaJncU8RZOmWEORk/MKGngiOXtMBZqqcyFQiEaJX eH6eHyYzQDK/aoGJguVFkejg369tu9Etf0o5M7U0C/v+7S76clq7KRokSBKYj6FqtmiF 53gg== X-Forwarded-Encrypted: i=1; AFNElJ+BZw8YBw8w4Ccv1XWTHKLPVf8e60KGxmM8sKC8CoJM/ar5SovSLkIqWamUd81MjdqVrMI842KwbuTf3pE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7ocnUo306JrAqnEdoIS5L+6IXG2RjEC7AwDgtGvOEIrGQ73c6 JCRSEDTrYzvc8RH7ctxCK+DvEVY+FCmRQIg0nikA9oQpywucA7fUrLPcQkYQMuFRGjG3J2ap/Qp 7xv2aGJg= X-Gm-Gg: Acq92OEAR80wg25xIsG0COX1pwBiPh2ngPH6yCPvcv59zpMNDsM2FfIy5tc8P6Gr/4d 1YteGibW4WboH6rOp/c3+9eqNZkMfjKsDGOaYu43N9XLFf7e9+5EoFwnfSIXc08+0HtV6tUEs2z mqt4hXaCaDUAtMxIbn+0IprT/hpY1Z+YRmufOyfEsdeuLh948lJTtj4H9Gq+IgIs6Epz/xpuAtP i+B25Dpt5P4p63f/A7bf3m6VwD1M8iP5FGn/N5xAyqZKjzG65Jm3L+dYw67osCUPi/gPdky9svz BSaCEdgphb32WmCV9T44XPai3aJr9arXikCqz0h0v1W/D7h5eZpVz57RcxXXBJP+uc5iQDmt92V lvkoM/paF7qjMOWrSfQojaLyJIJNheM4VDoySjZ9JYn7Aq8r0fHLRgZ/uvTEK1K+9JNF5MNM9iG 2kLlL9D54aEX1guv8EtVPU/ekD7lk9Nc6RVeDDag== X-Received: by 2002:a0c:fe8e:0:b0:8ca:1cee:7c38 with SMTP id 6a1803df08f44-8cee611fcc4mr72299176d6.24.1780684231889; Fri, 05 Jun 2026 11:30:31 -0700 (PDT) Received: from localhost ([161.35.96.86]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-8cecd055181sm88641946d6.30.2026.06.05.11.30.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 11:30:31 -0700 (PDT) From: Samuel Moelius To: Kees Cook Cc: Samuel Moelius , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] scftorture: reject zero worker threads Date: Fri, 5 Jun 2026 18:30:23 +0000 Message-ID: <20260605183028.2489493-1-sam.moelius@trailofbits.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit scftorture accepts nthreads=0. That value skips worker creation, but module initialization can still create the stats thread when stat_interval is positive. Cleanup then tests "nthreads && scf_stats_p" before stopping the stats task. With nthreads=0, cleanup jumps to the end and leaves the stats task running after rmmod has returned. Reject nthreads=0 before allocating state or creating helper threads. Negative values still retain the existing default-to-online-CPUs behavior. Assisted-by: Codex:gpt-5.5-cyber-preview Signed-off-by: Samuel Moelius --- kernel/scftorture.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 327c315f411c..b190d9ff5157 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -661,6 +661,11 @@ static int __init scf_torture_init(void) // Worker tasks invoking smp_call_function(). if (nthreads < 0) nthreads = num_online_cpus(); + if (nthreads == 0) { + SCFTORTOUT_ERRSTRING("nthreads must be positive"); + firsterr = -EINVAL; + goto unwind; + } scf_stats_p = kzalloc_objs(scf_stats_p[0], nthreads); if (!scf_stats_p) { SCFTORTOUT_ERRSTRING("out of memory"); -- 2.43.0