From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8733D8903 for ; Fri, 5 Jun 2026 22:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780696924; cv=none; b=hgPj4kc6H0a70h4mV+EyTGhJTOoG96rXB3GIJCYPipUvDY+I7Q0590q3LjVIgN5h9BBuiEeldZSNDBKicquuI5MuTLmnneuo9x2lAUkmieGTj+ZkBAsp3z1RZKHjHBr5OSmB9JyU9WkRYldDGIk/p5SQULl+2tBi/vVYfJlrICY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780696924; c=relaxed/simple; bh=M1tCipKgh6sdfzfNx6Ayc+P63xEC6ccKKNUWUXQ278s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bEcPES3QZJGIVCLCxKnPUuVt/VC1w/AFMZ9VigOjaunS8/aWy5UVD+EA7x1DhkZf8J0KpmQHyzHoKl3v9T6MMbIvQIb6t/npbvrd41M9bNBA/R8bJ1JWQADOs0gf6j8VG6/tiNQW8njXRnzK36QcF6OA6gAWJexOoPqPcWPSCK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=edIntREJ; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="edIntREJ" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c8584bbbf2cso1544084a12.3 for ; Fri, 05 Jun 2026 15:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780696922; x=1781301722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3h60AiEE0ezQWif9mmBIRZAGzyRJ5Mypr0bfFicKOUY=; b=edIntREJmYyeRyEcwZbPPQxFR8U4Cl2O8UEeJEDelDNx9uavBZSmtEYOA4je7RXvJk XFz0myFGxYPf4xrQxh/YiaJ4bKR3vAfZ9s3zgMBIvTDCjdWP7rvNadeSMlcIGYHUgOYb IrogpyBf8bPWnqeJ6yR6SMDe0V/ANnflsWWB7EDBriMWjH/MW7ZymeHFtAVP1oIUwJ3x e9rC/f+EcOCLixUyiRxVVnMa5BbfqnyIpijG0hK23J/izENA4mlEBnqFqizsBjtPSZzA 0L5ilVjUDwEZ5hU9asLToCWbdbTOFH0UUOkeJLWTm/sITa1vZSy4sba9OiORJwxbacgD TQ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780696922; x=1781301722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3h60AiEE0ezQWif9mmBIRZAGzyRJ5Mypr0bfFicKOUY=; b=Gjkq6JPu4K9kaFTaOKVVvPo0KmRhi/qreFFx3VdkVeRYB3UiM2Q2EUZ1RPDBHsa9Ht 14xiYDFpzPqJkrxvfHcYvCrId2kULRlUDmBzC7t/qIa5vXOmsJnZClS8xw3+E9kV9c7y MsEmG6klrPTOHnt5DcvPNrJAUmeSYj3H6hMq56ZSjR4jou/xj3+1Psf4gqlwHeQTfxdH 4s4eW9tTygBW+y4socjV6azrQOG/1/LhzXxtvMuPl+rHo9WW/Uhg/fgKgc6J8qwHVUNP cj8n8hOveUFM1KX4rvhD0RCi+pUnuJGm7v3s/dLrkoC4YL2+UXZA4UYtJL6ZyfCWx0ou f3OA== X-Forwarded-Encrypted: i=1; AFNElJ97HKCnI8pG5nEEl4SImRQqfxKBTODTxD4w48FVDn782Yc0Dh6W+tnGLdMYmGmR9lqsHMMeMBY5N4jYKM4=@vger.kernel.org X-Gm-Message-State: AOJu0YwkjVluVNuOm8PP6gZA1MQ2Phk24SKTiYeHjS4M7hTc0OYyAvcM ZZIOXtjhxIm86aAcX4LbJzIQdlOtoy6NnNT68yVChBR+nHQfn0q4HUWI X-Gm-Gg: Acq92OEKluQddp8Qq3LMLoGmD8ZZvoGHOlX/8Ia9qeUv6RFqu9Ra8AKIx8ys+C/C3dA CNwznYNn3a2rjlfsnH3jVMnyNoz7Loz0oB5MQvlmcLlLTce9tyEcW4xdrDAa60Y42K8QZ6n+zjA p7ibpvEAK9pKUu6TNQL/wkMg1ze0hiBhqDdnE4N121aEnIEr2e+VgYAqCKWvH702C1PnLLw8SbV Nwl7EWipdEGkbOE/TRchvVCXfh5h3uplZlvxGUduejO/1JakJi6CWdZVr1ThYwj21zNgYH2YDBh J9wuDkIFLNk97C+4yO44vMBCLzv3eY+goefHGRi9VCj+P1By/sYlGt6ZjzBuPY7TpCwrc+tBnaa VJ9lWRhUdS5OEZbXK2cmHIHasOOEu0uOI3kqtX0KA5dLeFJCJVVi+4DzvWZjYlQQVSjIELqglTT 7cL9jC3X5Zm3eOlBlZlst/sm2JudbhlWFP9TSznSO9cUEkJV/flBvypm3b4n5d4ps72bCsz1v+4 IUzpWXGuW+jOgv/pu4I9dtmFyPdyZoi5eRlrUuu3rEG4Q== X-Received: by 2002:a05:6a00:13a7:b0:842:48ae:1d6c with SMTP id d2e1a72fcca58-842b0f5477emr5790548b3a.24.1780696922232; Fri, 05 Jun 2026 15:02:02 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842824a1cb4sm12518883b3a.26.2026.06.05.15.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 15:02:01 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH 06/10] dmaengine: fsldma: convert channel allocation to devm_kzalloc Date: Fri, 5 Jun 2026 15:01:30 -0700 Message-ID: <20260605220134.43295-7-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260605220134.43295-1-rosenp@gmail.com> References: <20260605220134.43295-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert fsl_dma_chan_probe from kzalloc_obj to devm_kzalloc, tying the channel lifetime to the parent DMA device. This removes the need for kfree(chan) in both the probe error path and the remove function. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 2a6a247761a4..ee6e595c2972 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1111,11 +1111,9 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, int err; /* alloc channel */ - chan = kzalloc_obj(*chan); - if (!chan) { - err = -ENOMEM; - goto out_return; - } + chan = devm_kzalloc(fdev->dev, sizeof(*chan), GFP_KERNEL); + if (!chan) + return -ENOMEM; /* ioremap registers for use */ chan->regs = of_iomap(node, 0); @@ -1197,9 +1195,6 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, out_iounmap_regs: iounmap(chan->regs); -out_free_chan: - kfree(chan); -out_return: return err; } @@ -1208,7 +1203,6 @@ static void fsl_dma_chan_remove(struct fsldma_chan *chan) tasklet_kill(&chan->tasklet); list_del(&chan->common.device_node); iounmap(chan->regs); - kfree(chan); } static int fsldma_of_probe(struct platform_device *op) -- 2.54.0