From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F7C30C343 for ; Sat, 6 Jun 2026 04:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780721907; cv=none; b=HnfZo21OFygZnh3o8g80ImJ8bD3JOPt7qHL82z1V6o47UsjGCv2nLXIi7CgneSiQK9mHW6WTHefZ6cxnCm1TmLSQM8041gNo4agoMDW/UolKhc6XCVoesVtMjheph2UhqBc2Gpx4JE25KwCMrFg+oMIAmUDZH/+ycEIStBdY/Qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780721907; c=relaxed/simple; bh=O+IQDDaskjpiY9H7vh3SwWeHCbOSEhzjDI8laqLbRkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PEP0UT8N8b0VEZp3kSe3DqN2zXnrYOhYatFa1kScaHfXjz98bLX3r6Rv/FkdjG7VxTYlTa55oqz0pVIhHw6a7avOMXOEDEGRGINm+BUpSKNvwNnBqHHasozLyakxMBOdGNMMtQW4H0+iEEiSd3RZ6TETwMIuIFLyWC6seUJbseU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E49JGrj4; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E49JGrj4" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bebbc325000so310852566b.0 for ; Fri, 05 Jun 2026 21:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780721905; x=1781326705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yN9wV+nrusoIiZXpR2QbLHADEoHUVVuow5fDPzDOfKY=; b=E49JGrj4Nx+Ge9LGt1wMJ1FmPcIKiAT5nYDYu7F9BK3kHL0NhPX2bABzkD+KSEC8RB 93lXRNaJatpao2sKzCk5RD79L4Yl258IZmVVwamxpPPt+dO3kkIjHxXMsDhraXFC48IU rNgDAP+LGeSrph0vwpHhNvlyvoc1d296v+wCYoZmhV9RiREZo5Vh4LiHsdSIK6BliRJ6 WBjPVEojKkPX9vEejLxNAD8i5HDk8AhZfNpFWR1U70JBk0pImX1mjGOB1OOf5lMvIBoj veErV2Ym4lq8fJxmk3eCyJIJxIfREbGEF1nvE5p8j7PxYJw0u8utWfkudGYdkYdR1Q25 B9DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780721905; x=1781326705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yN9wV+nrusoIiZXpR2QbLHADEoHUVVuow5fDPzDOfKY=; b=s9ML7BQMoaTC69eSl/Bvv1I2nI1OLdpTzfWgXqe1dN9pG8C5G7KT0OZOuogUfURK+h glguivTGALy3JEHEJ6qt828K7d7XXlf/cGQ9r5g8dLiTFCr/5XTXZ4tYOTT2kFVCTSv4 Ff9BUamIL4DloLOXXHMTobx5ZEYHTD9NVQcvTSbd8UxsyAssTm5phhwIqWINv5SU0W2m JYpYwwoJm4p43bk5LkIljQ8hQjGOi8oFEWHDXeN8Fqw4KdUjQHDa+OvseJa4WEsCaqP1 ti+VvsMMmUVHBdsxrvdCAbcXP2UXEVUD1QrEMrB0tDvBOPFphsB0fYW8Rn/fe+FgQG2L Z/hw== X-Forwarded-Encrypted: i=1; AFNElJ9po0oVot/sIdWhZqibZ4J6olMX/wxSMYOmZrMIsBRuiLCGz4LelBCS9ISIirjNC8kwoq0Stlbyv9L6M0Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+LsSRyLs6oDjj7Z2cxdZUztzr/4PUTlu6PEqK0D8g02WL7Z9a QcFoVsmaI3J+HOX7/LW9UHdjnE5+9VkjU1SbgKnI3BZZj05hV9SMBeGa X-Gm-Gg: Acq92OHsJnN4VALUmQbLDhQSgru9C4YfLaOxriGV6cAT01u2248Y12bY2SxJkm0OU/b uLdL4og7C1tAWiylPE4zXFF450FY+J2NpWctAtepw9pQ7RMElMe0jdMsWCsoJ+dVlqOWgX5esFy VPz+xzACZh+K8c8MpnyRjY2FV7Nn2w2abeV1+wmBI8HrDzNv38NvfkCLoxjKeK8pkB9sKiEDiPz VwSutqToGaSjMlqtUMXUij/ayWo7jchqfXGfNmkn8kiH6yuGxj5ubqDtXtCZZ4l9rfIHZvzV9jF XxCPFUVUSh7ir/pxfE4H+2CIafr744qDqTje8mm+SyWAxhm80fEmhydZEvgyZyon+mwCcDR/dHq f6fqrMp3D1+HMa3VHUvUUz0NHhAqjNTGIyAh+nYw8BpNGgkK/C9O/1A3/Fo18c6nK3FVz1juPhG GqLtdizNAn8JDjcFHtfz8HgoM= X-Received: by 2002:a17:906:f58d:b0:bed:5d12:db5d with SMTP id a640c23a62f3a-bf37135e498mr329022266b.4.1780721904690; Fri, 05 Jun 2026 21:58:24 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf054e086fesm570597166b.32.2026.06.05.21.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 21:58:24 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v4 07/14] mfd: lm3533: Switch sysfs_create_group() to device_add_group() Date: Sat, 6 Jun 2026 07:57:31 +0300 Message-ID: <20260606045738.21050-8-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260606045738.21050-1-clamor95@gmail.com> References: <20260606045738.21050-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch from sysfs_create_group() to device_add_group() including device managed where appropriate. Signed-off-by: Svyatoslav Ryhel --- drivers/mfd/lm3533-core.c | 4 ++-- drivers/video/backlight/lm3533_bl.c | 19 ++++++------------- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index 45e7f7481aa0..e3efc9f6f348 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -416,7 +416,7 @@ static int lm3533_device_init(struct lm3533 *lm3533) lm3533_device_bl_init(lm3533); lm3533_device_led_init(lm3533); - ret = sysfs_create_group(&lm3533->dev->kobj, &lm3533_attribute_group); + ret = device_add_group(lm3533->dev, &lm3533_attribute_group); if (ret < 0) { dev_err(lm3533->dev, "failed to create sysfs attributes\n"); goto err_unregister; @@ -436,7 +436,7 @@ static void lm3533_device_exit(struct lm3533 *lm3533) { dev_dbg(lm3533->dev, "%s\n", __func__); - sysfs_remove_group(&lm3533->dev->kobj, &lm3533_attribute_group); + device_remove_group(lm3533->dev, &lm3533_attribute_group); mfd_remove_devices(lm3533->dev); lm3533_disable(lm3533); diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 39f438114c48..b4363a30b2c8 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -304,28 +304,22 @@ static int lm3533_bl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bl); - ret = sysfs_create_group(&bd->dev.kobj, &lm3533_bl_attribute_group); - if (ret < 0) { - dev_err(&pdev->dev, "failed to create sysfs attributes\n"); - return ret; - } + ret = devm_device_add_group(&bd->dev, &lm3533_bl_attribute_group); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "failed to create sysfs attributes\n"); backlight_update_status(bd); ret = lm3533_bl_setup(bl, pdata); if (ret) - goto err_sysfs_remove; + return ret; ret = lm3533_ctrlbank_enable(&bl->cb); if (ret) - goto err_sysfs_remove; + return ret; return 0; - -err_sysfs_remove: - sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); - - return ret; } static void lm3533_bl_remove(struct platform_device *pdev) @@ -339,7 +333,6 @@ static void lm3533_bl_remove(struct platform_device *pdev) bd->props.brightness = 0; lm3533_ctrlbank_disable(&bl->cb); - sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); } #ifdef CONFIG_PM_SLEEP -- 2.53.0