From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1809229AAFD for ; Sun, 7 Jun 2026 02:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800980; cv=none; b=f0Jjk2IHo/KScqH3baxDJ3bS2AfDxz1BQJD59CezckEU3cywA3spxkOjrwQs6Dn2ZDmbYv8xVUKbou+0nMLSrvkWDAGfvcHVoOR031b4OurYIry41I+616+dgnyy7cGHWkEd9QOrCTnh8+sKOhb1u41ZlwgVeTt1BZVqwNInTOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800980; c=relaxed/simple; bh=j4h4tXYG+ti60tT+xtBRPeiqIWq/51ySO9A1rO+6VfY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kU+jjacj19skg1iqaNJf5bQflAFss3OW9nXoZuXHr6x1u1YR+hNG0mhWdKr+9HeUmeVmUefQv3WsLl0KEEsCX+AJOoM4MIFuT24u5hliZri2uWbMR9QGRVInueer2McO7tNxXyLnj2UNAo0jrHmlkSCjDJDO/7vl76DeIqxpr4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CO72Abvv; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CO72Abvv" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84275887a3fso2665903b3a.1 for ; Sat, 06 Jun 2026 19:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800978; x=1781405778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tKG8K6ZfgHZwdRHzwdJFm5PX+/nn9D4GakA15V/0O0o=; b=CO72AbvvjqAutkqOWveB3Ug6giDPPMWCFwjmNAXTS3rTokEOvCbotuIw2LASWP2p+P DvLmBISQrWOpq9qdcXrKwecriih3104X18iCdIlbfjodtNknoiy9HRWzv83HhuRYdxuT s+GmqcdsCdxttErPR1e4qq0QFuy2+c/z+DbmCbou9/jjh+qqpwDmgiTP7LjD2cy1oC5A mxoKYHmwdxJTyYMW7cu8s2t1itkIWAk134t6EVd+VHPUrAameQd3t5cD0uQWJ2YupxfY 3ho2HWAqJaNTIs4APCjwh6H6aHBj6opkMsE16QnNGfc3he+21ceynmN1TBlaqwkA3HoT hNxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800978; x=1781405778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tKG8K6ZfgHZwdRHzwdJFm5PX+/nn9D4GakA15V/0O0o=; b=pUWjntd/AyOcF+3lGdgKQL7HgRAvKQ/VzTlaXvsIfSxgOIUwdSBaj8LBD43t/dGpQl ccGhI7S1QEmdLeZ50sJ6+tdes0Oq7z+BUBPoO+NWWYZORIkRq4jhUm8nSwodqcohbST5 o53Tp0X46po1lWH9BrifjZcSKTtX8NDwEIqeyRD3AVwNJi+pAKAxlcgrrrkjZXT0UDxw jrc9ZrLuUJM8fKadaJRlZ1chMo/hfa5AuGQPxIkAht+iDE76eiWr478UjwflblgDbLjB YtnyRF/MfFAFPRKt4VVJNhbMLNv090l1JRFtfIMsUU9td5dvv2HWiBJgsdpy5xbHcIXt BDyw== X-Forwarded-Encrypted: i=1; AFNElJ+qmCA0HP1LjDotuejhcDqdDi9NukCXsbqljUjiWhlSrFSSoCkyjp+dFc2CgA83qb87h4eDkRgMoKPY4ZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzACm5afb419eAmLEbLmgc+Bim2wYDm00U8P+yJJirP5Q/G4ZnJ z6ds61yhOhvTSkImtgqRI20U+SnoJh0sf0gPQ07kENW7f1rX1gqRyJzJ X-Gm-Gg: Acq92OFeuh3wPLTzbtjYc4ZHWgwCG1MQW2npOLnIfltLuCMIOof7glk3DHQG92tATXm 5tFJuAJF0hNjio4HEhhul4/X6hUEqMNi+WrBh7W/sAg3+qnolmEONotFGNsEuXwSGeYbf6efvdQ plV+F/oSHkrgUcxdisRgeHuqOf9QOK2XvM+AxEmfIUsoF4lNufuRNf3LwK77iClW3E9iFtcUiyl QAeEeNi1E1fWZcUQ/hgQzeikdMRbeld6Y7FwuWua3w/y4Td1DUqXp4/nhdtaWMw8sI1aGea+V3W 0YUp+dR6bcOHgCR871aTk9LOSt9e635SqtC4jvPA5WZadZEDRyaF1FJAEwc2Hxf0IU4ofWWMh3F c/LVTbOSmEXnniIZL6U5jfjw/SxLHAoIKFPOqYL6efpD6+6T8+3EQfQLrLJFa2e+gA86S7FgEjL mpq3Ji8iFcCzCNxrXfRHUPKyjVEK9wqL4U2uLPIUA8kyE2w/qSDQm7Rw== X-Received: by 2002:a05:6a00:a201:b0:842:6293:fc43 with SMTP id d2e1a72fcca58-842b66aa645mr6923455b3a.15.1780800978217; Sat, 06 Jun 2026 19:56:18 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:17 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing Date: Sun, 7 Jun 2026 10:56:05 +0800 Message-ID: <20260607025613.3604194-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Several ALSA drivers dereference the pointer returned by snd_ctl_new1() to adjust id.device, id.index, or store bookkeeping pointers before calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation failure, making these writes a NULL pointer dereference. This series adds NULL checks to all affected call sites found by static analysis. Ruoyu Wang (8): ALSA: es18xx: check control allocation before private data setup ALSA: gus: check PCM volume control allocation ALSA: cmipci: check S/PDIF control allocations ALSA: es1938: check control allocation before private data setup ALSA: ice1712: aureon: check CS8415 control allocation ALSA: ice1712: check pro S/PDIF control allocations ALSA: ice1724: check S/PDIF control allocations ALSA: ymfpci: check S/PDIF control allocations sound/isa/es18xx.c | 4 ++++ sound/isa/gus/gus_pcm.c | 2 ++ sound/pci/cmipci.c | 6 ++++++ sound/pci/es1938.c | 2 ++ sound/pci/ice1712/aureon.c | 2 ++ sound/pci/ice1712/ice1712.c | 8 ++++++++ sound/pci/ice1712/ice1724.c | 6 ++++++ sound/pci/ymfpci/ymfpci_main.c | 6 ++++++ 8 files changed, 36 insertions(+) -- 2.34.1