From: Ruoyu Wang <ruoyuw560@gmail.com>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Ruoyu Wang <ruoyuw560@gmail.com>
Subject: [PATCH] ALSA: es1938: check control allocation before private data setup
Date: Sun, 7 Jun 2026 10:56:09 +0800 [thread overview]
Message-ID: <20260607025613.3604194-5-ruoyuw560@gmail.com> (raw)
In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com>
snd_es1938_mixer() creates mixer controls with snd_ctl_new1() and then
stores hardware-volume pointers and private_free hooks in the returned
controls before calling snd_ctl_add(). snd_ctl_new1() can return NULL on
allocation failure, so these setup writes can dereference NULL.
Check the allocation result before using the control pointer.
Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
---
sound/pci/es1938.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c
index 280125eff3624..b6dcb721fffce 100644
--- a/sound/pci/es1938.c
+++ b/sound/pci/es1938.c
@@ -1655,6 +1655,8 @@ static int snd_es1938_mixer(struct es1938 *chip)
for (idx = 0; idx < ARRAY_SIZE(snd_es1938_controls); idx++) {
struct snd_kcontrol *kctl;
kctl = snd_ctl_new1(&snd_es1938_controls[idx], chip);
+ if (!kctl)
+ return -ENOMEM;
switch (idx) {
case 0:
chip->master_volume = kctl;
--
2.34.1
next prev parent reply other threads:[~2026-06-07 2:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 2:56 [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: es18xx: check control allocation before private data setup Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: gus: check PCM volume control allocation Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: cmipci: check S/PDIF control allocations Ruoyu Wang
2026-06-07 2:56 ` Ruoyu Wang [this message]
2026-06-07 2:56 ` [PATCH] ALSA: ice1712: aureon: check CS8415 control allocation Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ice1712: check pro S/PDIF control allocations Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ice1724: check " Ruoyu Wang
2026-06-07 2:56 ` [PATCH] ALSA: ymfpci: " Ruoyu Wang
2026-06-07 7:27 ` [PATCH 0/8] ALSA: check snd_ctl_new1() return before dereferencing Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260607025613.3604194-5-ruoyuw560@gmail.com \
--to=ruoyuw560@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®