From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9749D374E60 for ; Sun, 7 Jun 2026 08:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780822323; cv=none; b=fVx9f3tK9HpbaugPUtsdR8w7b2PUnhdqL0yAp3Sf3WZd8VQzZF1bgkYJxloPNxb+m1MYUwVJ/mMJuyUwFjpHXwmUvYiU3nNrrLghzWoprF2vpNsanxuiA6ViIGGlypIlOY1zf01MsjPE0WqmseIy5eGimlhkSfUwpTysv09SABQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780822323; c=relaxed/simple; bh=yZ2GguxlK4Drxdf98CXs/sIfvx5cN1fpDUIlYKB7jkI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=glmgzGAJEM91P4eqrm5M4bJcoHj9Ere8sgRBR2S7ZGOgbcxGf5pbbjoDVZaSqVbeHMufSgFzvXrnmzpm6+UincahFN/aN63Ba44hoCtZGizzlAfQG3Xt/Stf2kqdX1RNl1jQgrfOPvZIKrpDJw6risnMSPhRP360uFoliErBDM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLhrBk0l; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLhrBk0l" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2bf18c30bb2so22368715ad.0 for ; Sun, 07 Jun 2026 01:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780822319; x=1781427119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4++l0toGNACfhr7BSQDzAeyeBlGSABMgjc/G9H6+5Yg=; b=OLhrBk0ljtaXqDZFBXjtPLeiMLvFubWvx+a06SygiChTitpR0PnMQfWzsmgy72xOeA k3FZwh0xlNzmth96XdLe/7A1X2nOYRpKoifJ54jDimMVIf6NI78DQoXum95ulrZQ5Fmv /DSB9z096SYGjwzcvlnef6PpGw0L+ngVQeT5z57De2tWvs+tviPDmqDvS/fRi8hgBV3T +KQA6YAJTalhAWjLTyQe0BZF38/NEzI7kxyEElFny5Bp04nUGm5XA3tm8Yyg017HWgst 319vmgdEqUVpO2gokjiTMha1z9C9xpXlWMQC9R1//ejV1BY6cIlMOLTlhiRqM0aJ1zLP JyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780822319; x=1781427119; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4++l0toGNACfhr7BSQDzAeyeBlGSABMgjc/G9H6+5Yg=; b=ooE8JuDPiH/fmcIjYzuu5OKUk3WVd94IcM7n544jvdpbonK7870e4sGQIf/iTg2nG+ k9x6Q/3kvdwZVs4QUmgJ7Wa6nCM4P7jMuz5oZwcCEq1vsYU0tJbO2dUSZ82VPjdN4nxr Z3dpT3AayZ+rT4thX1ZvWdzYkSPDLHNzSt23dGFLpyvyICt9tjf6bziNX8z0T6ohcoHb Y2WwdYUM1njoyiuadbJ7gZJtuI4qUa0n4Pg68jIHVvA2yIIspGpJNt/cWuIJfWmbmJA4 8nmM2Oc9Vo5dW6sE4K87mn1i5+1nEqdlq7lVIw3+BzUDtQZbIdyfPOJZ2R4yFWquuTIL Djew== X-Forwarded-Encrypted: i=1; AFNElJ/rD3m9Vd+zToNGZbcl7AtKSB1rju6GeLtg/nZHFW98oUhb/I3uRTHc5+6zG+JoaBzcyvIv3joE59M0kBw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf/lVXIljzX1LLULW/BqlNT6zRzSVjBER6e5ohxQYhykn3DIgi TuMNEUrNZe23X1fexCuN9S2IpH5iqp5QYO+VPESbaqcbESn0SJ7wwfze X-Gm-Gg: Acq92OFpa/GnejeWzOaTkUXkIWziD5tn+XOEjHTSq/2JhyAGty516cq7SEIu4PDxJo0 xqXgK87BGoFCORj+d1xPxtzidPAIOIPRfq4SWRjhG6I74wn9dAfwF0dgpYrH03nv06D/qfZJ/Sw 61G3irCNLmeJC0OZdr/GDBrKSmAKB213O1zQ1AVbna6KLPgGnoj9pf6UOXIN6lpAeKi3kl4zYRh nSnAZt1qqfGlebBJbTJoI2CypHWshzbRyQQ1K1ZM3irhPfLQrCs2UTt0+h09lsLr1OcxqIuJm+b G2u0xBzSFgj+65v9m4TOSx0ar8aXTJZdLHpRBgFQRqOWe8n5k4i+Kymm77CHcYW570whsYbuuvu 5n6QImFoezYZ9e3C9E3MQEnVuyT7mXSPXi2DOi3jbmp473kBKuJ3Aw6q2SaYUcFFgb445lwfCBX KDwnt5snre5IHNLH/NhC39b8RR84uHgqrgJllmMO8OK0eHplRhDiV9X854ThhTKQ== X-Received: by 2002:a17:903:fa7:b0:2c0:dd75:e824 with SMTP id d9443c01a7336-2c1e80f98cfmr118746105ad.4.1780822319417; Sun, 07 Jun 2026 01:51:59 -0700 (PDT) Received: from kfuzz ([202.120.234.33]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d395sm197220335ad.17.2026.06.07.01.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 01:51:58 -0700 (PDT) From: Yiming Qian To: Jason Gunthorpe , Kevin Tian Cc: Joerg Roedel , Will Deacon , Robin Murphy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, keenanat2000@gmail.com, yimingqian591@gmail.com, stable@vger.kernel.org Subject: Date: Sun, 7 Jun 2026 08:51:21 +0000 Message-ID: <20260607085145.71402-1-yimingqian591@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit >From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Yiming Qian To: Jason Gunthorpe Cc: Kevin Tian , iommu@lists.linux.dev, stable@vger.kernel.org Date: Sun, 7 Jun 2026 07:40:00 +0000 Subject: [PATCH] iommu/iommufd: Require write access for writable MAP_FILE mappings IOMMU_IOAS_MAP_FILE pins folios from a shmem/tmpfs or hugetlb file and uses them as the backing storage for an IOAS mapping. When userspace sets IOMMU_IOAS_MAP_WRITEABLE, the resulting IOMMU PTEs allow DMA writes to the file-backed folios. The file path currently records the IOMMU mapping as writable, but it does not require the source file descriptor to have write permission. It also bypasses the address_space writable-mapping accounting used by memfd sealing. As a result, an O_RDONLY fd for a root-owned mode 0444 shmem file can be mapped as DMA-writeable and a device, or the IOMMUFD selftest access path, can write into the file page cache. The same missing accounting also means writable IOMMU mappings are not excluded by F_SEAL_WRITE or F_SEAL_FUTURE_WRITE. Treat writable MAP_FILE mappings like shared writable mappings: require an FMODE_WRITE fd, call mapping_map_writable() when creating the backing file-pages object, and hold that accounting until the iopt_pages object is released. This rejects already sealed files and prevents new write seals from being installed while the IOMMU write mapping exists. Cc: stable@vger.kernel.org Reported-by: Yiming Qian Reported-by: Keenan Dong Signed-off-by: Yiming Qian Signed-off-by: Keenan Dong --- drivers/iommu/iommufd/io_pagetable.h | 1 + drivers/iommu/iommufd/pages.c | 18 +++++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/iommufd/io_pagetable.h b/drivers/iommu/iommufd/io_pagetable.h index 27e3e311d395b..63e3fd738faf2 100644 --- a/drivers/iommu/iommufd/io_pagetable.h +++ b/drivers/iommu/iommufd/io_pagetable.h @@ -234,6 +234,7 @@ struct iopt_pages { struct { /* IOPT_ADDRESS_FILE */ struct file *file; unsigned long start; + bool mapping_writable; }; /* IOPT_ADDRESS_DMABUF */ struct iopt_pages_dmabuf dmabuf; diff --git a/drivers/iommu/iommufd/pages.c b/drivers/iommu/iommufd/pages.c index 9bdb2945afe1e..f97d94d9eddd1 100644 --- a/drivers/iommu/iommufd/pages.c +++ b/drivers/iommu/iommufd/pages.c @@ -1421,13 +1421,27 @@ struct iopt_pages *iopt_alloc_file_pages(struct file *file, { struct iopt_pages *pages; + int rc; + + if (writable) { + if (!(file->f_mode & FMODE_WRITE)) + return ERR_PTR(-EPERM); + + rc = mapping_map_writable(file->f_mapping); + if (rc) + return ERR_PTR(rc); + } pages = iopt_alloc_pages(start_byte, length, writable); - if (IS_ERR(pages)) + if (IS_ERR(pages)) { + if (writable) + mapping_unmap_writable(file->f_mapping); return pages; + } pages->file = get_file(file); pages->start = start - start_byte; pages->type = IOPT_ADDRESS_FILE; + pages->mapping_writable = writable; return pages; } @@ -1668,6 +1682,8 @@ void iopt_release_pages(struct kref *kref) dma_buf_put(dmabuf); WARN_ON(!list_empty(&pages->dmabuf.tracker)); } else if (pages->type == IOPT_ADDRESS_FILE) { + if (pages->mapping_writable) + mapping_unmap_writable(pages->file->f_mapping); fput(pages->file); } kfree(pages);