From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9856E3AA1B6 for ; Sun, 7 Jun 2026 14:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780840926; cv=none; b=HZKgsgNj1YKXRsTK1R8/y9ilp1AJeMBlnSSfakVbWI8t2S42fTPcxkXqRK4j6MZgUIzF9rMVkJyigfxO/DNcbLtw6JgZsSbiscbQBbi3rGa/Q4OPiOSjDaAY8V2abxTnwrYAkoUiiQC69MfnlWq+eaX04cpSYWoqe6rMqiL+Ees= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780840926; c=relaxed/simple; bh=VqvTRUA6o6ZYdITB2RrmuudL8aq2Fm1Upzn0MV4FZ5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pg4lA7CaoUFYBZdmADURnSgo+HQtnROO5HpzyOIDWD2/L9E9YAIEkPhv/m4R9brQuh5gW1GcrYA9Sjl5lzfOg5rhvL9CJm8Ex086bqHR0qMuyabjFC2WO2am2QOMjo1w36xrTH1Gz3q5CiJAXWUetqXI9z7DX/Y3GzFRaWMBCAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KJWJxoAH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f3KyVPzs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KJWJxoAH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f3KyVPzs" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 657B1Tat376750 for ; Sun, 7 Jun 2026 14:02:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=j3HLvpgf/bq VTB+xJ2J7kEnCnU4hICG3RGlKEepjgjI=; b=KJWJxoAHca53dDOvFXI310X+033 oG2lTbc7kt/UZAMw6a+NaCADZ/xx60N0yCtNlZxrjgdLcGBKjGoKfwv3Iw2esjr2 MzfbRDL30HzgE9+J/XgHO6fwpks5X+VRfCkHCAXadSZ+gKCZL29RnBa9ZcE1rN6B 036QEUNbv1DI+TG7emRGBajPF0wB7hvQVAPcP3+s1slwkkxKecDXQhwwVlC35e11 WxCwm7ODMgRBHsOsApyLY1eE5TtsFkbofeQu4qMKILKcV7MGzG4r+EJSfuyJ8guV Ojmn7xV9n9FrefTGTC31QmczRDh+keB7ky3C4m+Qb5Cnc6pf7/z7kAMxnwQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embx6bwag-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 07 Jun 2026 14:02:04 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36bbcd40642so2471300a91.0 for ; Sun, 07 Jun 2026 07:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780840924; x=1781445724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j3HLvpgf/bqVTB+xJ2J7kEnCnU4hICG3RGlKEepjgjI=; b=f3KyVPzsJPWsyEetJSM/vbVdZ8jyEQAPApC/5AiCGWVafFqff22/6rDS57Aa59FJn8 HJrPFAzWN9D3gz4qAutecRrR+8R1Up3FSvn31K4lRLmlmB91Oo8k+yQlmEWVKSjJIrTb /WILLQiuuCT7ZAbs2xtVsZZNW8tlBwTn1F8NsAFelM4xf24DeO+VUK11fK5mR5fkd2/0 rPv40DGMAfpUykTzsAOAFlTIwpPMwTcSuE7or6U/ds3e9yMJcttxl5F8Wtf9YBsWnueW iuTSH1p7Y9OpAMqxVKXR2QuR4BL5a3lZkI9dQFFsjVrhGsDIhaAH10MrkLnwBH8tknkg XV2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780840924; x=1781445724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j3HLvpgf/bqVTB+xJ2J7kEnCnU4hICG3RGlKEepjgjI=; b=VsqY4I89psf3FGpQYzJZpwyO3Z3lgwUScJK+1+F+rCWYpAqdIYy50huK9DnIJb/JzA yJvU6w37Z2X+gzk0353ApNbjOd4paJxmXgbvNTa6E8YS16Adajm6+d4tsdmva4ImO6g9 OGQsPTUq2QVH7VqRbpAhzILoz3QKbYwM5FpjUh727YTqoB/FUiUPgCxtKh39Iywcas0I TZ4FBxaApDgx6sUx4IOX16ooIzLIAku2mXm2dKAdtOvqDoGNfYbNICtvd77ZmXpcUklE SWnFSaDviJfgeD9lwNBQWjR3ZkAhCWKJunkjGkgqDbimk9aXpMuqdyy2S1xpThFQCr5K mogQ== X-Forwarded-Encrypted: i=1; AFNElJ+2Zsz3yxmGRssJF8z1gJaYu/WF8wSCmH8wiSqDdtJsgXdlLepR4xOifRUpz0pdCJX7Dp9vKD69MHZ5vOI=@vger.kernel.org X-Gm-Message-State: AOJu0YwmnqAo+w315b1kbGutL8qxOJO3vFkbwGDrKIp2CJA7faSuUIuG ppGoIoKoPZAFPVEehhvrvx6F7Hce8xMPyVp48JvlyWpMrRLcirO/UPuWBMrO6/fU7hfagQEWkIM 0XDtA595aZL6VcfrFNX7bHKOxHmdKrUU3Fghu/i6lN24WTr9LmDMNXL/J9XvtmF3afXM= X-Gm-Gg: Acq92OFveDDWCX2Po4OtbaZUC3DF+eDrymZGqP9VG6X2FstcGVM86bd2bykAanEo1nz y6ApN/l76fzVfCzstGHgbGD3Fj/UBn8Iaq7RibXdbeXt43kPvd/uT1V13bUoGfYkowmDV6r0KM2 qcyznq9TpC9hAaT/0lUX3DPkhXHRLoxRbtWa1ZUcUTUTf7Yfsv2tmHNK5Gwg2zD4Ct6034dc71W VvbyrhJVh6MZBuO8YhV4MY/qxM9tGwiVEdatKVgvHlKWvGCm4cP++8hFcZnx0rtNaa8wRTmT9/Y seQcfMBBPNCFJTZEl9CzHaPU4f14LYOa7sPDSYclDAdez1Z0wJbQL1snqjH1M5Fwv2R1E4FjqyK LD542SF5petINi23tuw/8RO0A4DNMIoyfLcMlnLQ9O3U= X-Received: by 2002:a17:90b:4b0f:b0:366:decb:d119 with SMTP id 98e67ed59e1d1-370ef0f5942mr12763328a91.11.1780840923554; Sun, 07 Jun 2026 07:02:03 -0700 (PDT) X-Received: by 2002:a17:90b:4b0f:b0:366:decb:d119 with SMTP id 98e67ed59e1d1-370ef0f5942mr12763277a91.11.1780840923085; Sun, 07 Jun 2026 07:02:03 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6c668e98sm13168827a91.5.2026.06.07.07.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 07:02:02 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] drm/msm: Validate lazy VM is created in GEM_SUBMIT Date: Sun, 7 Jun 2026 07:01:57 -0700 Message-ID: <20260607140159.137068-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607140159.137068-1-robin.clark@oss.qualcomm.com> References: <20260607140159.137068-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=cvmrVV4i c=1 sm=1 tr=0 ts=6a2579dc cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=eWlSUfSnBrBg5eVjM6UA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA3MDEzOSBTYWx0ZWRfX0fLnDq9MPh+U Lh6u2D89M/NxAo3vPSWs7QEfSanfS5qXloOxE1CMIyQn6V5K1zEkL4tXE8coNk+1lL8y2JvO83N m+fO440SXTMcwz2I5p5RRoXZzPieojuupu9F+C9HUgUA0g72yUnZWEanKUsh2Sigo1CBaBr2U4N h7rtXwk33/sLtVxxm/GogLNZkDQkY7n+iYh8ojrl1bOjlzVdlXDR5zCYOLk3pJG93Aq+IcB8A67 uVuJYumWplAChLqfW4TGYyoR+BJfIkXdYVUitmapcnr9CzK5OfdhGIYsnpcNgJiOHWzBjFmgeLY IwrTLyzk62xTLewYL+bBk8+3NdEOcpDPxMOwgGNp7L5Ml6eLKUx41w1YNV8kO0xPvFEMCk6sMGP TEPWMcmU4GPy+gFTk7E+imgalB2Ieoa8KUcjnTiOrHvzsZKpD2CDemswrNhplyl+Llm3RLT3X6I BC0wsttvncoA5CuhLNw== X-Proofpoint-GUID: mWboHX47LVSgjN3a62RvFa4Yfv6w-wol X-Proofpoint-ORIG-GUID: mWboHX47LVSgjN3a62RvFa4Yfv6w-wol X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-07_03,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606070139 Otherwise a GEM_SUBMIT ioctl before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: 6a4d287a1ae6 ("drm/msm: Mark VM as unusable on GPU hangs") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 26ea8a28be47..af564acf1f0d 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -572,7 +572,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, if (args->pad) return -EINVAL; - if (to_msm_vm(ctx->vm)->unusable) + if (ctx->vm && to_msm_vm(ctx->vm)->unusable) return UERR(EPIPE, dev, "context is unusable"); /* for now, we just have 3d pipe.. eventually this would need to -- 2.54.0