From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 472D83A7582 for ; Sun, 7 Jun 2026 14:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780840928; cv=none; b=ioDAGr6Gn+hTBHkhHQOfX2i+7rtw3oTqRcrwIN7FghXlM4gem3zP61K7pLTaTADd49GVM5xfgt4vN5WnJIEljw2LrbshifkABwX8k2ZzjbOxRpB0jmwnrzsNOfP299ZfyNVU4WmQQJdiffrEVOpBlHjdBGiHmq0i+5AIbtQuIzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780840928; c=relaxed/simple; bh=uW+35qOnb2ZYnJq/hxZd+udgEcBycKJF6VpnI+PQTuM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ngGv+Vd74xIkukai98/PqNusQ6IHw1kjt+EjX+Uww3ApFCndpvSCr5NR0W+fVBwlMPTKS6CRiIOMhYqGvMDfav4dTYgPv358iyXjiBDPbQCFEtXMSA7/5wdKAUhjG836K7uAJkZ77QwYM1Ebvpi8rJQGyLPSbzYPlO5iXyJ1CZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ICccRE2a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AP496Qgi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ICccRE2a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AP496Qgi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 657B22Nt378005 for ; Sun, 7 Jun 2026 14:02:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=p0pKjfrSRwq eE20la+/GnMQ/TJmUHYzFGb/Fleo0bCo=; b=ICccRE2afsq13iYk7SpzXgkxyab Wc7O+zlgXAPnECXY/CeCpKhXB4GQGsz6ng3Apaw1uGLu0j97u+ydsIrHnsJz8GJb zJFGl3Z6BBr6icV8Y8MBuWvWw9sXE71vlUYJhe0Q9KV9dd/HXzM0jq6smDZPdK79 8FsWiImePGYiGK25ttSXdMpLxaJMXYkDwnCkvnAcG7EYh1aeRIAIz3nULtPJ6XEr SR13/xwdTSuqv0o6HAal4UuSE7PDq7Ttir7lcfiCUmxWsLw+jGjWvfhId/0UOVc4 G17CiCFikTWW5rCrmMtot7D3Ejpv7ya2dRHBm58PCX3JBsEnsFTsP6daDOg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embx6bwam-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 07 Jun 2026 14:02:05 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36ba98cc003so2315327a91.1 for ; Sun, 07 Jun 2026 07:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780840925; x=1781445725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p0pKjfrSRwqeE20la+/GnMQ/TJmUHYzFGb/Fleo0bCo=; b=AP496Qgi0rbsZV2QKZtAMB8U1JYBKFHW2s/KrjlUZuHqMcnOICRhXHH0fkbpj1s5oZ ZfHJaMa+Exw2Av6s5kIU/bWgVnR4L8XhZHQVNLfsoLHhOGYHUYBMFo34Kai5jZPuiDVr 1Yq167FJFbKOD0Zmw8bG70Db+VY9NtOl7Y+1dHedUZXKTHV5BWysaURxgYzfudYb1nfc W0rmEgDqELIBjR+A3p1zUCPQr/gFaDJmqI25cYli1NkgqgEfk9hQ+WZplDvWvFY8Awvx ItVwEZmJbuKzYm/FZFYZykcaOJyWmI/9eErWBPHYbVzGmnPbLMLE1CkpYK1OZXwww++Z w6OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780840925; x=1781445725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p0pKjfrSRwqeE20la+/GnMQ/TJmUHYzFGb/Fleo0bCo=; b=UxwKe9mXK43RgOWq7z7sEzWNrf/htvGc/+mJ4M2GW+nZXlDP7LPMM93HTjerOKnN2/ ccR07XI1e4a0NF70Z9l3mqyTIkuM7Dh3hGeQZbalpc+N6NcLSUlT/WuS2qikdrzBahLW Au6hP03CPBadgeKoKu08Z/nWLLC5aurxdupW7RKn62zPbCHm4TWPGWyox2i44tzTOJuJ 3iJZ1iH26r47lCzCvRlY8VLcWZIRq2Rbw7ADmvN6HRalHEYMxlFM05m6wJUYzzz1O3me ZWQQOo8K6MiVvXDifitMwR4GhDAaWM21f0I1fg6dVZeiQssWyJtdM7bI0TdcoGFlOS0P IbYA== X-Forwarded-Encrypted: i=1; AFNElJ/3Mqet72BgDTc5Amzw/C8+O8WEJBWmYI/ZuqFTMXbXLgFxHBvLOcRan8d4+cpW3m7513Ynmx1tGc4VxO0=@vger.kernel.org X-Gm-Message-State: AOJu0YyAqKK62FVjlt7U3rIO5Gz2AJaQTnpsZ9GGtEdK3XkNHBWVzlMh uhyIFwHNpYtlsYNdLfq1pNzs34PRexrLv3L9xk6NknRwqmuzL1Sy9sRnxvcgzHGcLdhphE7sa8l Ib7/HgeR3A1skl/QrgnBkFHBXVlIgYSGaN3qnShArQ5t7mCjc5U3Abl/iMCDkHrhbsZg= X-Gm-Gg: Acq92OGU9NezkdpSApPqUVML+biQWow9f/rIfi4dRzZe9S8NLYnAC/mdvjPsA9jO72b TKSpuc1JJ6ox8FM2M5ScdgoGKxsAry5PLrMowDXBfSymwLR0r+4dklcSjX4ugGNkjVCH4tRmkGm IeMhuvtApTfrTQffIxVC0vXsoKmrYRwSqxOhZGh3evU0xCZ8IuRYKI1cBsgK5lIT3PUi3D9++3l xJ/Xk4nJ6I3CPFXJLxT55kn1A+Z3LYNnUn0ts+WK3JKyVb/RtSieIBj6HowlkotYOuvoq8KC3xe EbSdXHBEvyTKfzDMv1cBNvxxeAJ7xpbBU4/EsK17J8+4hCsQhEubgzkf6G2KNu3u77dEeMU1yTF O2OI5NWYpGAZhv/jGkwBXMr9tERM1RFcT/+0RC+uFX/w= X-Received: by 2002:a17:90a:dfcd:b0:36d:b12f:6143 with SMTP id 98e67ed59e1d1-370f1b09906mr15074533a91.25.1780840924832; Sun, 07 Jun 2026 07:02:04 -0700 (PDT) X-Received: by 2002:a17:90a:dfcd:b0:36d:b12f:6143 with SMTP id 98e67ed59e1d1-370f1b09906mr15074474a91.25.1780840924385; Sun, 07 Jun 2026 07:02:04 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6dba8064sm12794126a91.12.2026.06.07.07.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 07:02:03 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] drm/msm: Validate lazy VM in GEM_NEW Date: Sun, 7 Jun 2026 07:01:58 -0700 Message-ID: <20260607140159.137068-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607140159.137068-1-robin.clark@oss.qualcomm.com> References: <20260607140159.137068-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=cvmrVV4i c=1 sm=1 tr=0 ts=6a2579dd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=VGCgC6sU4evaG-_1UnEA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA3MDEzOSBTYWx0ZWRfX1irnqlnhfvEr yeTFYi9tB71/A9M9wX2wexSuu1sfZrRiWG88GLkFv7bwFQ4H8xLAvcA4+sMmwMs7NtJRkIKjuGE 8TDRisE9Y7Mo0FCl8jWjAuK11gp6F7uXeCOPZwGLTjnimw9XhAv4/9byc7bLAiivJnW6aGjVEsV wqrLJrZHB3gDdfN2CJuai1dOTmypNjE2HGZIaOGKTaG+9WSpZNJrh/nD8r45BOutVo60SoVhjY0 YAhVnaWT+ANgFhUnwtlMNYBCOvWMgqOTybiF16EumME8nwiekYg9eUGkYZS53/ile4YWFOZkdHD t7Z/Px0xEKm7G0IVM1o5ftEqItBvRGB8hDa3E5bxmI/b9eSOAg4KqBhB8l2S9Yzlzlwjtn9JsP/ APDAfnUr5z0SwQullPXBDLLIPoTPmLbbiQufHESoQV7hr5w36QXJulh5AAuHAHwcKRfkjvfjeUe 9k3FdGcSg3N1j3dA5OQ== X-Proofpoint-GUID: 2xk-iK93Y0CSgNuO6sAu4CLPuONw-vva X-Proofpoint-ORIG-GUID: 2xk-iK93Y0CSgNuO6sAu4CLPuONw-vva X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-07_03,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606070139 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: b58e12a66e47 ("drm/msm: Add _NO_SHARE flag") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 2cb3ab04f125..ef14ee66c6c3 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1148,7 +1148,8 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, if (flags & MSM_BO_NO_SHARE) { struct msm_context *ctx = file->driver_priv; - struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(ctx->vm); + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(vm); drm_gem_object_get(r_obj); -- 2.54.0