From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E51F72D29C7 for ; Sun, 7 Jun 2026 15:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845636; cv=none; b=DEThRy+fxYZ6pTGya+Hpl7vxzc8MMnf9DtMGnhcNIwc/MGfrWY957jPJoWbl1w480AZX1Nebjcgn2sx8SW9G9Gowi4uxTI2JfJgkZcOy38S+Ts4lW7/Dn//uw+ngqqAvZi5cYlAwISzEvwCwx4gE6pDzMqoHCMTlhYlXAuvvK/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845636; c=relaxed/simple; bh=e/H4yzSTRx9v1FO/nY2xDM9IAIIvMAnlcw/dCWJpsew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kc4k3VCRULSj9as46G7LIXPl7k/BeIbnS3pOMboKrVbGz4g+m6j9zjVYPcyii7iC37Q2cuH+MNznulpIa9s723P89tl2Jd1F5lMMB8NP0iKKBByUgocNpeS35OjWczsYGL+nz3CRUE4sTazJU9LTaMGMFMuRUUwqQhF4/uhSEmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V9m3Kaak; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V9m3Kaak" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-36ba706ab46so2323377a91.1 for ; Sun, 07 Jun 2026 08:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845634; x=1781450434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r66DUruGKk6cGeKPaPeTjn7wW8sOwdyE3f6CXLHUbkU=; b=V9m3KaakBwuzCXKKTDhwblaFRzmkYYUm2AZ+bRBLeDlbduzVukpD9J9Ci2kk5yDj/I zZi7SQn98dWiBuFFeeXOIB4ZrigXUA7ljuzlA+5BgUdOd46TzNRMHNkIWvZ/+D6q0Ryl Zb3CVE5PCFk1EvmZPI5Xhxx14S4vA0IS37M0BIb0JBQPJSq9oM8qPnBvsq0JzcL+MRc5 DT79dSZPYVteBav44R33tOBM+JL+4DDfiYtZkzs+4g/VCZwdQb6aJa8WUJIyBBoQHyP2 PmhJTeHpdOMNCqlRFMZcUXCpEaMthbHElJErPWuMxSn2voSZAVQ4UXEU/UnzzhvxyKFB xXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845634; x=1781450434; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r66DUruGKk6cGeKPaPeTjn7wW8sOwdyE3f6CXLHUbkU=; b=S/P1dxSWsO5mnQh60fIHL2tsTJTtLEhOc1hX9XwfGMbfZKPt0Jl7kVvl3C1VQzJa0N tgj4hcztWaEJvBfqt5S+1Rd0u1ja/coxrr+3eIGJ07U1+CvMYFsVFrpgx2Ez7TxK5/nr NFJddceY/1/N00ENv6yMvBs2EQx9kCAg4YQf8pi9NbPYq2bpVp1xqgT9Ntr7c+xIW4J4 PjNvaRMCXpvwkexJS/k/LAtwVPRrewgQmegaZn+UbfjBCNFGdjAiusvxobSkNfob77qv VB6qm/uF6U1iq/yeEUPSnzBjtihSNUEh9U7ZwaqwsID3eAVmCjLU26Bo8Cb8+wn+IHFe AqlQ== X-Gm-Message-State: AOJu0YzOGzeIE/Xl6HEqxedBA8pqtaDQ/O2UHW0lrEFFNZ11hEwTnbQV WaL+Nj8jegrc3hI5GuKdAB/MUFLoTPsTsH3KjyAmtywZcBc2Wjh63B2BQmc7cV4Nm5Q= X-Gm-Gg: Acq92OHx/0aJdupO/ViC6woFU6xweiNApa1O4uHwg2DB6WhnURW8d395Lt8iFpzuKaY OLXauMak/7YVd903ADK6kcr9fpNV68zkQg6Fx8pyYdCcNEW2h+aezadMvCLkPtTqe7X22vxqITz F57ZMOxLJcwIS6MYJsi4uPu1XF9DUgJ+2m1Or2vW7kIde81OgkScx05zv4sXXo1zqAPRR8myqvX UsyF5KtdDruIRR6NphHjcfcQHKTDDZpxdNF8na+UL/z+BDOudQ7vCqAOLGLbn6lkTe6xtaF/Snp uhB5LcxLbDRetN6+X0C131LxAAwrvdDZDGKcpQzpUjfAmC9Qw3y7fb6UuGEeWzgwW2MPackyrOi MNZDHkDs4lAPWyLkZRZo0S4RUc3b6VkOR8fBkBlhBSVcYpxlE3xRePLHqm1vqwq0IAV6HmV7UMO LV3SxbFmQgmZlEMhFKJgExds7y/PuMuda7o23aE0hdwsDLNJRRQQ== X-Received: by 2002:a17:90b:390e:b0:368:a297:bd3d with SMTP id 98e67ed59e1d1-370ee82f93cmr12620623a91.3.1780845634053; Sun, 07 Jun 2026 08:20:34 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:33 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 4/6] leds: is31fl32xx: Add powerdown pin for hardware shutdown mode Date: Sun, 7 Jun 2026 23:20:00 +0800 Message-ID: <20260607152002.446617-5-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Deassert/assert the pin accordingly during probe() and remove() to manage hardware shutdown mode. Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 6c8d6b833260..b34fcef2c173 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -10,6 +10,7 @@ */ #include +#include #include #include #include @@ -60,6 +61,7 @@ struct is31fl32xx_led_data { struct is31fl32xx_priv { const struct is31fl32xx_chipdef *cdef; struct i2c_client *client; + struct gpio_desc *powerdown_gpio; unsigned int num_leds; struct is31fl32xx_led_data leds[]; }; @@ -421,6 +423,15 @@ static int is31fl32xx_parse_dt(struct device *dev, const struct is31fl32xx_chipdef *cdef = priv->cdef; int ret = 0; + /* + * Driving this GPIO line low takes the chip out of shutdown, + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tree). + */ + priv->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_LOW); + if (IS_ERR(priv->powerdown_gpio)) + return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), + "Failed to get 'powerdown' GPIO\n"); + if ((cdef->output_frequency_setting_reg != IS31FL32XX_REG_NONE) && of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { @@ -609,6 +620,9 @@ static void is31fl32xx_remove(struct i2c_client *client) if (ret) dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", ERR_PTR(ret)); + + if (priv->powerdown_gpio) + gpiod_set_value_cansleep(priv->powerdown_gpio, 1); } /* -- 2.54.0