From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDF629E0F6 for ; Sun, 7 Jun 2026 17:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780853285; cv=none; b=VD3w02sHjWXF6fVIP6hs8ga9dezGcXZP0DOpgiaVmmm9cL2evKhgrbDCn3gGHQ4VChpRCKO5BBf0TnKNFIfk8tYv0uL4fInwkgWXpUHUBBV5iNWkxaWsxUWa7iqnqdTkQFdDJLLANruOMGCX1T53Phh9DMH/dcHPXGjIwuoUuSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780853285; c=relaxed/simple; bh=ic6hP979jFIIR7VQQF0KZoJHeJIBAqqaK9TWJnCHRMM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NJQjm8h7EZZoPOAGa5VPuoN5wE6rnKsy9/c+vO3hQ0wAvIVBRHV/pikYgb1ty+B0grmJev3pTbfIDPOwbLHk5HaQ97RvthVtrQJ3Za+nUefjozXcFRf+Bz1jEhe683Ewuzif+7fVxd5iJLNGlcyS5Yjo9yrQpMP/AfJsXKAMKXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mv05PcBc; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mv05PcBc" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-45ef6565cfdso1574036f8f.0 for ; Sun, 07 Jun 2026 10:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780853283; x=1781458083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HQ6CUffrQyUVa2bFDEYUSmaOzuwIqiY1ShS08nol4bw=; b=mv05PcBcO839OX+cFxQwI7vdS6BzYT022iendhDWeI337R4UQfXVjasIzQBxizUjQ5 3owgeCi+bxlMvRhImKa3Erzc+zGlw0e15HBFDbaOWXfdusJdQt4DkpznAXbgCBFBJ867 ZrHnDyJ03Q7Hs4CLJkx9pkqSqYumTJX1BWspZYBGqv8IwPlwF0cY1+pmXPmzqQ3moAis lueQD3Tv69f6qPk/Rbu4PJi9V7jj6OvEwip5SwG9htQZfvXJBUkOjiklZaoSRyDIplV2 1+YMjmwadJbeHe3JjsteBh4473jFUeKR5sw6MXrCwM0GihY/z7sKnGmqc0a1BAonssxW HLIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780853283; x=1781458083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HQ6CUffrQyUVa2bFDEYUSmaOzuwIqiY1ShS08nol4bw=; b=AkI8U0NGmgaBRla3BXL973Xhh8Xj0d4RvgItcbv3FAMIx5tkWc5Wxj79XLGoQ5+Rf3 SyWcfCExFyhK2QK6L7inkRaGHk/VssJf8x9xKQLIlWUDLptXXu0LS3hMeIz7ZDxFbjtE 51v5VL+awE+PoEbc0GvcFJz62dyeGmukaHJ6bSJRRKf3xyn154QuhlUNUtYi2NWCjMLT 9aegjElgfJ9WA9vaSQThme6KYxRuhmx7HVlKu/jjlvTVM2fnP4g516W42NBZgB7hzQoG BaferxhA4UUTbS3itVBQzuE9gWM+diy5gTiz1NoyCkVBlt7tzk8xMcS54NvQTHKJF3JV mNNg== X-Forwarded-Encrypted: i=1; AFNElJ/CxzWB+HvuOJ3SlTFtoSyvQ06wCKb+OU0Be3Q74+aCV4Kd3l4daC3TocsVJTILATA2bCyfPQINWyTnkAk=@vger.kernel.org X-Gm-Message-State: AOJu0YwV4FY/xK0cj+RRP1Lm+JmXcOfUVOXhfmkD/kJNDdKxjM3+8A7w ndOXIhX0U8TpXlA2aIsyO+5I6ITE6V4xdYioLzvUXy0YnHhcttzC6e9e X-Gm-Gg: Acq92OH+z6MssK4acSzAxHyvYx7SrGpw0zlQ/fltUqgjjsF47tlmyLLKrRwtsxHQ+OV BEG7katWRiCa86gspUdKvca3fu7sBBtd9dpzunAzWc+VryZLrvqmyz8vz1VD48c2s/DIawgM0/r hNEGgkzkFNoJUapASo5IFzRXb5MXwYVicv/6kKJB15f4shDOLIR5oZjmquRX2AT6c0fnSj9oPlb ZDRODF7NWzJBFIguoCRiZi9Dcuu7s9ETVnWzkxWIPmmga6SivKmALq/XRwQb/IedbyMId8QzNlm iq1ypPypOtvVyfbKBjyXeRqlHue3yCyBz6W6U0LuiE5ODb961z2F3/0BmNA3zEyAGA07Z+H8TSd AJrXzkPMBgOFNpw2dybxVuBVv4LKtouzpRQTqdlmSV0W4WUJOG5ISIZKFh4A5iD+g68CjWDzEBl 7C1ezf+IzMpMcGhdf1pstIx2Ishvl2ckF4y0VkliKPG3Ao3sEgPG6TMoEhKF1rkOMqQmkFLtg= X-Received: by 2002:adf:fe01:0:b0:43d:775b:c9bd with SMTP id ffacd0b85a97d-460304fadf5mr14085622f8f.10.1780853282718; Sun, 07 Jun 2026 10:28:02 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f344558sm43703184f8f.18.2026.06.07.10.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 10:28:02 -0700 (PDT) Date: Sun, 7 Jun 2026 18:28:01 +0100 From: David Laight To: Hungyu Lin Cc: jagathjog1996@gmail.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: imu: bmi323: use min_t() for watermark limit Message-ID: <20260607182801.2624d7fc@pumpkin> In-Reply-To: <20260607132200.56495-1-dennylin0707@gmail.com> References: <20260607132200.56495-1-dennylin0707@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 7 Jun 2026 13:22:00 +0000 Hungyu Lin wrote: > Use min_t(u32, ...) instead of min() with an explicit cast to > match the argument types and address a checkpatch.pl warning. > > No functional change intended. Right - provided when you read the code you find the definition of 'val' and check that it isn't 64bit. min_t(u32, x, y) is just min((u32)x, (u32)y) so using it adds another cast. I really don't see why that was ever a good idea... > > Signed-off-by: Hungyu Lin > --- > drivers/iio/imu/bmi323/bmi323_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c > index f3d499423399..38ad05f9ef58 100644 > --- a/drivers/iio/imu/bmi323/bmi323_core.c > +++ b/drivers/iio/imu/bmi323/bmi323_core.c > @@ -1128,7 +1128,7 @@ static int bmi323_set_watermark(struct iio_dev *indio_dev, unsigned int val) > { > struct bmi323_data *data = iio_priv(indio_dev); > > - val = min(val, (u32)BMI323_FIFO_FULL_IN_FRAMES); > + val = min_t(u32, val, BMI323_FIFO_FULL_IN_FRAMES); Ignore checkpatch :-) Or just remove the original (u32) cast. I really must rewrite the checkpatch 'stuff' about min_t(). -- David > > guard(mutex)(&data->mutex); > data->watermark = val;