From: Nathan Chancellor <nathan@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] MIPS: lib: Remove '.hidden' for local symbols
Date: Mon, 08 Jun 2026 20:36:25 -0700 [thread overview]
Message-ID: <20260608-mips-fix-binutils-visibility-warning-v1-1-3c809cfb5a9d@kernel.org> (raw)
After a recent change in binutils that warns when local symbols have
non-default visibility [1], there are a couple instances when building
arch/mips:
Assembler messages:
{standard input}: Warning: local symbol `__memset' has non-default visibility
Assembler messages:
{standard input}: Warning: local symbol `__memcpy' has non-default visibility
Remove the '.hidden' directives for these symbols to clear up the
warnings, as they are pointless with a local symbol, which is by
definition hidden. This results in no changes to these symbols in nm's
output when assembled with various copies of binutils.
Closes: https://lore.kernel.org/20260509122517.GA1108596@ax162/
Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=c4150acbda1b3ce0602f79cbb7700b39e577be7e [1]
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
arch/mips/lib/memcpy.S | 2 --
arch/mips/lib/memset.S | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/mips/lib/memcpy.S b/arch/mips/lib/memcpy.S
index a4b4e805ff13..84f85aba6f4b 100644
--- a/arch/mips/lib/memcpy.S
+++ b/arch/mips/lib/memcpy.S
@@ -274,7 +274,6 @@
/* initialize __memcpy if this the first time we execute this macro */
.ifnotdef __memcpy
.set __memcpy, 1
- .hidden __memcpy /* make sure it does not leak */
.endif
/*
@@ -538,7 +537,6 @@
.if __memcpy == 1
END(memcpy)
.set __memcpy, 0
- .hidden __memcpy
.endif
.Ll_exc_copy\@:
diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S
index 79405c32cc85..ab087406da66 100644
--- a/arch/mips/lib/memset.S
+++ b/arch/mips/lib/memset.S
@@ -89,7 +89,6 @@
/* Initialize __memset if this is the first time we call this macro */
.ifnotdef __memset
.set __memset, 1
- .hidden __memset /* Make sure it does not leak */
.endif
sltiu t0, a2, STORSIZE /* very small region? */
@@ -231,7 +230,6 @@
.if __memset == 1
END(memset)
.set __memset, 0
- .hidden __memset
.endif
#ifdef CONFIG_CPU_NO_LOAD_STORE_LR
---
base-commit: 6d96cc123ce33cd74e799c5434440393ed022bb7
change-id: 20260608-mips-fix-binutils-visibility-warning-71e531e65f78
Best regards,
--
Cheers,
Nathan
next reply other threads:[~2026-06-09 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 3:36 Nathan Chancellor [this message]
2026-06-15 10:27 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608-mips-fix-binutils-visibility-warning-v1-1-3c809cfb5a9d@kernel.org \
--to=nathan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®