From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 217283D3480 for ; Mon, 8 Jun 2026 14:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780928896; cv=none; b=QIZuMQgbGZDMlEQEHdI9Bm+Dp7dXZTvJwx5lkwuld+EL0sM0ERCSyA5J/CdRwKtXpDORoVAjJTycu+BBaz2aa8I2B0k2t9VodSEBoeJCQLKuhaW6/vJYtt6Z9EGRFqvr5GuZ28kIxl1a9XSv80PZ8NJ6pm1xNBSCyYnyXgmvqoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780928896; c=relaxed/simple; bh=LvrQuMufMa2jstaWqw8VwauAYnxPiY07NBjKrPJoU1M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bCyJvBz8PN8gY6BW88kcBvOUH5hEwqk5tiKEm52vuRCnxD/8/zP3ahlKRCesninDCq1Fp3GQcnJOr3AKNu+9SlePRCU8nwZCRRp0nChPKdxxdJKivn95g4q/qNg0F7DxTnKKIUKzl4ueXXRSK9HmmXvIDpN5IxPokknxO/XZLwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kv+vlgp5; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kv+vlgp5" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4905529b933so47641415e9.0 for ; Mon, 08 Jun 2026 07:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780928893; x=1781533693; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Sp2ANuSp/GV260EEmEmdmugr8RRzCxVHzflIi+KBBt8=; b=Kv+vlgp5kdi2qYGCLYtSOBFY7632hpK3jtwqPAW3rjVhdTSXjkuwPcPfoc2xse+V+9 cW76o1Lh7v/JipbCyAsL66ONeZJHBhFeCZljO35Gr/gEZxpKVK6jMCu5+LTx4OSeMuOj gx0YUwWfh6mD3MegG5aiiUIeYb9ioS4YNNvzIWwEc6NN4pCgkSRYF9eA98I7irQoxo+/ vsOxcU37bAgn95imuybUkTQPx3CcSdZOL4XzewbY72e14h14I1r26VhyhFvyanZSmWOk tTN+j82/iNVdVXsjhLbUrltH1Izwl/aJ0i6iJHMAF3SMYQwH6dGQvfb32ayIKhM6CW4/ OU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780928893; x=1781533693; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Sp2ANuSp/GV260EEmEmdmugr8RRzCxVHzflIi+KBBt8=; b=lGJ7qtilPvi7QBl/6MpAoEoqsQM6WQFqxDT0GNDY+Lkemz92LmJ7m0PPRyi+6txm+m o2Oh1DUrSe4bPDbJR9Dmjo7IMk3kDWKAmNsGEXscNr2jtlcpDX5ILx1QqYc51N2YNuik fsyUbGVw11xSIJJ+ZF9kFf3CWKw+7ry4jXVZtr1++gDjayxr5s8uzRgnkAaj2PemQKof bNeRraNoGAw9F/qKSJ/uc0ooA/KM5LdJB/a2szybX/4s3iN0tqobelKS9FYt8x34UHm9 g/P4Ox80ONraVLgqpKawav7zZCygOesv3QC7JRTas3fTdiLWkUNfI7nZDvjSFBqvD097 oWlA== X-Forwarded-Encrypted: i=1; AFNElJ/FOX1KJtUcbWlr5b1hvwNQAQy/Zhew0hKqYD8utxOxHjLoWYQz6dibVgEPpTo8l1jnx/zgijiz3WYQKkw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4IL5n1OmkxhN7FQOop8ioHbGkhJ3HmdqmoAxD/RhbohFTYoQh YQQbj8Jqx3iQyzhdujyNhvIXCVhyfpFzzxpR2xO0RBdVWNcZlfgXPZG0 X-Gm-Gg: Acq92OGiWvMYvLiSQAoO4sxKzNkQZ4s4DkASkb/pKSFKjI1xa+xyIqtud6QtIGdhPYn bfcN3iveMzIHWFYki/TyCayA1YrzBCDtGd7ZgexhjLB5MeMymFduJ7VDXOvT4dR425zXAQmktVh xjpJDViGqebh7fWQBdpWZ9xPvYgc9V/GNGalj91jlzpknCMuZw9aHwteJco7jC/E1Tio+gTQRiL 6yYYEIbxZbxSsnJUXp2T9OwWWuaFegpcInMocY5yUsXJYHzZ/14fpJNgAnYwVCT5fqdadbwkd45 lTL+XXoSeYsgJjpQlgOcCKpd45igvFFAmf5TpWEnqbiXCFTSHdk0zI5FNyW0Te96l1WrxOb31a0 kmxGBGmNzcp+QRnpOgCW+TPZi/xaXY64IATjJ9i0yrC7Y/pGcvu3w7+QmfiadQcftLMLgzkKes8 G1nhN1NYHeU18BrPArF7YWXvYskSALqaK9 X-Received: by 2002:a05:600c:34cb:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-490c25b09a2mr267979525e9.16.1780928893422; Mon, 08 Jun 2026 07:28:13 -0700 (PDT) Received: from localhost ([94.53.77.213]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cbfe4sm407415735e9.7.2026.06.08.07.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 07:28:13 -0700 (PDT) From: Catalin Iacob Date: Mon, 08 Jun 2026 17:29:16 +0300 Subject: [PATCH v4 1/5] scsi: core: Remove export for scsi_device_from_queue() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260608-remove-pktcdvd-references-v4-1-72f88b04cc87@gmail.com> References: <20260608-remove-pktcdvd-references-v4-0-72f88b04cc87@gmail.com> In-Reply-To: <20260608-remove-pktcdvd-references-v4-0-72f88b04cc87@gmail.com> To: Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, Catalin Iacob X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2345; i=iacobcatalin@gmail.com; h=from:subject:message-id; bh=LvrQuMufMa2jstaWqw8VwauAYnxPiY07NBjKrPJoU1M=; b=owGbwMvMwCX261qtXAKXKjvjabUkhiy1i/trmY8wXFU74qot2bFMQKYllkdpZl28/6LcZt/OR qdEq6qOUhYGMS4GWTFFlhfnrrdt2HMm4F6SXQvMHFYmkCEMXJwCMBGLYEaGGddjWhj5Nom9NZZx dnsg6qDb+vSPoVpBs3Rha/1MyRkLGBm+xtTJSfmev1K2/2Tr4t/P9C4Ibt+n+LLSJ2aHYv+PR4K sAA== X-Developer-Key: i=iacobcatalin@gmail.com; a=openpgp; fpr=F609BFABD84EB5C9DDDC37EDE89C6A3571CD0E33 Commit 1cea5180f2f8 ("block: remove pktcdvd driver") left behind an export that is now dead code. Remove it and move the declaration of scsi_device_from_queue() to drivers/scsi/scsi_priv.h. Signed-off-by: Catalin Iacob --- drivers/scsi/scsi_lib.c | 8 -------- drivers/scsi/scsi_priv.h | 1 + include/scsi/scsi_device.h | 1 - 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 85eef401925a..b67f0dc79499 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2224,14 +2224,6 @@ struct scsi_device *scsi_device_from_queue(struct request_queue *q) return sdev; } -/* - * pktcdvd should have been integrated into the SCSI layers, but for historical - * reasons like the old IDE driver it isn't. This export allows it to safely - * probe if a given device is a SCSI one and only attach to that. - */ -#ifdef CONFIG_CDROM_PKTCDVD_MODULE -EXPORT_SYMBOL_GPL(scsi_device_from_queue); -#endif /** * scsi_block_requests - Utility function used by low-level drivers to prevent diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index 7a193cc04e5b..37e5601be2b8 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -102,6 +102,7 @@ void scsi_eh_done(struct scsi_cmnd *scmd); /* scsi_lib.c */ extern void scsi_device_unbusy(struct scsi_device *sdev, struct scsi_cmnd *cmd); +extern struct scsi_device *scsi_device_from_queue(struct request_queue *q); extern void scsi_queue_insert(struct scsi_cmnd *cmd, enum scsi_qc_status reason); extern void scsi_io_completion(struct scsi_cmnd *, unsigned int); diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 9c2a7bbe5891..9f716497a959 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -407,7 +407,6 @@ void scsi_attach_vpd(struct scsi_device *sdev); void scsi_cdl_check(struct scsi_device *sdev); int scsi_cdl_enable(struct scsi_device *sdev, bool enable); -extern struct scsi_device *scsi_device_from_queue(struct request_queue *q); extern int __must_check scsi_device_get(struct scsi_device *); extern void scsi_device_put(struct scsi_device *); extern struct scsi_device *scsi_device_lookup(struct Scsi_Host *, -- 2.54.0