From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E8A8221540 for ; Mon, 8 Jun 2026 12:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780922837; cv=none; b=UU6FtlxMI46c0THpnlgLb3bc12QPcM9J0wGwlx39wF4g08edIq+un6gDO2K/epDrfQ6Zn1DkssyAalTF8eg4MlwJAnky3Zx/Z3pUDWMhp6lyWYlsKO4fw5cvQVqXXaMTJyK7l3swF40oVkNpQQDhfcCHzVtdY8H6gF3F3R+o5xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780922837; c=relaxed/simple; bh=5QIWHfuaYcbhnSqD7D2pTYbNxZvCwfXi7K2yANHnOko=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IFUStoZbfIS9EDL0sGEn9KVjtDjyE4TFVe6BLPCd/F3ZlOKG1oE4aQfCK5vGYPjxMCCmgvE9y1SzbgxJIOGkqsyP6zUekQLoS1UIvsSTqSA+7EXuz4dPAKcr2r9HC5MwVOvGEibB8X/dnFxuAvf2Coy4tX/TanMH3S6dWKxPXR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gNARJcPe; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gNARJcPe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780922836; x=1812458836; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=5QIWHfuaYcbhnSqD7D2pTYbNxZvCwfXi7K2yANHnOko=; b=gNARJcPesshkmiKWMd8M+uPCffHAjoZqIFMEq8jT4rAhfMtadeTAkh5R siUOkO4VyKS7BboqtEtVWk8OWrpV6EyZhHYgDmbyUQStsgNNP4fnGH6Ic u43WtYWowL1VhUYGl2R/lT2sRSjgSwtDNO2d5YcqXq6R4hN486VEkjz0/ x4RNrZU110t0Tysim9PhVZeiN3kU+9SYiXGcLhZG6qF94pchVWoMcGgRS FFcHX/i6YOAYT/7UtUlJkOS9SYpWETQB4kJw+IDigRe9LjiHQ56rhB4M6 dHrPFwy5qs06Wi3xTSvGuS0/WqGIk+4xdnBJY8aGnzxjiAd2VEFPLhoFc w==; X-CSE-ConnectionGUID: j7RhVZi/Qa63uXShrdSRkg== X-CSE-MsgGUID: J8+ZaWoaRBqvJFe1HjxHag== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="85281913" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="85281913" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 05:47:15 -0700 X-CSE-ConnectionGUID: C3yT7zy5S2GE4gJliCcd2A== X-CSE-MsgGUID: be9qF3r+TJCgEcWLrSVMLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="247409309" Received: from unknown (HELO [172.25.112.21]) ([172.25.112.21]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 05:47:15 -0700 From: Ricardo Neri Date: Mon, 08 Jun 2026 05:57:12 -0700 Subject: [PATCH v4 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260608-rneri-fix-cas-clusters-v4-2-1526711c944c@linux.intel.com> References: <20260608-rneri-fix-cas-clusters-v4-0-1526711c944c@linux.intel.com> In-Reply-To: <20260608-rneri-fix-cas-clusters-v4-0-1526711c944c@linux.intel.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tim C Chen , Chen Yu , Christian Loehle , Barry Song Cc: "Rafael J. Wysocki" , Andrea Righi , K Prateek Nayak , Len Brown , ricardo.neri@intel.com, linux-kernel@vger.kernel.org, Ricardo Neri X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780923493; l=1405; i=ricardo.neri-calderon@linux.intel.com; s=20250602; h=from:subject:message-id; bh=5QIWHfuaYcbhnSqD7D2pTYbNxZvCwfXi7K2yANHnOko=; b=sgNjrBJ6XuRbndzRjuLu2N2qjwHB4QCoPz3kKRASpCmUY0nUb1vQbvvkJQiHsanIA4IB3K8R9 c19KcA7GlpEDmZ0LxW/5jyrsK3FdvbwuzL3+ommjkkHGQop1avalfuP X-Developer-Key: i=ricardo.neri-calderon@linux.intel.com; a=ed25519; pk=NfZw5SyQ2lxVfmNMaMR6KUj3+0OhcwDPyRzFDH9gY2w= The argument sg_overloaded of update_sg_lb_stats() is only consumed when balancing at the root domain. It only makes sense to update it in such a case. Commit 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") updated the logic accordingly but missed the case in which the root domain has the SD_ASYM_CPUCAPACITY flag. Fix this. Fixes: 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") Reported-by: Chen Yu Signed-off-by: Ricardo Neri --- Changes in v4: * Introduced this patch. Changes in v3: * N/A Changes in v2: * N/A --- kernel/sched/fair.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 229f32cebf1f..86987c69bddd 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11853,7 +11853,9 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check for a misfit task on the cpu */ if (sgs->group_misfit_task_load < rq->misfit_task_load) { sgs->group_misfit_task_load = rq->misfit_task_load; - *sg_overloaded = 1; + + if (balancing_at_rd) + *sg_overloaded = 1; } } else if (env->idle && sched_reduced_capacity(rq, env->sd)) { /* Check for a task running on a CPU with reduced capacity */ -- 2.43.0