From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E224934BA49 for ; Mon, 8 Jun 2026 03:34:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780889674; cv=none; b=HmDna037IUtp2bDjg9q7MTDH00VJhA1VK2bWtu8tiLISd0hOrn49RhSLn4BJr5Y9KVRWyxG6rI5XP1Wx6aIJKpSe1rLbRVYw8jevROnMMQMfvsLji94UZtioODENKOE57xUxnkTfWaXxT6w6UL6xQvps33GvfvbvetZJp37vZ/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780889674; c=relaxed/simple; bh=Wrzvc03qcJAI2fJFG5Y+43Rc2qKa7QvoUxtDVB+jgKc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RriGs1droBE6Wj69Z1J6nDEolbgJqYcaxcpQV0sFNMJ3mbblXYGf8XiqdWLRJbqKNSKpnDTJNX5IhWi7PCKMDmkB/q7Ivmx+Ti2Qyv2EPxlTguXXMCk5X4wLZ2N6Nn9U0VlsJsH4314sbICzXEPz4i7CYLQFQAVqD82uYHOL8TQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=sirat.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=sirat.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36dac5d5da0so1830950a91.2 for ; Sun, 07 Jun 2026 20:34:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780889672; x=1781494472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=46YxaO4ofqI9vyglwTBha2ZlTUmES9KzjNe4ZaBWo1M=; b=SK+eu1JnBDc61Inlr2xJXBubagVOU43DhINleEZ9EBXvb1DUwDU2PROM00+1NqAeZt yPZOoRTI/39XA8vYs8muHNrj+Z8598I/Hw+40cEouqzI8C4UlB3jWgh2nO6VRx1cclZR rtwF2Vbd/eeWhP129b41jmwVCVwDY/g6r+k8SwFF5tZeM1BrRoodAWa8EJBtbxEMi2XQ U8P/jAW4iY1d0mrrgjwU/wAkXdSupurIF9ncYY4NM7B066uv7/tM7rhM/YOUC78BjG2b 3Q34avxsbfNmxShQV770cW+wGzBi02sGkdK9jvTF5uTnEVsj8Vhz8Nm0UzBz5ukkVoc3 /dCg== X-Forwarded-Encrypted: i=1; AFNElJ9rAWsWYvhjg16mQp9TFfVk3VlVkdw1wnMiRuzzyderx7BMGlw19iDsDl9s2Y5I+tI4WbQd9QhR4J7nHTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxG0CqEbjCOSOx+Zm0aoqKg2Pnp4V+t9YXpG6KbrM3Y+lnMfw+B R/V3EQq7Ww8CWZ27huWnQ1LBpltupQVoxB2vG+pCLy/cJX074ZrCXKTF X-Gm-Gg: Acq92OG5wOHcJzHqrl4k4zd8tJ31Xzb03IQCdtaxu/dUZviZjmOU1lYcLGfasdwSDlK 1B4mALWrGZXP9I9bL9VOb53Vlm/DiMBHlm1ob12e/WpjxyWTEVGA7er1eY2TccdpJ70ch78TyyL E4iXEUkpCXOjmLZN86IGXHYm0vyQZ/kYI7ydq2mpaa3khkiyQo0ES4Xh/iK37/3hr0ftBtoMD+E XAFA1IXU+DKpKKX88WjdLuHIcrKIiXI0+8Bu43urXrQnIwDQGSMRAM+C3O7C7rRiUh+aGPAvyOS YReHCYogFMy9BecSwtTCeR2+gGKco93OmszwSqMo02u8TQwFt7pSkVQquK87QI/pGQJkVUHZPPz 8/2jZ5zDB/uD52j0wNNhG3CF3EQW/osp9DYrFi9zZtxxWl9zI3EQMt2wYT2kK/J/N5Q2vYdVWTU Foni3uNJjAwQ+CWKRbyifxSUo115wJiJ6hHl5dSMCAQ5WjmWRAdDabiPZFDF5fphIVo3+4Up5Uh R1TC4eJ+fS/oFCC5DI+eOMMncndFGdIX7ZVJv4V X-Received: by 2002:a17:90b:4b0b:b0:36b:a2cc:4857 with SMTP id 98e67ed59e1d1-370efdaca8fmr17829661a91.18.1780889672056; Sun, 07 Jun 2026 20:34:32 -0700 (PDT) Received: from fedora ([59.152.111.50]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6c76f55asm14102286a91.7.2026.06.07.20.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 20:34:31 -0700 (PDT) From: Siratul Islam To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Siratul Islam , Andy Shevchenko Subject: [PATCH 1/1] iio: proximity: cleanup fixes for vl53l1x-i2c Date: Mon, 8 Jun 2026 09:32:06 +0600 Message-ID: <20260608033218.26514-2-email@sirat.me> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260608033218.26514-1-email@sirat.me> References: <20260608033218.26514-1-email@sirat.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit - Sort register defines list - Extract vl53l1x_wait_data_ready() polling logic - Logically split regmap_read_poll_timeout() Suggested-by: Andy Shevchenko Signed-off-by: Siratul Islam --- drivers/iio/proximity/vl53l1x-i2c.c | 36 ++++++++++++++--------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/iio/proximity/vl53l1x-i2c.c b/drivers/iio/proximity/vl53l1x-i2c.c index 4d9cb3983dba..ed83999cf735 100644 --- a/drivers/iio/proximity/vl53l1x-i2c.c +++ b/drivers/iio/proximity/vl53l1x-i2c.c @@ -43,6 +43,7 @@ #define VL53L1X_REG_SOFT_RESET 0x0000 #define VL53L1X_REG_VHV_CONFIG__TIMEOUT_MACROP_LOOP_BOUND 0x0008 #define VL53L1X_REG_VHV_CONFIG__INIT 0x000B +#define VL53L1X_REG_DEFAULT_CONFIG 0x002D #define VL53L1X_REG_GPIO_HV_MUX__CTRL 0x0030 #define VL53L1X_REG_GPIO__TIO_HV_STATUS 0x0031 #define VL53L1X_REG_SYSTEM__INTERRUPT_CONFIG_GPIO 0x0046 @@ -64,7 +65,6 @@ #define VL53L1X_REG_RESULT__OSC_CALIBRATE_VAL 0x00DE #define VL53L1X_REG_FIRMWARE__SYSTEM_STATUS 0x00E5 #define VL53L1X_REG_IDENTIFICATION__MODEL_ID 0x010F -#define VL53L1X_REG_DEFAULT_CONFIG 0x002D #define VL53L1X_MODEL_ID_VAL 0xEACC @@ -191,6 +191,17 @@ static int vl53l1x_stop_ranging(struct vl53l1x_data *data) VL53L1X_MODE_START_STOP); } +static int vl53l1x_wait_data_ready(struct vl53l1x_data *data) +{ + unsigned int val; + + /* 1ms poll, 1s timeout covers max timing budgets (per ST Ultra Lite Driver) */ + return regmap_read_poll_timeout(data->regmap, + VL53L1X_REG_GPIO__TIO_HV_STATUS, + val, (val & 1) != data->gpio_polarity, + 1 * USEC_PER_MSEC, 1 * USEC_PER_SEC); +} + /* * Default configuration blob from ST's VL53L1X Ultra Lite Driver * (STSW-IMG009). @@ -230,10 +241,9 @@ static int vl53l1x_chip_init(struct vl53l1x_data *data) } ret = regmap_read_poll_timeout(data->regmap, - VL53L1X_REG_FIRMWARE__SYSTEM_STATUS, val, - val & BIT(0), - 1 * USEC_PER_MSEC, - 100 * USEC_PER_MSEC); + VL53L1X_REG_FIRMWARE__SYSTEM_STATUS, + val, val & BIT(0), + 1 * USEC_PER_MSEC, 100 * USEC_PER_MSEC); if (ret) return dev_err_probe(dev, ret, "firmware boot timeout\n"); @@ -261,12 +271,7 @@ static int vl53l1x_chip_init(struct vl53l1x_data *data) if (ret) return ret; - /* 1ms poll, 1s timeout covers max timing budgets (per ST Ultra Lite Driver) */ - ret = regmap_read_poll_timeout(data->regmap, - VL53L1X_REG_GPIO__TIO_HV_STATUS, val, - (val & 1) != data->gpio_polarity, - 1 * USEC_PER_MSEC, - 1000 * USEC_PER_MSEC); + ret = vl53l1x_wait_data_ready(data); if (ret) return ret; @@ -461,14 +466,7 @@ static int vl53l1x_read_proximity(struct vl53l1x_data *data, int *val) if (!wait_for_completion_timeout(&data->completion, HZ)) return -ETIMEDOUT; } else { - unsigned int rdy; - - /* 1ms poll, 1s timeout covers max timing budgets (per ST Ultra Lite Driver) */ - ret = regmap_read_poll_timeout(data->regmap, - VL53L1X_REG_GPIO__TIO_HV_STATUS, rdy, - (rdy & 1) != data->gpio_polarity, - 1 * USEC_PER_MSEC, - 1000 * USEC_PER_MSEC); + ret = vl53l1x_wait_data_ready(data); if (ret) return ret; } -- 2.54.0