From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B98A4223328 for ; Mon, 8 Jun 2026 04:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780891606; cv=none; b=tbzfn+9sEGx8CQ/Tzze90zf/R/zgqNnAkxraKIyXzK7p2uCVVVAF6wlnPcB0CbHgJ8W13ZpMPHEU+1Wq+GjHyoARy6t+FNWVu8dSD9ooisQ8JHGQwrssb/PAzMDRrP9LRagKqyYBVt7c6mvweB+RVJ6W/FOEoHiQ7vRplMfwJvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780891606; c=relaxed/simple; bh=Ku3Arqzn1r7fZ4oF4v40XVB2LI484/STbTBWzmITvwI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HAHFJTo1Lnzj83gdYHKNzy0O0Vkbf+hMh0YfS5SSYsdDyL8xEt2JC2+21V/bDeiOrxzTDBEQlmq1eOzZHEU2uOysTHnyXiR23uiLCwCmHLB+R1hv+IrAvOua7mJweD957ihE3BcSCb2BcipI+gEZ05VdbS2fyvgjbQRztqfAUz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JUpZOEVY; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUpZOEVY" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-5176ca6bab1so41872671cf.0 for ; Sun, 07 Jun 2026 21:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780891604; x=1781496404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y69ayd5+81/FuoX9JwW+2OYBy2TwAbLRbHarkaIwFyQ=; b=JUpZOEVYlEznSeELT0z6rjdhhzMnhzAokV+PUW/PzAgzWedRZW9TOSr0UON2/NDpOL nK9orue/iUYT6WpsLmTHK1Tc4mB5x4KgEqvFfae1dvbxi+oQIF1gvt02ym4IB5Zm/WTH ck/3cpR2cF36z9O3JE1fdh6f0rGttG7aGdeNSju4onbi/Bm4CAUDfCWS2WKDUBPv3/ei ABo414sHStQuK79q4qxxeYePqqVZofFrJxZ1S9JpOY+NKKbJL2j7aAhMLVPFsT99CFy2 5FX7GWYRIlaDOyVQdYHD84gdFWe8fgAyvJPFbNqIlGRQihh8cqhulCktNNXA1GP2pSY5 bI2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780891604; x=1781496404; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y69ayd5+81/FuoX9JwW+2OYBy2TwAbLRbHarkaIwFyQ=; b=Ztvr9nlRzjFYwMkvkJVMdU1okUy1gCCEBa4d9XkF5qkwszL7GOU/RnKJehNjoCma6L SgXBg2hSfF2tzPDW13ecEh2lTlsIKaEO+RvSKjDkv9RShKoq7ft2QRiMWfiLLN/FzSbh YFCW4WvnrpayrFFf2yTfsjJ3g7p4/iv6IRC4lRGt9BwtCXZhXAfMzRfGeRP05Baz8fNJ /p2Mz65ViJg2EsFSN30bGHNomhUucWIsRsxmQNj6taZ0kUFWlFn5oOwX1l1a9Grn662z 2/UVXU1pRm8ks1LKfmUssiPsBtBogX4t+ymjGmJx/4JZ2EfkhGTqV11Dh/3cJ4tA6P8a EiwQ== X-Forwarded-Encrypted: i=1; AFNElJ+55GxEhGEHigPSzrdFhdKdUsDYeBmKStjXwypSoleKHH0Bt7DDvznIVg4qMzwQPQdMqhChtmyctVsYUkc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8LFZl0ScbSwN6mVTQ2HrDPW0ueiW+e2CSrqwKZXTC7oOVcX97 HnnOa4LjMk6VFAPZZa5R48B19LOdEsdZ9/ovr+v1cY9FA8oi2G0d4Nvi X-Gm-Gg: Acq92OHB3LgiopjXj6aOCc++WbDxEGGLFTNAlElgQALP+SGoM/MBoexlj45fCJhATVv gKINV05DgzZtNx39jC7YbsaDMhz1oD5ugnyA1S+2FBz8qrveWionirO2P6ruW/3lf/6ErCUzeW2 0jGd8y3g+3ak1YksoshYdwuzVANcI0NRFCpea+Uj91Aw6qKNLZA6ITG6Ay2FqClYZPIq7c+Qi53 ucW5HzvYdkfHFk3SXhIa0gIGqhzgiyHrC0szs9uRoRYulzor/krVlknSKpqJDSFDEcpeYx1SjSS dG70TYSFp/0UG+jDDJfYQv9sri5R/HZQQTjWRn2ggg+uysy1uG6d5EnSBJb00qUgtOGeaM4pQdq nSz6YobpGGYoeq5vyZvDfAYmhMtyghTWCSN2OhCBkINqQZLU4EIvpo400dH5IdBywPmYKzC1/MU MT6eIQoGUy1JikGkI1E9CkK0bch+XY4bfq67HcaQFbmpv7EJeUQpk= X-Received: by 2002:a05:622a:4d88:b0:516:ed2c:9c75 with SMTP id d75a77b69052e-51798708bd9mr137621361cf.16.1780891603597; Sun, 07 Jun 2026 21:06:43 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c4d7absm139938971cf.11.2026.06.07.21.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 21:06:43 -0700 (PDT) From: Yuho Choi To: Richard Weinberger , Miquel Raynal Cc: linux-mtd@lists.infradead.org, Zhihao Cheng , Vignesh Raghavendra , linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] mtd: ubi: Fix rollback for explicit UBI device numbers Date: Mon, 8 Jun 2026 00:06:39 -0400 Message-ID: <20260608040639.2616638-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ubi_init_attach() rolls back module initialization failures by scanning ubi_devices[0..i-1], where i is the mtd= parameter index. That assumes the parameter index matches the UBI device number. That assumption is not true when mtd= specifies an explicit ubi_num. A successfully attached device can be stored at a higher ubi_devices[] slot, and a later failure can miss it during rollback. Scan the full ubi_devices[] array and detach by the actual array index, matching the way UBI devices are stored. Fixes: 83ff59a06663 ("UBI: support ubi_num on mtd.ubi command line") Signed-off-by: Yuho Choi --- drivers/mtd/ubi/build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 674ad87809df..90c5c83d90e3 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1317,10 +1317,10 @@ static int __init ubi_init_attach(void) return 0; out_detach: - for (k = 0; k < i; k++) + for (k = 0; k < UBI_MAX_DEVICES; k++) if (ubi_devices[k]) { mutex_lock(&ubi_devices_mutex); - ubi_detach_mtd_dev(ubi_devices[k]->ubi_num, 1); + ubi_detach_mtd_dev(k, 1); mutex_unlock(&ubi_devices_mutex); } return err; -- 2.43.0