From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C102BEFFD for ; Mon, 8 Jun 2026 05:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780894853; cv=none; b=qVBjB7hT3DtRLfg9/lL52YFtaxjf4fhr8DdUpnAQc4pNr/UNdWa41URru5rck3KulMGiMXynwiDQ4UyPY2TTydrJg7czENf3P5oQy2g2iHmcmhzivG0ow2Mprg2omhOixcAzM4SFKVs1nF8F0fnQetsbW+w8AAzNQwIl0mw9Brw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780894853; c=relaxed/simple; bh=LEO51zVZQ4PwIYRBvGUMxl65oubDJDhjO2lHjYxIrwE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=NbG1T7mFc/dW1vVALTTbpi6nzgMp2v9z2RVFK+deuW907XWXV3PhE7zJXFoiiWfQ1pJqTkKD7S6AYOlu5qMII2IqYxWCmqfApd5dmv8u4rCaQdmHkU89Kv/rKfkmRYWOz3Oyb8kjp1ASsCF6seKHP69/jUe9MNS2tkd4DgV++q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ViG5A+si; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ViG5A+si" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2c0c2c7d45eso34523385ad.1 for ; Sun, 07 Jun 2026 22:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780894852; x=1781499652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RmNq/ntgnQWCSXKyuTVv4BpCK0SRdqBKAJRNsXGpW+o=; b=ViG5A+siwNOvELQpWw/UHB5Y2YRgi7on8G2J3576pepuhqHIrFc39CcPOQxPLdv05V NBsOA/zlRkaLCJNIjW4/1NFPZpwCIJ42T6dDWqwAlkCefyIGGlKsBdcqzMcoN9cssVaI Fd1Gk23oGBtm3dY3/EyAvQ0BoY6k9WfzfxU3NOZhO3/3I1vGWDY727cKFortON+cQFP5 8Tfj5rdI2gg9CCKwj/OhMETJeVFg8/WbuL4OPRPCHT1Z3mZeuPRfWbvz0/B3QTnDGC3V kviXPavwn33smPIjB2GA8+GZ+syOVSJchMMXjTdXkprh9DCm9ZyzrrQ+5tQcEVCt5Tgk 80pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780894852; x=1781499652; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RmNq/ntgnQWCSXKyuTVv4BpCK0SRdqBKAJRNsXGpW+o=; b=k4CpT4UliULtBIsGp/QQx6BoEq4L6pp1KWU3vOWb1/ixEYZ9oqj91czzJ2Yq9zp2H9 Q63eooxz8YVnu5muUg0QiuTIAN/EtpPF/+FCeA9GrrP5uYJADn6sWqhHhQ5QImmKAbPo D0+bzmbVZ/fVRoLBanyWn5CZq7g4StIMHb4qGJNXe4YXp0P8/qgBeUIqnfN07HYIKQdX nGf/w+IHxnNPC7JA3r2JA7Lot/r5v/GyEwkS7IfVcki2PuqEbjW+qf4u5CyJEqOjYiMB bcK3xRuM9q7Mf6XP9ueapcFskPGFLNnKil2osfdtKq9rx58a1wu3JNFl2xWjNUGEav8R eQ2g== X-Forwarded-Encrypted: i=1; AFNElJ8E9sYZ5sPpBpDZC63uJ2xAN4XkZMuwi7PZ+iNLyJVBDfbQ4rbg958AjHacp3Su4SlcViBPoV5Qn+1FxUw=@vger.kernel.org X-Gm-Message-State: AOJu0Yywf6etDcsXYWxcB6AxRHQ28mr6q6VLj05+Xt5DkBQCV50KD+5x QBjrEnV2CGI0B9nORlFiD7VUMl4DNu4UHIjn6RUDOTg1eKA3mzbOuIq9MOfTSA== X-Gm-Gg: Acq92OFmCwcDI5ytLAajUFlKsYNHzS50tnUqeFrIEraBhiFc/uNLJ8N7i66FTw6Yfdo JuJB3he7b3BeSJckmGoVVGeFtbZ+Y7FiZ7PaOe63dhI9EVKQAb9y1kyKvLzcDQak/R56Utt9DIZ VC0VPc4acv93qiE4wd/rZS91a17Dkr96dKlCJ9EYma7Is7LtLAFSJHhLaZZxuLAXnOGnBEsCcUf qMvRne1MPGwXLyKzrnPr2sielPOBlFHMTlYnn2zYlbnXOF1YOICBmflC1N0Y8yP30fZPbkQ/Dhu hL3oPdFl2m78/50B6nLidUY+3vKCEbmKGK1Ai7jQ5dDpy2iqdSQM0uCytSD2QauPwrYURDHYIUD VYPhNMJA40NrLzMKGFkklQ2j1Ddyjpphlw3VHUFKZXGx8b40nRjQCXwbbZesi6XaisXPkjZfzxE B9kuHfZwDedPVnlbY5WOx+w1uw/keneTi5ive+HByXRbmWjZb7FE+OtpAePe/f4sz7yzFVzCZVh iV2vhDxIbs2wUYEebVTzEDsXxKgymNFOqi8HVldTe1m3Q== X-Received: by 2002:a17:903:3885:b0:2c2:245a:3368 with SMTP id d9443c01a7336-2c2245a3649mr110430735ad.14.1780894851632; Sun, 07 Jun 2026 22:00:51 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f94a7fsm167581765ad.28.2026.06.07.22.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 22:00:51 -0700 (PDT) From: Rosen Penev To: oe-linux-nfc@lists.linux.dev Cc: David Heidelberg , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] nfc: pn533: fix memcpy overflow warning Date: Sun, 7 Jun 2026 22:00:34 -0700 Message-ID: <20260608050034.5679-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit error: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror=attribute-warning] As suggested, add a struct_group and memcpy that. Also replace 9 with sizeof for clarify. Signed-off-by: Rosen Penev --- drivers/nfc/pn533/pn533.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c index d7bdbc82e2ba..4e721a8dfd8b 100644 --- a/drivers/nfc/pn533/pn533.c +++ b/drivers/nfc/pn533/pn533.c @@ -740,8 +740,10 @@ static int pn533_target_found_type_a(struct nfc_target *nfc_tgt, u8 *tgt_data, struct pn533_target_felica { u8 pol_res; - u8 opcode; - u8 nfcid2[NFC_NFCID2_MAXSIZE]; + struct_group(sensf_res, + u8 opcode; + u8 nfcid2[NFC_NFCID2_MAXSIZE]; + ); u8 pad[8]; /* optional */ u8 syst_code[]; @@ -778,8 +780,8 @@ static int pn533_target_found_felica(struct nfc_target *nfc_tgt, u8 *tgt_data, else nfc_tgt->supported_protocols = NFC_PROTO_FELICA_MASK; - memcpy(nfc_tgt->sensf_res, &tgt_felica->opcode, 9); - nfc_tgt->sensf_res_len = 9; + memcpy(nfc_tgt->sensf_res, &tgt_felica->sensf_res, sizeof(tgt_felica->sensf_res)); + nfc_tgt->sensf_res_len = sizeof(tgt_felica->sensf_res); memcpy(nfc_tgt->nfcid2, tgt_felica->nfcid2, NFC_NFCID2_MAXSIZE); nfc_tgt->nfcid2_len = NFC_NFCID2_MAXSIZE; -- 2.54.0