From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C456E365A14 for ; Mon, 8 Jun 2026 05:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780897416; cv=none; b=GdM9elwa9xVM+Yq09BOX1gwUkzEGaJAs1DdhnjIaw9hmkhOzmWFAJL7dpZHM7K4ZrRBH3GMHMuFWopdNkZDOA0LIc3CZs+YyUdecXgXcnbLFULJ8WoOP0CDKAzEtsHbLOkPVXXTQG3uHsp/zNQ4d0y4o+pYzhTpAIOW6cqws1/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780897416; c=relaxed/simple; bh=R+NKl/FyOuS6RcqfPQVYLwMCMeC8u1wvspCUJQ74Igk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gfLejyipF00qmU+z4tBuZ/bJNNiCSkSSw151N1HblETXXdWmr78HW1NZwoZ48me2uqxsJgweXjMEq2Y6bhvvG5Lk5h/4dfmxc619IODdV8sHAC9UKSqeaaJv6oDb4Zg9uwjnfKujj5lwpkVhN7yQ471EVUMA9RmxLXwOTkXjph4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=A/b5LBjO; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="A/b5LBjO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780897415; x=1812433415; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R+NKl/FyOuS6RcqfPQVYLwMCMeC8u1wvspCUJQ74Igk=; b=A/b5LBjO158TNSbTH+yk2UaDA6tRtoTfQQ8cQiyazaYd0jwNQWIY3NRb 8vOfjRySEA//usS57tsVG16bSUzRuzNGkBVUtEPoYFfo3ZBBpYpB/7x8u gwznHPZRycSeKzmjGafa3Q9IVyxNY4qQb0E2RQl+5tNX54nKQmRRUATcE i3SGRpozj4Qgd4wUlRfTRaIShlu7C4logcW9/1YImJyo6+QMfbJ2jdhr1 17y1RAu4pZ8Z6eRuIE+Sg/tWBP/cNdAvHZoHtApZEghdIwD5UUehQ0pYM cIK2Zr46wZEeZTTdXdt/v8gkiOxJHinv5JzLa6iH4tnlRTTdsrYHOq7NL A==; X-CSE-ConnectionGUID: hIBwfKaaQvSBBshp1d5X4A== X-CSE-MsgGUID: w4KtQB7WQAmUoQ+hnQ4TxQ== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="104284048" X-IronPort-AV: E=Sophos;i="6.24,193,1774335600"; d="scan'208";a="104284048" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2026 22:43:35 -0700 X-CSE-ConnectionGUID: huVb5kKFQ1KwO+aciX17FQ== X-CSE-MsgGUID: VENvf8h9RaucIeHkg8LuGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,193,1774335600"; d="scan'208";a="245505684" Received: from conormcd-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.114]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2026 22:43:32 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, david.nystrom@est.tech, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 5/8] i3c: dw: Drop redundant Hot-Join cancel_work_sync() in shutdown Date: Mon, 8 Jun 2026 08:43:09 +0300 Message-ID: <20260608054312.10604-6-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260608054312.10604-1-adrian.hunter@intel.com> References: <20260608054312.10604-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit The I3C core now installs an i3c_bus_type shutdown callback that flushes master->hj_work (via i3c_master_shutdown()) before any driver's platform shutdown hook runs. The explicit cancel_work_sync() in dw_i3c_shutdown() is therefore redundant: by the time it executes, the Hot-Join worker has already been cancelled, and the shutting_down gate makes a new worker a no-op. Remove the now-unneeded call. No functional change. Signed-off-by: Adrian Hunter Reviewed-by: Frank Li --- Changes in V3: None Changes in V2: Add Frank's Rev'd by drivers/i3c/master/dw-i3c-master.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index eb9a13a73684..c7030d0cd8a6 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1793,8 +1793,6 @@ static void dw_i3c_shutdown(struct platform_device *pdev) return; } - cancel_work_sync(&master->base.hj_work); - /* Disable interrupts */ writel((u32)~INTR_ALL, master->regs + INTR_STATUS_EN); writel((u32)~INTR_ALL, master->regs + INTR_SIGNAL_EN); -- 2.51.0