From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E40346E40 for ; Mon, 8 Jun 2026 06:36:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900615; cv=none; b=ot6oIGuxr3Zzg+89lph7TVKUBw262ofFEBl1QEKVwOMsxtwdbyxcCrrG0HDW19fsLrdJuS93Pj5sMzToiCZCYwbkRGfOezYvzGe/Pq8HzmO1/ZqcCNKJnD5n6FHrgfZ4+vSw1ZW+JOj2jIzJTfgu3f6SXh3QxBEu6W9WGXPqxho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900615; c=relaxed/simple; bh=CZuXo67fJvF6hBwz8qT/sDwTUPQ/oq7c4Qo2m0qAU3k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ByDACb3y7z6dIRtJRKPpI6apL9eRd9dUeX2xfU26K1Rwoi1Y9+ALh3wvYJVlY37ZqB/BYloy82QzeFsVAi624caLKXfxY893YLE/B7VDjL/1FwJIaGsUTvm+T9DiDWPtAeom7AqWEjHLhSWynj/m1zbGxIVBspv2qytK6iVq/mM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cVxWTZtT; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cVxWTZtT" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bf3781ca51so38279665ad.0 for ; Sun, 07 Jun 2026 23:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780900610; x=1781505410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mbMuCvI13wK+vW6caoDnTbULN6HvH/7zcFjXyiZbrkQ=; b=cVxWTZtTRJTx/i79FPwukC/PfqVBSBVwugRul7V0xpC0gv4XVPXr2aH0i5LLd32sWM +izEVKAjiDr8CfWitGXfD95iSTxJHuJ7He5oBZ9nufkdzCyhY3WTYotzNRvvK9VswziY GjgPP+Y8wXyq5DI6j5zwGjrAmGb5sDIXMkgNXp59+o4AXZbMFuWGo2cbh1gDLqMsBzdj x2mAyfzL4IUHHjPw54b65rUeNc90qtFvPdfA8prIadkT8DulGTmxbwpiC6+pNCNtG4wU kr2v1GcwIhqbzLkhJWRyCzDJCF7tG06OGJJCl4T9SZvWrQBtjFmMt+uumuJlibSf0u66 wz/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780900610; x=1781505410; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mbMuCvI13wK+vW6caoDnTbULN6HvH/7zcFjXyiZbrkQ=; b=moKszGdlhIcvyQULGjVdTbQ6hBq9WGkgOkMmplNOk2SnD+j+lG8N7l5DW+sUSJ6JEA DKWuUD2d7jjYXgIwd2lXmAfYvBKpN8+4pHNFXOtRnIYCqTSc7QUx4W+whqNLfi4ktsD2 LTy3rwMtdvvcaDm5u2bXESr6WAxiz0xsuUC+aRv+7XMx9Elz71gLyOwSsF+mnNCop0SQ CAi0wnVPB9aGyLNwkb/deLKW/OuPxoogZ3Ga7v/vlv4v2FFC0+o/EWOZSZO/XqOzY7m+ YT5jJGEFyikYiurwr5jBqywxAGYoZPm8WPh7AABlQQZo4WMCqU11F0AwlYI5JTErOOcv xNng== X-Forwarded-Encrypted: i=1; AFNElJ80V+tSYuO2pEIHzTTxzr21gY+z0Ia1GndhlqALiP3YgBn3kUZbSrClKiHK8nhEDz2EjX9tZr/CdCnI6Ro=@vger.kernel.org X-Gm-Message-State: AOJu0YynOckd3KdRe+eW1/aqpjbVSs1PEN50sHL2DT+9DF1keLQINJfo LvhBeo8ekn7t/EfmbfDOYYJAzoK5oK5AF8EsMXP8O7N+oDFgiY7E9eAZ X-Gm-Gg: Acq92OGgMwdo6VJ8/IDy56xfR1dqc2I+dFR5APd9sDuulKadK41SdxLiNsNsZU7HqBd mXr6zxa2qm4XwuRrdiQNlTORXfq/0oa5o4ErnOekjIczNPktw0zloP6terDHAAU9bP0FcJzQqkG dmxR147ZJDmvifEK/s1Vpuq9hu/DP2DH+yxnc+sl+AOXXohw9LIkD38Rm/aOHkCFC7/hgmcXLVI EZhVOgWXfA3LBMFGl66NC0+bHeyg1KLk58yGCkTpkkScd7m8864yfNAIM0fjX4uIhGkEjWVKmHY uqDfEg3i42mTNRnq4z2WwvW+nyCAfYs1hkeBWK2+bNkqyTm6IME9T/9nY6euZVM71JQ1y7HhVSi UiGWPsZ/D/CkG0IdNtUSUfjKjFZBldsYCxwsM9mDRLmAapdQ8n7+DW8edl5Fwf9yrOtKwN+tfux TlvPgkFOlhB9z2qDLYYgTu3kpceaN9KHoM97FWgxvuMCPByKtLcAIt X-Received: by 2002:a17:902:c946:b0:2bf:281f:19ec with SMTP id d9443c01a7336-2c1e8208778mr165217985ad.24.1780900610193; Sun, 07 Jun 2026 23:36:50 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:9a2:954d:67fe:d9c2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f84335sm168839725ad.19.2026.06.07.23.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 23:36:49 -0700 (PDT) From: Ruoyu Wang To: Johannes Weiner Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] mm: memcontrol-v1: use nofail allocations for soft limit trees Date: Mon, 8 Jun 2026 14:36:44 +0800 Message-ID: <20260608063644.39-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit memcg1_init() allocates one soft-limit tree node per NUMA node and then initializes the returned object. If kzalloc_node() fails, the rb_root and lock initialization dereference NULL. The per-node soft-limit tree is required by memcg v1. Use nofail GFP_KERNEL allocations for these init-time objects so the init path does not continue without the required tree nodes. Signed-off-by: Ruoyu Wang --- mm/memcontrol-v1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c index 433bba9dfe715..3f41a15d8a8cf 100644 --- a/mm/memcontrol-v1.c +++ b/mm/memcontrol-v1.c @@ -2246,7 +2246,8 @@ static int __init memcg1_init(void) for_each_node(node) { struct mem_cgroup_tree_per_node *rtpn; - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL | __GFP_NOFAIL, + node); rtpn->rb_root = RB_ROOT; rtpn->rb_rightmost = NULL; -- 2.51.0