From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5957D38945A for ; Mon, 8 Jun 2026 06:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780901561; cv=none; b=pqKdWo4n0w7mHJlnxRjxEgT+51frJEz8xJHDQWMIO0VW3S6nnTTg2wxoDE7Ok/5R26lVlqtZjyHrGQWO9V+7s6OVctIpGe5JHxHcTPVz4uDAna6tHGlgaq+V4whD8C0MxPyYFxehOvVrNM06Ub/k2Gj7z+NZFuOH7jlLWS8yUC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780901561; c=relaxed/simple; bh=tjzxBNSdqRFOyj6+g30EPXm40tLqjFJYlt5rAxFWtgI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rfA+CClZWG5qLhdbjNLIxn3VTuPVGJnvWfLhJPVCD3UISPost3MbiRSE4EyzzjgO/E3dmMWo72DvnjrYqPE9ERjpBB3oltUGxyfMbcVyiK+qoOHArY4tjWywWknralKhKDqq0fIi/7A1UufFktuXp6efG0sz/OnhDCVpOziEmZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KKjG+xG2; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KKjG+xG2" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36bcf3d2565so2720965a91.3 for ; Sun, 07 Jun 2026 23:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780901560; x=1781506360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MERoGnUio44nzGcqr2/zlC7emb75wJcMNQnRu8+qUzQ=; b=KKjG+xG236AhMY8t70PAO6I0C+5ZayjQKjbtkeNSP6B/59a03lC2qYq8CUs7AAHI34 tP0PsO8BJ8dYcOTZj1s45CZvbNGjap1j2ZBnpcH/KvD0wEmHWMZrjS15E7wYVP6mMU9l uxfhlhJQrFYRy+NXGc87PSuytsF2hLrLcnnHdcauelqT3x1sv4vt2j0RDLRs4uDS5qaC pvxTHuia6pU5RT8IUfA6FMpw8cjMt6XcAZMO7GFKbCW7LA7vZ3m9qyy4MuIpK4HPGrrI 0ZJK4tpomOjo0hUUNJtn3C8GDBWZFb3+V4oRjhkHELJB3WgGjECzAQJE8a97/jQDa27p Is3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780901560; x=1781506360; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MERoGnUio44nzGcqr2/zlC7emb75wJcMNQnRu8+qUzQ=; b=jX+1jwlJA5W30+TACCDp7bR/XvHHD46tCtZHxRceqp1ZEZcbPSHExK5bpy97xXFop8 JJyj6KPZG31u2rJf3NsoXo+Ue03I+L+VrRwR9V6+d7s3wo+3zZLJkonzLh9b9bsURpis 6QLjNU6H9U7JhlCM7XtYFcvF7VAt+bWj0cb0/B8ylh9LOAgTR2ZiZvNouNbLJikyAX9A PSy7YySpcFZI/AcXerYBcXcKq9PV96robHbD9seHrSG0nGNueYq7aR90m0R0DAfGEMlM J43VsyCgSTgjEKGi36ChBPNqmgWef+210zY+PAiPYDkl8CrTAKyH88itc9dTZdDNLhmJ wOkw== X-Forwarded-Encrypted: i=1; AFNElJ+egh/1E3JqrzRs2ddUOjYfaB5YSnMVR3r8w2EbjIpvmICLN5LHE5U/qrW0jmFxzOpiHs9wHEec7+NF95Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwbjFprns46jhyeVcqQA9BSaCortXLULEsVKK377jUFCcd196aK VqDQ2/ldZm3hmq1CG9J4GmOrEVXoRAV8mDdNHHwx+Ycti7dvbsCxAf5v X-Gm-Gg: Acq92OGDWZRT3TTQJrBYZ+h2iD1AFzUnYkehA8nRi6i74FLd+v8JQMOUC1Qxr4OsBpi gtxLP7DMsWbB6fah/itAUwCCgu23jMDXyi5jHR21Xy9xMNJRxnc2u4EFBPka0uQaIZCcTviS8D0 cDzWNyRjG0MGhxa6wkxQHLNoRAtXH/Khca0Ei0r3drBXI8aTgBM+r5bjHwohsUwDdD+nJXd5QLo lKbIHHgxfIb8XnOvZGfXqtWGSpvHbsHq/J/RIU4TNCPYEeZf5SgUgmQVeB/9RaI+e/wAu4L+/Af SN+joWng2iuyOg9YhUp2r54lNyMAkqtWfYXfEqrfU++LdYTAPY7W5MjSW/Qjdt3qCTalcXoaqfM Fbse5XrJ22T/PzR/OFBOgIVCVfs4FFyqh2SHEskFF+WwPU0Ltov4oxccGL5U7IQbdQIDoHtBmIB vIuSZ8S2GGWa0zsftjMXf2PRAt+9lazsPCG5uvTpCsqBE5y0LDX5dcolIzZRoRzbHEAd+H6XvnT i2D41ccqjTaM0t640qGwPpaSBuiG16xCN66I+onoxSWB7nlqr1/che+R7aqk7E4O91EHqO9M4qa xmbcXHiJMghszj9QUMCcICidS5/VHIM9zrEqLcn2MC8mcD4= X-Received: by 2002:a17:90b:6c3:b0:36d:6308:12fa with SMTP id 98e67ed59e1d1-370f0386f18mr15990477a91.18.1780901559625; Sun, 07 Jun 2026 23:52:39 -0700 (PDT) Received: from cs-1047136853211-default.asia-southeast1-a.c.d33bddc1d573818c7-tp.internal (163.184.87.34.bc.googleusercontent.com. [34.87.184.163]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6dba8521sm14477560a91.15.2026.06.07.23.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 23:52:39 -0700 (PDT) From: Aditya Prakash Srivastava To: Theodore Ts'o , Andreas Dilger Cc: Jan Kara , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Aditya Prakash Srivastava , syzbot+0c89d865531d053abb2d@syzkaller.appspotmail.com Subject: [PATCH] ext4: fix kernel BUG in ext4_write_inline_data_end Date: Mon, 8 Jun 2026 06:52:27 +0000 Message-ID: <20260608065227.3018-1-aditya.ansh182@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the data=journal mount option is used, the ext4_journalled_write_end() function incorrectly calls ext4_write_inline_data_end() without checking if the EXT4_STATE_MAY_INLINE_DATA flag is still set on the inode. If a previous attempt to convert the inline data to an extent failed (e.g. due to ENOSPC), the EXT4_STATE_MAY_INLINE_DATA flag is cleared, but the EXT4_INODE_INLINE_DATA flag remains set. In this scenario, the next call to ext4_write_begin() will not prepare the inline data xattr for writing, but ext4_journalled_write_end() will incorrectly attempt to write to it, triggering a BUG_ON(pos + len > EXT4_I(inode)->i_inline_size) in ext4_write_inline_data() since i_inline_size was not expanded. Fix this by ensuring that ext4_journalled_write_end() only calls ext4_write_inline_data_end() if the EXT4_STATE_MAY_INLINE_DATA flag is set, mirroring the behavior of ext4_write_end() and ext4_da_write_end(). Reported-by: syzbot+0c89d865531d053abb2d@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0c89d865531d053abb2d Fixes: 3fdcfb668fd7 ("ext4: add journalled write support for inline data") Signed-off-by: Aditya Prakash Srivastava --- fs/ext4/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index c2c2d6ac7f3d..4fce9ec176f8 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1560,7 +1560,8 @@ static int ext4_journalled_write_end(const struct kiocb *iocb, BUG_ON(!ext4_handle_valid(handle)); - if (ext4_has_inline_data(inode)) + if (ext4_has_inline_data(inode) && + ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) return ext4_write_inline_data_end(inode, pos, len, copied, folio); -- 2.47.3