From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9E03A2E12 for ; Mon, 8 Jun 2026 08:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906672; cv=none; b=nJEpIVNDwBo/jSo8EHU2mniCNeTRp0NRMwHeuU1Mha05A9tavYwcyHE4kJAWHgIuJf3kJ/Af3NkaDNRBQXv2BkGIE1SkKRoWVU19rAyCxvOMLC9z8nDq/DtLMZjzx/cRL3mfabuHijODSlila6Jcd7o6hCIkNRlO05ABUmn/WE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906672; c=relaxed/simple; bh=G3mPKW0gTsempXh1cngtGsHlKo8rWtAyp1QhWG0BVWo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W2e/Q1aBS8P7c3Hz7GC75yQC2CfctKm9bAXb5CIGOzPeB/sVzgiNmmL7NWhjumjm7EfkcV0igdCnmWwuAozK/+29T3t/8BBXbZcMtsxuAcvafqygXQtrGI8CdKnfw56T69NqSBhegXHYtXotUMW2xBCTSoOt9K48vmcqXfS+Xms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VQuSqOp7; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VQuSqOp7" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-3045c195251so3551843eec.1 for ; Mon, 08 Jun 2026 01:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780906670; x=1781511470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KqwFJZf77z3gY890YdN/zmCB2I+TWixDM2zm/X7SEng=; b=VQuSqOp7V0F632GCcfLgGz8uS+4bjwt2vNVgXW0V//nWlhtOM5vIkJkOHhmHvvgQVV fZK1drAusW7lWZW3aMJKkYd18KqhG5/UUKl7pFqiGB02g/cz6K+PFoRoMx2kTkFGPbCo WZLVjo5RfCCfoAbU1NVV44Pg1dZt8ph+KUfjfVpj1K/4IFjCgiJdr8W+8yLU/7Dgpzl3 CDRHFfHSK3T2uYgJvv0swiVtfTjRYbbcd7+LMjAjSTOUOGhv0E0jwT6oouHz0/ONs7lj 7EIYtJHFKPl8ROZ5dywIXhwq88rQtVp+K+fvKfyOKctb670EIt+RycoDSWDIHmmOxq34 wISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780906670; x=1781511470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KqwFJZf77z3gY890YdN/zmCB2I+TWixDM2zm/X7SEng=; b=Iuc6Cf+8D+BinhguEmrx+HWwoWE0+uMvJkB/FkqAMbSuepM6MiMsypaBVVoe6Ma1Ze XxNWmOruDd2W3UVzY58BOiUV+rHQmIFv2nrJlaeV75S94cPO23+xnxHp6WDeTEZ9AIZU rJBjzb4j12lCzPedFoEtARgxcHc6x3tdxSlE3htZiKwoTHk6v1inupn8nm5p0za/q4pX viiXCySnLsfbXu7Q99rYM4KDL9kqY1pDTwqG+Apu8j+JLxITwnMEHKZnLa5Ug9jeDhTW 8tZ1+ir29nGJGIw1yHHQP0EMeDz+w50RMy2AuzuX13C66RhVpo0wRW0ilUm227eCaAQo xDmg== X-Forwarded-Encrypted: i=1; AFNElJ+1wki3gKHXO4YAaXJ1mQbMBGLNZKuNEzVNZvmWXY1GZV52r7e5lv9ef+Da9L/HOX/+3A/+KyS7tiQAOuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyRype2QQOym7jSMfKkEwhrn2gIjT+9RxHGxfnF3qI7aFfUgQZc yZhUN7r/Y6up3MkE99YrZ5cZ0m17uSqaUx7TD4C6/c8OxVw+atmBgymQ X-Gm-Gg: Acq92OHmn1IjAgqWB6CW3KxXxGyCJIeB/NpqcedUbAsjJ1Cbca0po4I5O4aNDVzQjvz SnmPiBDnaxlpt+CHIv8EThcoizERNCNnFNQDUKDrnAFLAJ/IOKs3FvDwOvqv7/7vo39/oCcG8tH uMKpA+gm0FPEiv6VMHKrBaZ4maDQ1Uzr9owDJ4VgBkD8//HdpUwnswlzuTLCH9J1p/Wt2izKPHz h+BahTcwpTv6KvYkBaxSrsztrjt//F33F73eQyZmyVAIWr/0I37s64ixHZBA5xR8T6gqTCp5InA +tzzsXAVrRtTb4lD8KNmiu9KMKhBJpaIoZ18vQILgYMaFELK4tkXHAMDeEP88Hx2TVdkYM94V9t tkngcrUBaoeF9jNTy4lp78gHQ17oThUTahItMaepFcS54g1k8yDxSNkczOPS6yDLt9akEC3I/EN aRIILq6O+S96dzCAxNQCvi+HN2VXhILqsgeaCuQi/ouzy4u1F0BM8g8/EMKNgZZntZcQ== X-Received: by 2002:a05:693c:374c:b0:304:2cc9:2ba8 with SMTP id 5a478bee46e88-3077b32a2a0mr7233754eec.30.1780906670474; Mon, 08 Jun 2026 01:17:50 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-138063de4a5sm7678245c88.13.2026.06.08.01.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:17:50 -0700 (PDT) From: Hungyu Lin To: vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com Cc: abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, busanna.reddy@oss.qualcomm.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v5 1/2] media: qcom: iris: fix runtime PM reference leaks Date: Mon, 8 Jun 2026 08:17:20 +0000 Message-Id: <20260608081721.82846-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260608081721.82846-1-dennylin0707@gmail.com> References: <20260608081721.82846-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use pm_runtime_resume_and_get() in iris_enable_power_domains() to avoid leaking a runtime PM usage count on failure. Also ensure pm_runtime_put_sync() is always called in iris_disable_power_domains(), even when iris_opp_set_rate() fails, so runtime PM references remain balanced. Fixes: bb8a95aa038e ("media: iris: implement power management") Reviewed-by: Dmitry Baryshkov Signed-off-by: Hungyu Lin --- drivers/media/platform/qcom/iris/iris_resources.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c index 773f6548370a..6d3339423eec 100644 --- a/drivers/media/platform/qcom/iris/iris_resources.c +++ b/drivers/media/platform/qcom/iris/iris_resources.c @@ -78,24 +78,21 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev) if (ret) return ret; - ret = pm_runtime_get_sync(pd_dev); - if (ret < 0) - return ret; - - return ret; + return pm_runtime_resume_and_get(pd_dev); } int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) { int ret; + int pm_ret; ret = iris_opp_set_rate(core->dev, 0); - if (ret) - return ret; - pm_runtime_put_sync(pd_dev); + pm_ret = pm_runtime_put_sync(pd_dev); + if (!ret) + ret = pm_ret; - return 0; + return ret; } static struct clk *iris_get_clk_by_type(struct iris_core *core, enum platform_clk_type clk_type) -- 2.34.1