From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D5E279903 for ; Mon, 8 Jun 2026 22:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780958857; cv=none; b=QCXeChWThUFb9HwUXsC0Alf8vBd0TOqQiWFT8Gz7zUFQNlCinRKnkkFxSLlClQ3QlKSebgNtqB588IQYtt1HKxoRQ6LOIgIp15kUws9VzmMvC/PIVJQBEGmcNll42dxFTZ4X6Uw8jdpokLU/I12+wSm+xSUJ/b/GpFgbtg4yN1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780958857; c=relaxed/simple; bh=5VK/mTX0GEM5lcQ2tZNtSl9RkF1GQ+LOIJFoA8RdUW4=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=dE42WUiujNUsEmCFmhwup39Fr7Jk4peuhm3csr+NCIwzEEAGgoDYua3G2GkdPuYsrIts0hwMTbfZ5/EL7/1pmqYrkTM4NHb44A6lFfJpT1zGuQuMS60pCUWtG69jvgQdoSOFkEGkur3zU5GZFnrnTqAFCiCg4E0RcCblCxPfIBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=yx6LohOh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="yx6LohOh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 323561F00893; Mon, 8 Jun 2026 22:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1780958856; bh=xfqYHZdSV2g90vjfkntECdqiOvsjE2JnYKQaDnDRVtw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=yx6LohOhCyzEQ9653HoE7Z+miQUqXDnJbsgKOqJCXzNIFYt8Rk57lhYj1v38uLn9K +pMfiJcfnbg+LH8uWJC2LwPnfksKDZGFhcidi6wXi4ZBkqigdWwcjV98EHeklXI6Q6 +p/0WSu81awGKaS0GOme2nhoO9VlyuekGLJ6R3L8= Date: Mon, 8 Jun 2026 15:47:34 -0700 From: Andrew Morton To: "Gladyshev Ilya" Cc: ivgorbunov@me.com, Liam.Howlett@oracle.com, apopple@nvidia.com, artem.kuzin@huawei.com, baolin.wang@linux.alibaba.com, david@kernel.org, foxido@foxido.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, muchun.song@linux.dev, rppt@kernel.org, surenb@google.com, torvalds@linuxfoundation.org, vbabka@suse.cz, willy@infradead.org, yuzhao@google.com, ziy@nvidia.com, pfalcato@suse.de, kirill@shutemov.name Subject: Re: [PATCH v4 0/2] mm: improve folio refcount scalability Message-Id: <20260608154734.8e4115fde4e2e14a3b6892fb@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 08 Jun 2026 21:53:01 +0000 "Gladyshev Ilya" wrote: > This patch optimizes small file read performance and overall folio refcount > scalability by refactoring page_ref_add_unless [core of folio_try_get]. > This is alternative approach to previous attempts to fix small read > performance by avoiding refcount bumps [1][2]. Thanks. Nice numbers. AI review had some things to say: https://sashiko.dev/#/patchset/df26082871b4c65b2bd38d409026237c08572836@linux.dev I'm not sure we want all those new VM_BUG_ON_PAGE() calls in the long term. They look like development-time assistance. Perhaps you could make those a standalone patch at tail-of-series so we can keep it in linux-next for a couple of months then throw it away before any upstreaming?