From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84FD39F17F for ; Mon, 8 Jun 2026 21:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955258; cv=none; b=lz1d3m7E6FXv9tOHMucfBQF+GHK9BuQSxK4rsbTJm2VgvQzOqj9K4ZqWy4E/8VgItgztkLvLl+WpL8AHmvUtNAbJX5GnZEdpR/ddUFrtAGex08gu0en+qFeVf4QOxkDgthGyUZzysu1oveUOIO2N2+xFuWF6OsuKl3f+6R4V8EE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780955258; c=relaxed/simple; bh=Cs8RF66VXH0FZvNEec15nNUfJ+jOAg4nrbIAlIRIjWI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JzWleQF7iVckRzQXTlYq36q2Cv3NHTX/dVU3TbiDKYTuoG7kNqccWYR3VbM/lYWNySboHqiqWJT0G6sK4pA1+JigUe2XgcO1N17cCb0KfkLuBcaFmIn6enV+bKc5BU2qK0y/mRlmKcf3tq+wcvbC/ojLpLiEO7kDRT/TQ3ctXO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L1yDOYJp; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1yDOYJp" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-36b900f350fso4342609a91.0 for ; Mon, 08 Jun 2026 14:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780955256; x=1781560056; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UNWgux0XZGrYmGXRTAW1HdM7Fq4xDAdijXCv4nyh8y0=; b=L1yDOYJpYG2jl23KJu4avl87wwfrle2Mr6VS2anIRRzuzR3I3DQWFjUcsNo3fnWshu c6jK2ePuSi5HorAEpsavXd8sGky+tITeJD6aFdPvb4arzGBGZdjX4kFPgBBQFtHBijmc xYV4pl7k6ldN4sp9LnvwnXwzrP0p5lkpgPbOrQu0kQR8rYHVR6WXWQM7N38Y2IPwYd0B +zOoBsjV5HDnkLQEfE8a/+Op4RRCFeJZPUO+NucCmI9TSAAjotXrlSOzN2Z3KOqeRpt9 F5jcnhrMmnFmgo7meTMSNUPlnmpSOu71BZILD+81NsqrWB+G7bTPk4FvSfvKsIQb4rw7 KYPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780955256; x=1781560056; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNWgux0XZGrYmGXRTAW1HdM7Fq4xDAdijXCv4nyh8y0=; b=Mw9j8YbZ7yeYC1xmn2rc0EkTBzDxbPtnnhiRPypaooiihDEFANRutOMC/2H9TiY5rO p1qvUAwThNtkGfvE8YOU8rPbQ9f/I4H/p377C6mfzGb97aEJCUVUBZa2WVRacNGua5PD DUA7pYSFSwDj5vQSDmYA70vItXwoGJbnRmRy5ljJ8ojlQ4YGrtZq05WLU0L2xbfXVe5H OSZd+amFDtDt7CUxyInCfb32B3pjMTT02prMeHPQHx97nPF0XdPrmZK3FLmMUH6EuXy9 r2llue6K7d28rJoAmh27cLCKa32g2ZXiZbRayiHZ/3VNBxGJ/3KJJQ0YcYUtVNUa/hrj ZhoA== X-Forwarded-Encrypted: i=1; AFNElJ9u24irVivypXAzvSs0d2uUK8VqU+HREjEyL/2KvJIfD1TgKhJYQID2Mcuhns+dmlq4cqOqCOtM4wq90zM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp4jfvmAcHqBuPn0kHoXP7A8KTuSrn7LMyNMlkTdEKmOMHDBSx LDhljB6LVNoyty5IRFrkRJc2UzOlFd0/sv//xsg+nGPzGj+UEfCs1gIh X-Gm-Gg: Acq92OFRKsDhRa61AXZKEDa9xgrgVKzRDW7gtDUoO9RiTNMLDnBIWv69okOpsmSFexy J823T8S/GWlVH60HB1JzLLxpwkt+yScd5OgxACQWBobr7QlELeDaBu+Ysvj2rHvFjtWDMnFtZwZ Rl5lIkfd7SaBZfECaq0PCSM1d8PaTI4l+526Va4fG5QXMuTeMouhfiuoeBM57BIPcX+8Y8F0Euf dRxDb4M1UVa1PRB6FHTAh5HyKJBQ3ODc8RgCg6k9oulcyVQKudlCqWCn7JV6TcVAJvbg/VY5XyQ cKpXm9jUaLq3qh3HmC7Emp5MoNiKzenWsVXjrtuic7iT8oA0zgYIpUmeqr3IX2IeFFlN6481nDN VSLMlppLSPFf8e6bHDHbzCnJcjav/BmZkhpETDAbLOk5kfpse7Ek8N6WNOCGWgXf37sUUnfwdGq f+S7ShTSnFzJyBgnUJX8HecgQ2MyhGis2Owu0rI/xNIR1TffSbt+KD5lw8Mub+gc5itQBeYIXan WiQE281Jow65smV8Ae0Byjj7C1eZPspBGLNlRfFuqn+4Q== X-Received: by 2002:a17:90b:554c:b0:36b:9512:871b with SMTP id 98e67ed59e1d1-370eed0b682mr18481983a91.11.1780955256253; Mon, 08 Jun 2026 14:47:36 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0b2ddbsm16016505a12.24.2026.06.08.14.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 14:47:35 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Julia Lawall , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 0/4] ata: pata_mpc52xx: fix cleanup ordering and modernize Date: Mon, 8 Jun 2026 14:47:14 -0700 Message-ID: <20260608214718.49503-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix several lifecycle bugs in the MPC52xx ATA driver: - The BestComm task IRQ was managed by devm, creating a use-after-free and teardown inversion. Switch to non-devm request_irq/free_irq so the interrupt is unregistered before the task is freed. - The error and remove paths called irq_dispose_mapping() explicitly, duplicating the one in bcom_task_free(). Remove the redundant calls. - Replace irq_of_parse_and_map() with platform_get_irq() for proper error handling and integration with the platform device model. - Replace the open-coded of_address_to_resource()/devm_request_mem_region() /devm_ioremap() sequence with the standard helper. Rosen Penev (4): ata: pata_mpc52xx: switch to non-devm request_irq for proper ordering ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls ata: pata_mpc52xx: convert to platform_get_irq() ata: pata_mpc52xx: use devm_platform_get_and_ioremap_resource drivers/ata/pata_mpc52xx.c | 67 ++++++++++++-------------------------- 1 file changed, 21 insertions(+), 46 deletions(-) -- 2.54.0